DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.de;
  h=Received:X-YMail-OSG:Received:Date:From:To:Cc:Subject:Message-ID:Reply-To:Mail-Followup-To:MIME-Version:Content-Type:Content-Disposition:Content-Transfer-Encoding:User-Agent;
  b=5e+j+sLRdLGpDJxcLTdr7/uzndn8Vf+gKXVyPHWMGTsux6oso2pRc7GPulWvjtv0Rv5XzjLPgLAIx1VYDjIRWe0r+yOMfQUFhg6G+Ag8dSeI3/S6uZ8YPy381halxWDAFHf+Sdd5vP/chRqpwPfcaSW+DOVO/0DnabH3TwXBzOU=  ;
Date: Thu, 6 Dec 2007 22:13:35 +0100
From: Borislav Petkov <bbpetkov@yahoo.de>
To: Pavel Machek <pavel@suse.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC] swap image signature check upon resume
Message-ID: <20071206211335.GA4923@gollum.tnic>
Reply-To: bbpetkov@yahoo.de
Mail-Followup-To: bbpetkov@yahoo.de, Pavel Machek <pavel@suse.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1598
Lines: 41

Hi Pavel,
hi Rafael,

after a quick search i couldn't find anything dealing with the topic in the
subject line so here we go:

One sometimes can mix up (and by one i mean me) the
kernel images one boots after having suspended the machine previously. There can
be at least two reasons for that:

1. too many kernels in grub and having forgotten with which i suspended.
2. compile and install a new kernel and forget about it, suspend in the evening
and then boot with the new kernel;

in both cases you end up staring at fsck since they filesystems haven't been unmounted,
of course. Or at least see the warning message of some journal recovery whisk away.

In order to alleviate that, one could probably go, imho, and write in the swsusp_header
the kernel version which suspended the machine (UTS_RELEASE) alongside
SWSUSP_SIG and check that against the kernel version of the image just booting.
If they match then all is well, if not, one could

a) issue a BIG FAT WARNING and reboot telling the user to select the proper
image
b) ask the user what to do:
	- proceed as if "noresume" has been entered on the kernel command line
	- reboot after issuing the kernel version which suspended the machine
	-
c)...

In case you guys think something like that might be of use i can come up with a
patch in the next coupla days...

-- 
Regards/Gru?,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/