Received-SPF: pass (google.com: domain of linux-kernel+bounces-42-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1283-g327e3ec917-fm-20231207.002-g327e3ec9
Precedence: bulk
MIME-Version: 1.0
Message-Id: <374978b4-9bed-4d5c-90e2-344e46dedaf8@app.fastmail.com>
In-Reply-To: <40b5e438-22f4-43e5-9663-db44dd402a35@app.fastmail.com>
References: <202312041909.lwhcU35R-lkp@intel.com>
 <5f1caaf8-1edf-444a-b017-c4d08e52213b@infradead.org>
 <f712a65b-4984-46e8-bd43-1309b5cd41f0@app.fastmail.com>
 <c10194f2-097f-4455-9932-19961edbf990@infradead.org>
 <40b5e438-22f4-43e5-9663-db44dd402a35@app.fastmail.com>
Date: Thu, 14 Dec 2023 19:54:18 +0000
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
 "Randy Dunlap" <rdunlap@infradead.org>, "kernel test robot" <lkp@intel.com>,
 "Masahiro Yamada" <masahiroy@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
 "Nicolas Schier" <nicolas@fjasle.eu>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: pm.c:undefined reference to `i8042_command'
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 7, 2023, at 01:21, Jiaxun Yang wrote:
> =E5=9C=A82023=E5=B9=B412=E6=9C=886=E6=97=A5=E5=8D=81=E4=BA=8C=E6=9C=88=
 =E4=B8=8B=E5=8D=885:26=EF=BC=8CRandy Dunlap=E5=86=99=E9=81=93=EF=BC=9A
>> On 12/5/23 22:52, Arnd Bergmann wrote:
>>> On Wed, Dec 6, 2023, at 06:24, Randy Dunlap wrote:

>>> I think it's bad style to force-select an optional subsystem.
>>> How about making the entire file optional? It seems that there
>>> are already __weak functions in its place.
>>
>> Yes, I agree in general.
>>
>> Hopefully the maintainer will opine your suggestion.
>> Jiaxun?
>
> LGTM, PM is not an essential function here.
> Arnd, do you mind making it a patch?
>

I just tried it out and my version doesn't actually work since
we still end up building the file with SERIO_I82042=3Dm.

We could still make it work by checking for serio being
built-in here, but in the end I think that's worse than
Randy's patch, so let's just go with his original version.

      Arnd