Received-SPF: pass (google.com: domain of linux-kernel+bounces-500-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231215052033.550509-1-ghanshyam1898@gmail.com> <5a58e510-e5b4-42ae-95a3-257ca802212a@infradead.org>
In-Reply-To: <5a58e510-e5b4-42ae-95a3-257ca802212a@infradead.org>
From: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
Date: Fri, 15 Dec 2023 12:24:36 +0530
Message-ID: <CAG-Bmocu0nL-AW=nR7ZaTG4fzRvw4XSq5grk4N-wDRF0opMR4Q@mail.gmail.com>
Subject: Re: [PATCH] gpu: drm: amd: fixed typos
To: Randy Dunlap <rdunlap@infradead.org>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, 
	airlied@gmail.com, daniel@ffwll.ch, Hawking.Zhang@amd.com, candice.li@amd.com, 
	Le.Ma@amd.com, lijo.lazar@amd.com, amd-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 10:59=E2=80=AFAM Randy Dunlap <rdunlap@infradead.or=
g> wrote:
>
> Hi--
>
> On 12/14/23 21:20, Ghanshyam Agrawal wrote:
> > Fixed multiple typos in atomfirmware.h
> >
> > Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
> > ---
> >  drivers/gpu/drm/amd/include/atomfirmware.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/d=
rm/amd/include/atomfirmware.h
> > index fa7d6ced786f..41d553921adf 100644
> > --- a/drivers/gpu/drm/amd/include/atomfirmware.h
> > +++ b/drivers/gpu/drm/amd/include/atomfirmware.h
> > @@ -210,7 +210,7 @@ atom_bios_string          =3D "ATOM"
> >  };
> >  */
> >
> > -#pragma pack(1)                          /* BIOS data must use byte al=
igment*/
> > +#pragma pack(1)                          /* BIOS data must use byte al=
ignment */
> >
> >  enum atombios_image_offset{
> >    OFFSET_TO_ATOM_ROM_HEADER_POINTER          =3D 0x00000048,
> > @@ -452,7 +452,7 @@ struct atom_dtd_format
> >    uint8_t   refreshrate;
> >  };
> >
> > -/* atom_dtd_format.modemiscinfo defintion */
> > +/* atom_dtd_format.modemiscinfo definition */
> >  enum atom_dtd_format_modemiscinfo{
> >    ATOM_HSYNC_POLARITY    =3D 0x0002,
> >    ATOM_VSYNC_POLARITY    =3D 0x0004,
> > @@ -645,7 +645,7 @@ struct lcd_info_v2_1
> >    uint32_t reserved1[8];
> >  };
> >
> > -/* lcd_info_v2_1.panel_misc defintion */
> > +/* lcd_info_v2_1.panel_misc definition */
> >  enum atom_lcd_info_panel_misc{
> >    ATOM_PANEL_MISC_FPDI            =3D0x0002,
> >  };
> > @@ -683,7 +683,7 @@ enum atom_gpio_pin_assignment_gpio_id {
> >    /* gpio_id pre-define id for multiple usage */
> >    /* GPIO use to control PCIE_VDDC in certain SLT board */
> >    PCIE_VDDC_CONTROL_GPIO_PINID =3D 56,
> > -  /* if PP_AC_DC_SWITCH_GPIO_PINID in Gpio_Pin_LutTable, AC/DC swithin=
g feature is enable */
> > +  /* if PP_AC_DC_SWITCH_GPIO_PINID in Gpio_Pin_LutTable, AC/DC switchi=
ng feature is enable */
>
> s/enable/enabled/
>
> >    PP_AC_DC_SWITCH_GPIO_PINID =3D 60,
> >    /* VDDC_REGULATOR_VRHOT_GPIO_PINID in Gpio_Pin_LutTable, VRHot featu=
re is enable */
>
> Ditto.
> There may be a few more that need this same treatment.
>
> >    VDDC_VRHOT_GPIO_PINID =3D 61,
>
> The other changes look good as far as they go, but codespell reports
> a few more misspellings to consider:
>
> atomfirmware.h:213: aligment =3D=3D> alignment
> atomfirmware.h:257: Offest =3D=3D> Offset
> atomfirmware.h:258: Offest =3D=3D> Offset
> atomfirmware.h:390: Offest =3D=3D> Offset
> atomfirmware.h:455: defintion =3D=3D> definition
> atomfirmware.h:648: defintion =3D=3D> definition
> atomfirmware.h:686: swithing =3D=3D> switching
> atomfirmware.h:704: calcualted =3D=3D> calculated
> atomfirmware.h:967: compability =3D=3D> compatibility
> atomfirmware.h:981: intenal =3D=3D> internal
> atomfirmware.h:993: intenal =3D=3D> internal
> atomfirmware.h:3469: sequece =3D=3D> sequence
> atomfirmware.h:3507: indiate =3D=3D> indicate
> atomfirmware.h:4429: stucture =3D=3D> structure
> atomfirmware.h:4430: stucture =3D=3D> structure
> atomfirmware.h:4462: regiser =3D=3D> register
>
>
> thanks.
> --
> #Randy
> https://people.kernel.org/tglx/notes-about-netiquette
> https://subspace.kernel.org/etiquette.html

Hi Randy,

Thanks for your feedback. I will correct the grammatical errors.

Regarding the other codespell suggestions, if I make the changes
then checkpatch script gives a lot of errors and warnings. Some
are related to usage of tabs, line lengths etc. Being a beginner
in the linux kernel development, I am not sure how to fix
(or whether to ignore) those warnings. Would it be okay if I
proceed with only the small number of changes I have suggested
with this patch itself?

Thanks & Regards,
Ghanshyam Agrawal