Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6499323rdb; Thu, 14 Dec 2023 23:23:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFO1/hz7CiJvxwYSo0adEQcP5VHHSue56iO4fik1+epfid8MfjE5crvurr1krp6mJrKTXg2 X-Received: by 2002:a05:6830:1343:b0:6d9:d144:c9a9 with SMTP id r3-20020a056830134300b006d9d144c9a9mr11137321otq.22.1702624981925; Thu, 14 Dec 2023 23:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702624981; cv=none; d=google.com; s=arc-20160816; b=QUwg/getOcFg1ad7XoH1Nvss7Q3C3eQDXAd79f++YQ00oSEYo8Cr99mETsSyimn/WT 8uJCDlumdKBSTlkKVtX/zOga/Y8THIdxpPWZs5/ccEz2eNgAt109+amgwS0CTa9njFGD /vEMtNhqrRTpTQVoAWh47Xm6lk0HoHhtDxT01+S021DlAj/N905qPd3eMG1IZeIDXb38 mgA69+O3qoXpLRZ1X3OJcQN3A/TLRFz9bb9zdbc9ICPR2BlDtru2WBJ3aCfmw0FFVGlM Wls1YDSnsUs7t6IruC0VaGGfB0OfO6rPkAQsxAZJRYzasqUfLMTa2mpm8CWlAHsE6/QK Dzpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=z1N/IqnPuUTMF0bMvQG1DYelgzWvnk5JJ2yMI964gjE=; fh=dAlwgM/pc0WB3wrQeNI2ynkzERGK/K0xMg+Ng2ZIMoE=; b=lRVbOVt1/pbaOKeMfF8W6bEGxUgxoPRypE8N+P6Yxi6Wi4M5zffN7KYUaIcF5lt24i 9lng+EhoVBFSgL61rk2NLmFHF6owfXr/8aA86c5YWVH2LeG2VcSFPP0ERm2lf+OOfw5X aFVk4sU7pG9+RZ4WFBTImi1IcnHRkg3F1+PB4zeND+DFAGV/MULLOFFyLWFuFu6UCjAu mDea5gK2OlcTsx8ckbz+ebuhbP7dT4GY9YFYFoAuvttaP7JNdLPvJDlInumLyjQko5pI 8C2DcbM5Qf/LjNeJMc781echFJtO3kBVESxCOp8EhDQl6stP2LksJZLLshX7fPSLPCYO uzTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cocvtpnW; spf=pass (google.com: domain of linux-kernel+bounces-512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-512-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n10-20020a634d4a000000b005c1b313a127si12423631pgl.660.2023.12.14.23.23.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 23:23:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cocvtpnW; spf=pass (google.com: domain of linux-kernel+bounces-512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-512-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A78E0B2236B for ; Fri, 15 Dec 2023 07:23:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77344D2F1; Fri, 15 Dec 2023 07:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cocvtpnW" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 080F310782 for ; Fri, 15 Dec 2023 07:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a22eba5a290so39923566b.3 for ; Thu, 14 Dec 2023 23:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702624965; x=1703229765; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=z1N/IqnPuUTMF0bMvQG1DYelgzWvnk5JJ2yMI964gjE=; b=cocvtpnWDsShq++VOm79oPeBqGkYRijLzAvRYvcriKlVBzLftjTn/mvdFJ04y4qpJW 9DNpXjmm/SiNTrMxOPCTHZ5ORpj+L1Lwiepfm/97t52upua32Uf+FCY+b7dUqfXgvhu2 igLzN5nsHmKph3VOOvDC0BeNv5n1bmLfwVorusljBJkxOWD7yx4F/FSmo7IGWIxPX0hZ DBUfM2/X9BnXLuCcAEav0HNovaVHWrpFGQQOD9ZzkBBMdeLU5c4i5+vWhPJbm+2R7zwa c0kR8GP6ms3LTqxRGGtAA2/8LjkE/EsVSaqvFTlaqFZbtKpvtYZhbEJqb9PrpU3VttyW P1CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702624965; x=1703229765; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z1N/IqnPuUTMF0bMvQG1DYelgzWvnk5JJ2yMI964gjE=; b=pb00fmphPC6ADVA9AzYdm4ZZDyf/KJCwj1JLSy6GxAimm4AiAVbePh/rX9gBVFlZHK 3CYwMhbgAQXIHP9jAy9FyCnySm+yDHoyIAZAHpKoBVlDypi0gnlcuWMRlhvyvphpOWv+ azyTWoKCt7nxgNFISdICK7d8Rk8A+seQtuV2yfPjVbRboBn2crntWVreVzTA0tulcmfb p8xtMEztWOhSVnMQdNLf66ghLl2SdU0oiVXKlX9dUR3NHlp0qFjvak7rDZws3iZSJTmf MKzEHubCaZ2Z/uGG1QcZnIXsGkDuj0ZBEhMiSYTJ2QbRSR3sRczn5df34HIMBRRGklLq 2rJQ== X-Gm-Message-State: AOJu0YwuDh/0M7spxq7U2wjW2UHtm8b3hPNfTkvCcrOlYI8oiDzklnrK G/cxjemhKUOnyJIf+nI74zdZvg== X-Received: by 2002:a17:906:7398:b0:a19:a19b:55de with SMTP id f24-20020a170906739800b00a19a19b55demr4954226ejl.110.1702624965226; Thu, 14 Dec 2023 23:22:45 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id vk2-20020a170907cbc200b00a1d3e9e888bsm10423928ejc.55.2023.12.14.23.22.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 23:22:44 -0800 (PST) Message-ID: <3b7072c5-8b38-418f-b960-3c5401e8b18f@linaro.org> Date: Fri, 15 Dec 2023 08:22:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local To: Siddh Raman Pant Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Suman Ghosh , netdev , linux-kernel , syzbot+bbe84a4010eeea00982d References: <6a26e3b65817bb31cb11c8dde5b1b420071d944e.1702404519.git.code@siddh.me> <1813902b-6afc-4539-96b2-050df6fc75c1@linaro.org> <18c695b4512.5afde007311004.1718468931473736202@siddh.me> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <18c695b4512.5afde007311004.1718468931473736202@siddh.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/12/2023 18:23, Siddh Raman Pant wrote: > On Wed, 13 Dec 2023 13:10:16 +0530, Krzysztof Kozlowski wrote: >>> - if (sk_acceptq_is_full(parent)) { >>> - reason = LLCP_DM_REJ; >>> - release_sock(&sock->sk); >>> - sock_put(&sock->sk); >>> - goto fail; >>> - } >>> + if (sk_acceptq_is_full(parent)) >>> + goto fail_put_sock; >> >> I would argue that you reshuffle here more code than needed for the fix. >> >> This should fix only missing dev reference, not reshuffle code. It's a >> bugfix, not cleanup. > > So this should not be done? I did it because you told to extend the > cleanup label in v3 discussion. It can be done but not in the same commit. You must not combine fixes with other changes. Also, each commit is one logical change. Best regards, Krzysztof