Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6503621rdb; Thu, 14 Dec 2023 23:35:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9eP7PZE6wGwshszElCWVVSOmGqYgdvKpH608mlM4mn+VZ9ph6a+x5zsMQf+l2WOKQ5DHL X-Received: by 2002:a05:6870:a116:b0:203:2824:58c1 with SMTP id m22-20020a056870a11600b00203282458c1mr4082843oae.78.1702625728047; Thu, 14 Dec 2023 23:35:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702625728; cv=none; d=google.com; s=arc-20160816; b=BW1NBidWutW6ssuhuNWn6TGlet02UhRWXra1mDPMvjfS5alOEhVA6bwDwl+UECuOGs XMbmltRdcc4NZCAU3Hz77VV9Fjk0UvYsfjPufiJTiV/bhYD2E8Q4vqedDPj12RqDKA+E f2UId5wB8pPlkmsnejWs+zWsP6fOkOR4r7LOzEqXj6DI7XZIpteCxvS/dyKt2qvvesy7 EoZcz1vPjn752MkF49gk6cEK72fNyeEgJsOaDRp995F5Arxv0cUa7Xo2YGuG8V7jydn8 qAqcdKOj15fcne2JVzxNmj1crooIvJvKTb7txBeAG8eFLz/v2LzLaZgr3NwvbwFsU8BB b1+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zMcKYURrBFe8z2q+lqVNoTJLZLk7xsiEFMOlgSsyTU4=; fh=G7Zl2dYk0c2/CcUWFlmVKo6qKvgD+i5ShSlermqBP0E=; b=svFrnZUGqQKeIimwGWfAx0ZRN17oUXxIU/IFxlLAoJhsynDNyuM4c/bM0mCw3uw3MN vppxY5g6D+m+jgqyxYGVlHQXOY4vY+wJi41GbuRz4gHFBgxl3VRg6fxCnwzosFHJTlGl j+eIl/OuF5iu+V2Y3YPUz4Wv/fvvK3w/tAusCV9olrsVanD5m3KXbKoe2fficoln4uGS h+4oB+wUsIBsxgfrgFo3UXYriu7F6C2AmDDL4cmwc340MnUNS/KHGY8lWSVUa7D1VX+q djDja6rjHkLTzSAMU/TnOvUjVYr9Cp5gtwwEGA6hOQUtoCTo/k7gu6qSVXL5n8bqSlfz Rp2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HpD4UKJh; spf=pass (google.com: domain of linux-kernel+bounces-526-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l22-20020a656816000000b005c626128e67si12789830pgt.494.2023.12.14.23.35.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 23:35:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-526-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HpD4UKJh; spf=pass (google.com: domain of linux-kernel+bounces-526-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AC4642841C0 for ; Fri, 15 Dec 2023 07:35:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 479D7111AF; Fri, 15 Dec 2023 07:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HpD4UKJh" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631781096B; Fri, 15 Dec 2023 07:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFFB8C433CB; Fri, 15 Dec 2023 07:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702625684; bh=ccmOE9j3jNhe4GDIdM1CW0I44hLwXu8dmx+o/QgsK+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HpD4UKJhNlD8/uebof6RQdb+aUvamm7Xl7XMyPaL/3KLU9qCdNJfISUWjS9XhFI93 tbXBqqXVbRbMAyAY5qPzLjL+CeiTLfJAnUZkNebVc5+BxOdZBr1ufqzFgZj6M6txsI tvTR8UqrZgRNTv/cmj/yFjbiyJENmTklp9X/zAyqqP0k22r92+CnhUzL6dI8Je+KzD /GqVrTX70r5tUe2kIEfsLTrSds44PSed3O/NiOTlqzqkDI2HE4YdJpII+VgYSi2JZ/ I2EFC64gljV1y/2KirKfWFjrAOorKc52tTXb1LW12WNnKHf1qnUC3E17gPL1uDu7vu /Ef5Airp/WBoA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rE2iV-00066d-2I; Fri, 15 Dec 2023 08:34:39 +0100 Date: Fri, 15 Dec 2023 08:34:39 +0100 From: Johan Hovold To: Richard Acayan Cc: Johan Hovold , Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts Message-ID: References: <20231214074319.11023-1-johan+linaro@kernel.org> <20231214074319.11023-2-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 14, 2023 at 08:46:27PM -0500, Richard Acayan wrote: > On Thu, Dec 14, 2023 at 08:43:17AM +0100, Johan Hovold wrote: > > The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt > > controller in order to be able to wake the system up from low-power > > states and to be able to detect disconnect events, which requires > > triggering on falling edges. > > > > A recent commit updated the trigger type but failed to change the > > interrupt provider as required. This leads to the current Linux driver > > failing to probe instead of printing an error during suspend and USB > > wakeup not working as intended. > > > > Fixes: de3b3de30999 ("arm64: dts: qcom: sdm670: fix USB wakeup interrupt types") > > Fixes: 07c8ded6e373 ("arm64: dts: qcom: add sdm670 and pixel 3a device trees") > > Cc: stable@vger.kernel.org # 6.2 > > Cc: Richard Acayan > > Signed-off-by: Johan Hovold > > --- > > Tested-by: Richard Acayan > > On a Pixel 3a, plugging in a USB cable doesn't wake up the device > (presumably because there is no wakeup-source property) but this gets > USB working again on linux-next. Thanks for testing. And yes, the wakeup interrupts will indeed not be enabled at system suspend unless the wakeup-source property is there. Did you try adding it? Johan