Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6510730rdb; Thu, 14 Dec 2023 23:59:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9Mbasjhs3AYkpoOOEJC3HhHxEiypixXHDeiBu6BANbdv868HS7MNb0V7tWc/HcMxNS76Q X-Received: by 2002:a05:6870:70a0:b0:1fb:75a:c428 with SMTP id v32-20020a05687070a000b001fb075ac428mr10070809oae.81.1702627145377; Thu, 14 Dec 2023 23:59:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702627145; cv=none; d=google.com; s=arc-20160816; b=yRUQIz4ZC5RgNery4TRyXzuoZDBJ9IZUjbrd+wRKJNggzxTWGdPg1mBxfII3XeNRoy BHz069yPTJ3NwpTW10eEkbdnr24bOl+QsUOc3rk5pOACbjHD8fQDiulnSqRZ0iLuMWpt o8MBgl4GJFjY3BX3Si8PK76+EA8V+Jdc/eQ+mlYWqFrW1xUt2DrcFBOVpYkldPewSbdr 2fU19KysEBMQ2wCjoU3iTOXVbZLx98QVTQkvO6dQv0DsC7BdtZrNEXFQHHnN5iR/VdmT MIpN6rco1Z3wPO2PR7CR5a/Ci9SZjqY8thmrG4BGQqC1uBiS9f7OQDO09dzxAoX87NEV PtTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=EmMERqa5FRYDmluuYvOt81FmFQ/Yl19qAIoykajJP44=; fh=ULUieucapNHmwm30v2rLAp4VePoW+svdC7rkHeCbn4k=; b=yTVIgXmIHu3TGIPv+gKJZlMXpRgPvdrUZAkIQ+obmfwiGab+JocD5PxRMqJ5So3u+w TeBO0QKWPr9gHANEPMtHk8iPW/IVIuq+7wzipoSwEoiVszgYP4ZQriHSBnL7EDvUdh3m /El4zVxKvV/uJX0GgXpsCyzIicKDYyQlFzt1OCxwBl1hkzt8CkWakAyweskgML9AI0P4 Yb6orY28NwqwuiMg9QPumB6Qp2m7aSz5+mpNBaWm7P6uQP+0RVzirU31r1Euh3aqoAeO batNIMKxBaZJy9JEPTJtTYWURiF+bP2HWquCaSiauyLQuCaPDXXcfPn2ezGswAUYFb3Q WlAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hSq1FQQh; spf=pass (google.com: domain of linux-kernel+bounces-569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-569-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bs64-20020a632843000000b00563de199314si12757668pgb.896.2023.12.14.23.59.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 23:59:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hSq1FQQh; spf=pass (google.com: domain of linux-kernel+bounces-569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-569-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3F264B20E2B for ; Fri, 15 Dec 2023 07:59:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7832510A28; Fri, 15 Dec 2023 07:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hSq1FQQh" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2261094A for ; Fri, 15 Dec 2023 07:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a1f8a1e9637so59534866b.1 for ; Thu, 14 Dec 2023 23:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702627126; x=1703231926; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EmMERqa5FRYDmluuYvOt81FmFQ/Yl19qAIoykajJP44=; b=hSq1FQQhMt0hq2CraE7vbzr8AOVvt/eUooKWtwtf6fJT0mKUMP3Nc2LMPcLyABl8GM HMdgkjDZqMXmdj1tMMuLHzzodJgU19nl3AUjV2hJ2vRmLSyTLBZl33dvqSLM4cYoCfmw +wyh83KSW9hzMwaW34G5Ea1E7PccoIRezbS8mFBke9idalx6FuhnimK9AdYrDeapY4Q0 OccjTHmsuyoHZm02UhmflSLATHI0Yii8TUdmmByWol9G0XdTMidZaRI6jeS4js1JXubo zrqRIg2VJ/01Txd9nIU7sJPoO6Tw9g1LGWL8HFE1MQvcEk3xthT6M3XDydb9Am4sF1EH 1boA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702627126; x=1703231926; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EmMERqa5FRYDmluuYvOt81FmFQ/Yl19qAIoykajJP44=; b=oaaxzW42AHZIRuamNmIZFgThzvbb/bHOH1ctWl+ZOvma5eJ5O1NYir4LRbU4OseuFt lfG+1n1tNEbf/d5qfpzfSqgUowMpEs5LswLwNnUTLaCgV7xpaF/pG1hB7W3zmqeJAgUF 81GzRV5EhoTW5MziZ/xD/IEFpax64pgv0TDQps+Rzkvx/HN1+Pe6Zl+Cu7FQFAbI1AXt ofX1jFPGR8uDgTIDuWF76G/5sa7W02XDj+1mMaom1Vlhdvv7CUBVVfm3n9dy1wrHD2lN 4MYBAyt8tgeDDjYnQwfPqUk212i3X/u726MHfkpk0oAUzBbNTF5++ABugzlOo8WyhWVs fZ6g== X-Gm-Message-State: AOJu0YxlJmT3A+Qqj7h5Ex8ciBIuok7QUgzPswJG8WEDX7EllAkheOJH n4AutrWUT7IUOb3uJYVwStoSgg== X-Received: by 2002:a17:906:8a55:b0:a1a:81aa:56cc with SMTP id gx21-20020a1709068a5500b00a1a81aa56ccmr12349703ejc.26.1702627125988; Thu, 14 Dec 2023 23:58:45 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id qo5-20020a170907874500b00a1b7b0cc30dsm10410257ejc.7.2023.12.14.23.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 23:58:45 -0800 (PST) Message-ID: <8e3335dc-915c-4db2-8884-e16795e166de@linaro.org> Date: Fri, 15 Dec 2023 08:58:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/13] dt-bindings: serial: samsung: gs101: make reg-io-width required property Content-Language: en-US To: Tudor Ambarus , peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, catalin.marinas@arm.com, will@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org Cc: andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org References: <20231214105243.3707730-1-tudor.ambarus@linaro.org> <20231214105243.3707730-5-tudor.ambarus@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231214105243.3707730-5-tudor.ambarus@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/12/2023 11:52, Tudor Ambarus wrote: > GS101 only allows 32-bit register accesses. When using 8-bit reg > accesses on gs101, a SError Interrupt is raised causing the system > unusable. > > Make reg-io-width a required property and expect for it a value of 4. > > Signed-off-by: Tudor Ambarus > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > index 133259ed3a34..cc896d7e2a3d 100644 > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > @@ -143,6 +143,10 @@ allOf: > then: > required: > - samsung,uart-fifosize > + - reg-io-width > + properties: > + reg-io-width: > + const: 4 If all your ports are like this, then I say this is compatible-specific. Make it here "reg-io-width: false" and set in the driver proper type in s3c24xx_serial_init_port_default() (or new function). Although maybe let's first resolve discussion of next patch. Best regards, Krzysztof