Received-SPF: pass (google.com: domain of linux-kernel+bounces-573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 15 Dec 2023 08:01:04 +0000
From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	shenjian15@huawei.com, wangjie125@huawei.com,
	liuyonglong@huawei.com, lanhao@huawei.com, wangpeiyang1@huawei.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on
 ras mod
Message-ID: <20231215080104.GV5817@kernel.org>
References: <20231214141135.613485-1-shaojijie@huawei.com>
 <20231214141135.613485-3-shaojijie@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231214141135.613485-3-shaojijie@huawei.com>

On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
> From: Peiyang Wang <wangpeiyang1@huawei.com>
> 
> Dump more reg info base on ras mod before reset, which is useful to
> analyze the ras error.
> 
> Signed-off-by: Peiyang Wang <wangpeiyang1@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

...

> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> index 68b738affa66..45a783a50643 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> @@ -5,6 +5,7 @@
>  #define __HCLGE_ERR_H
>  
>  #include "hclge_main.h"
> +#include "hclge_debugfs.h"

Hi Jijie Shao and Peiyang Wang,

hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.

With the above include added, these constants are now also defined
in files that include hclge_err.h. Which leads to them
being defined but unused in hclge_main.c.

At a glance, it seems that these constants are only used in hclge_debugfs.c.
Perhaps they could simply be moved there?

Flagged by gcc-13 W=1 allmodconfig builds.

>  #include "hnae3.h"
>  
>  #define HCLGE_MPF_RAS_INT_MIN_BD_NUM	10

...