Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6513260rdb; Fri, 15 Dec 2023 00:03:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpYdMu5rJtBaYUHayLfhmEuEJPsz0j7soDOkMNieUNGsaopGgjxUikMLayGdiLWVNfOsbp X-Received: by 2002:a05:6214:4009:b0:67f:1368:5ec3 with SMTP id kd9-20020a056214400900b0067f13685ec3mr2097416qvb.64.1702627436329; Fri, 15 Dec 2023 00:03:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702627436; cv=none; d=google.com; s=arc-20160816; b=GW4f5C+tqVl57OtD5WGQ2gbiePyIW0NfEzExyJ60+8uR6LU2JX9StJoQyTpg1hqMSa RKqYxXb0rv7Sq7R0t5/w+S6D8f/cBd7Es7cortm77Zb2BxwqrPXfM2JibaYQEJNQ4NI0 pSQN5w0Apxg2TPxguHpTDFmiTICePCPAAH2Vtgr1MVtLuHUqQjtVSIzVLWnp365iEaTE XkkM3UGuHSOvv9oPEhoowLabsrwO+eQzN+IXSg0hEXYZKjoAlWpaiBvdbInMbZl3bgS4 4v1BgtLGQSXczHb73FGeCdGdWy/eIcUb3A9i8LFSLSiIL0v3EhG4F8UScfFj8Kui4Nny IX9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=I6WQFeEW/xag5nkO1YUQ0HVzsFkfjBQaN8HBiIjireg=; fh=kcgU0zlDUgnimr+i6v94uJFjD+ehLkZVEFcAQhWFiNM=; b=Wkk6rct5Pp3q0HbyLFwvI+7C0sCer/MCkYYD90xSNBKhxMGo5DhyBoZs57kvM3qbmS FMuamQQwJsA3jQvVlON25YTryOOpJT9omMkGNsrpT56A1OwDINv8anKgL/vPm/+diLYm RsH8MwmazGFcPHLy7ywahrIxxMPF7Ynua7TVsLws8fuTDhnTGOuai4+apa1L+bUJL2vS 0zGakw8Wc5tDSGk3Ja5c5Lwg1sJRKHG3HcMokiWlCPiYDaH9eP4i3TPvbrIM6Zuri/9s gMOvDewl/By2u355Q3H+ks3etfSJvIWuZZ4M/9ipWu1ZJxMLINgqDyI1nLJX7AeEb0lv F1Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JKVp61II; spf=pass (google.com: domain of linux-kernel+bounces-578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id z2-20020a0cf002000000b0067ee85203d5si2031308qvk.554.2023.12.15.00.03.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 00:03:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JKVp61II; spf=pass (google.com: domain of linux-kernel+bounces-578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1D46F1C20803 for ; Fri, 15 Dec 2023 08:03:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39C9D10A37; Fri, 15 Dec 2023 08:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JKVp61II" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EE4012E40; Fri, 15 Dec 2023 08:03:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34F3DC433C7; Fri, 15 Dec 2023 08:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702627425; bh=p9x1fXgVjeCici0BVx/zhFbZXBS2ONfRfVclygpC/1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JKVp61IIC+9onKloh5tAwcWq/WXWqCw/PsDYjyi953raW7v0lsSP8zGwnYt3q+0IR rptS/NCci7c/SCk4RWJQelYO75hLFGuoJG6YejmX8u+ReEdjLR5xzjZ9VEP9SiBJrl gkE7QBKFcOytBSjv4/IOdIEIFjjO4CZrMPLa00IFlCRmHu2frzXL22iq+3L7UxAV+K skC3/T7XmzCjvzlPalUxO34YxTZQqivLsEF2BrpxEGDSg5z6bdg4TpAcJR0FL+5Xpe TYKPjO/6OlQDrgTi1fkZ1/QTcQt1sN03VYWQv8Z4G1fSyEZtIo4Sm9BGskWuI7q2c3 xh2S55gywsqdQ== Date: Fri, 15 Dec 2023 08:03:40 +0000 From: Simon Horman To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, lanhao@huawei.com, wangpeiyang1@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net-next 3/3] net: hns3: support dump pfc frame statistics in tx timeout log Message-ID: <20231215080340.GW5817@kernel.org> References: <20231214141135.613485-1-shaojijie@huawei.com> <20231214141135.613485-4-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214141135.613485-4-shaojijie@huawei.com> On Thu, Dec 14, 2023 at 10:11:35PM +0800, Jijie Shao wrote: > Continuous pfc frames may cause tx timeout. > Therefore, pfc frame statistics are added to logs. > > Signed-off-by: Jijie Shao Thanks, I agree it is good to include this information, which may relate to a timeout, in the existing log message for timeouts. Reviewed-by: Simon Horman