Received-SPF: pass (google.com: domain of linux-kernel+bounces-596-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
CC: "Winkler, Tomas" <tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sakari Ailus
	<sakari.ailus@linux.intel.com>, "andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>, "Usyskin, Alexander"
	<alexander.usyskin@intel.com>, "Teres Alexis, Alan Previn"
	<alan.previn.teres.alexis@intel.com>, "Ceraolo Spurio, Daniele"
	<daniele.ceraolospurio@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] mei: rework Kconfig dependencies
Thread-Topic: [PATCH 2/2] mei: rework Kconfig dependencies
Thread-Index: AQHaLr0G6pwygARoCUeUOjB8AQesH7Cp/ZkQ
Date: Fri, 15 Dec 2023 08:11:51 +0000
Message-ID: <DM6PR11MB4316DD6B97A68DD07DCBC40C8D93A@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20231214183946.109124-1-arnd@kernel.org>
 <20231214183946.109124-2-arnd@kernel.org>
In-Reply-To: <20231214183946.109124-2-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kg5/WkmK028F0YZ8HUX7n1iJ2c7QDSNJAyeeOrpsFqoS2bNiRYZcQOe/rl5j?=
 =?us-ascii?Q?1GacZHD0z5NN4Q1rdW5CLP02EcKeTvduoan9dM3T08SkAV2H0P9YEBf3K3i/?=
 =?us-ascii?Q?gxOPRv5W1NAj4Or8n5H1mlYJPjjaQmArA2DqH2a1LtW9pGAiAS/kloBhYz+T?=
 =?us-ascii?Q?cN9jl4c/9jLh++234d/p+2I1ONBx64udBRB9LTIUDiPNsk8yVs59NU4tTIyj?=
 =?us-ascii?Q?HEcEBwCvUJqXgLb1R6YtHD2PCVNzaLo2qCWo/PNoxasnayCug1a24tGDgysn?=
 =?us-ascii?Q?8N/QkgPQYBsvRpmQXMHQDlRXO0nrxGgC5WzO5QvZZpDbheYx6/zlTS7pJK6S?=
 =?us-ascii?Q?3yS5cp94Qw+/fZRLFi0L+D+QlKMQYDWLujPS6yTSCNZzy1BCaZ+GBSOMZPSf?=
 =?us-ascii?Q?TOJ94MC7WK/twQ0icryu6wRwG3DRAGKodLtn8bvJXh0uM6tk3XLJc0j6o5Ly?=
 =?us-ascii?Q?4GqaTQRR95aKcOq83upB/wBM6GPLOViujb4dBSi61qXeXnZzcfziwjkvDQxV?=
 =?us-ascii?Q?TDxah6/mEC/8AbM/ITyhQ7Pr+ARJ02b+Qp3G8b5s8mioze0Wvb+euahkfpKd?=
 =?us-ascii?Q?C8GMFG5s3JggwiI3zTBLiUe1QlMDLxdwDnWMQAvaKX3faFOYyXtwNl2d+zSp?=
 =?us-ascii?Q?G3eGZOwh+D8o7OBaCS9W8BQLIaEty31thDb2/EvabNTVrqr5t05Kv3yPcp+c?=
 =?us-ascii?Q?hVXw5y7/vBbz3gJWUog42ZBFLLOu9nmsCK4+cLgvgt91iaYv9/N2HHwR6T2d?=
 =?us-ascii?Q?1XGsVYsEnr1lCx4txARrpxXOgF/muPbZo3T7KQUaE1EoWIrd1mxDoDSnZ96y?=
 =?us-ascii?Q?f/U2qNtRrseED1rkU4zwGuiuK26p5ciKTG+7sQVxR1QHWpY5YlQ02MrJUH7K?=
 =?us-ascii?Q?sD25xP83jx3quDn3r5DkZkgaf0Ddvu5ijIZLcLsOCDe29hYp6T0q2O+V7TSA?=
 =?us-ascii?Q?MUuDNJ23wkjCS4TudixF6d7PT6cF1dAqZFAjPAC0Zo6w9ebM5EHzk0zWGQA5?=
 =?us-ascii?Q?VbNzGKKmSxzhpZaFgRzzKbihItqlSUTDEbURkLcYm1uODxgzXTnDZnSs6oMa?=
 =?us-ascii?Q?tSBGpYzym/JOyn01HpTMJsSO0KbXDOEyoRZbSkPqUMifAFUzQfR3GBNaamX6?=
 =?us-ascii?Q?gU0rCtV+bz1toMJNz/747oXYxonzvOJa6WrsDRfEXtZnPxmEE3T6vVH+sLoI?=
 =?us-ascii?Q?4mJGxQBIqFnv8icHO9wbMTw9kfNkLUYH0knrA5xAa8b792yZN8hSzdeQdrvc?=
 =?us-ascii?Q?SZg2keLiNCjpeZ8uaN5U8DP2mrWZhw7XgBG8bkL32bssYzhUkDpktKMpW4no?=
 =?us-ascii?Q?j6xTt9eKd922XFeiE1vECO6cxbsCKczUZ3MqVYxRFedUcbn+HiVFiRWn/paB?=
 =?us-ascii?Q?hyjIFClWK/9YZlHDBwaB5vjrLknLTeOe08aFvWbHfaL1CV1rdAL+lnWjiZ+S?=
 =?us-ascii?Q?iDJGONmjYaAEW3yjyBUzrI64K35Vd8vVR2TcfVjkorsmrddK2FdL9S8RsvDd?=
 =?us-ascii?Q?hWvGd560MTpHrIgOjlOjHgWhu3dAv2KJqt1iQYBFMIep7tKCbVlV6lddigIB?=
 =?us-ascii?Q?G2hScibhwBFzWJoBLbMLETmn7ayhv5VoeA8STzsG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf88ccb-55ad-44f2-c3a4-08dbfd457e66
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2023 08:11:51.7870
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G/n+3SHO/kbn7b0SAdBeRWa+dErayKstQ45F75YWdgi0OfOLxEDW5TvrrETmFaaMOuEos7HqZ8PO6zZUaFKGdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7014
X-OriginatorOrg: intel.com

> From: Arnd Bergmann <arnd@kernel.org> Sent: Friday, December 15, 2023 2:4=
0 AM
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The dependencies in the mei framework are inconsistent, with some symbols
> using 'select INTEL_MEI' to force it being enabled and others using 'depe=
nds on
> INTEL_MEI'.
>=20
> In general, one should not select user-visible symbols, so change all of =
these to
> normal dependencies, but change the default on INTEL_MEI to be enabled wh=
en
> building a kernel for an Intel CPU with ME or a generic
> x86 kernel.
>=20
> Having consistent dependencies makes the 'menuconfig' listing more readab=
le
> by using proper indentation.
>=20
> A large if/endif block is just a simpler syntax than repeating the depend=
encies for
> each symbol.

Yes, I agree it will make future changes more easier.

Reviewed-by: Wentong Wu <wentong.wu@intel.com>

>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This does not fix a bug, but seems like a sensible cleanup to me, making =
the logic
> less error-prone for future changes. Feel free to just take the first pat=
ch and
> ignore this one if I missed an important reason for the original variant,=
 or if you
> prefer a different method.
> ---
>  drivers/misc/mei/Kconfig           | 14 ++++++--------
>  drivers/misc/mei/gsc_proxy/Kconfig |  2 +-
>  drivers/misc/mei/hdcp/Kconfig      |  2 +-
>  drivers/misc/mei/pxp/Kconfig       |  2 +-
>  4 files changed, 9 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
> 1e28ca23a74a..67d9391f1855 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -3,6 +3,7 @@
>  config INTEL_MEI
>  	tristate "Intel Management Engine Interface"
>  	depends on X86 && PCI
> +	default GENERIC_CPU || MCORE2 || MATOM || X86_GENERIC
>  	help
>  	  The Intel Management Engine (Intel ME) provides Manageability,
>  	  Security and Media services for system containing Intel chipsets.
> @@ -11,10 +12,11 @@ config INTEL_MEI
>  	  For more information see
>  	  <https://software.intel.com/en-us/manageability/>
>=20
> +if INTEL_MEI
> +
>  config INTEL_MEI_ME
>  	tristate "ME Enabled Intel Chipsets"
> -	select INTEL_MEI
> -	depends on X86 && PCI
> +	default y
>  	help
>  	  MEI support for ME Enabled Intel chipsets.
>=20
> @@ -38,8 +40,6 @@ config INTEL_MEI_ME
>=20
>  config INTEL_MEI_TXE
>  	tristate "Intel Trusted Execution Environment with ME Interface"
> -	select INTEL_MEI
> -	depends on X86 && PCI
>  	help
>  	  MEI Support for Trusted Execution Environment device on Intel SoCs
>=20
> @@ -48,9 +48,7 @@ config INTEL_MEI_TXE
>=20
>  config INTEL_MEI_GSC
>  	tristate "Intel MEI GSC embedded device"
> -	depends on INTEL_MEI
>  	depends on INTEL_MEI_ME
> -	depends on X86 && PCI
>  	depends on DRM_I915
>  	help
>  	  Intel auxiliary driver for GSC devices embedded in Intel graphics dev=
ices.
> @@ -62,7 +60,6 @@ config INTEL_MEI_GSC
>=20
>  config INTEL_MEI_VSC_HW
>  	tristate "Intel visual sensing controller device transport driver"
> -	depends on INTEL_MEI
>  	depends on ACPI && SPI
>  	depends on GPIOLIB || COMPILE_TEST
>  	help
> @@ -75,7 +72,6 @@ config INTEL_MEI_VSC_HW  config INTEL_MEI_VSC
>  	tristate "Intel visual sensing controller device with ME interface"
>  	depends on INTEL_MEI_VSC_HW
> -	depends on INTEL_MEI
>  	help
>  	  Intel MEI over SPI driver for Intel visual sensing controller
>  	  (IVSC) device embedded in IA platform. It supports camera sharing @@
> -88,3 +84,5 @@ config INTEL_MEI_VSC  source
> "drivers/misc/mei/hdcp/Kconfig"
>  source "drivers/misc/mei/pxp/Kconfig"
>  source "drivers/misc/mei/gsc_proxy/Kconfig"
> +
> +endif
> diff --git a/drivers/misc/mei/gsc_proxy/Kconfig
> b/drivers/misc/mei/gsc_proxy/Kconfig
> index 5f68d9f3d691..ac78b9d1eccd 100644
> --- a/drivers/misc/mei/gsc_proxy/Kconfig
> +++ b/drivers/misc/mei/gsc_proxy/Kconfig
> @@ -3,7 +3,7 @@
>  #
>  config INTEL_MEI_GSC_PROXY
>  	tristate "Intel GSC Proxy services of ME Interface"
> -	select INTEL_MEI_ME
> +	depends on INTEL_MEI_ME
>  	depends on DRM_I915
>  	help
>           MEI Support for GSC Proxy Services on Intel platforms.
> diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfi=
g
> index 54e1c9526909..9be312ec798d 100644
> --- a/drivers/misc/mei/hdcp/Kconfig
> +++ b/drivers/misc/mei/hdcp/Kconfig
> @@ -3,7 +3,7 @@
>  #
>  config INTEL_MEI_HDCP
>  	tristate "Intel HDCP2.2 services of ME Interface"
> -	select INTEL_MEI_ME
> +	depends on INTEL_MEI_ME
>  	depends on DRM_I915
>  	help
>  	  MEI Support for HDCP2.2 Services on Intel platforms.
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig =
index
> 4029b96afc04..838eae556dd4 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -4,7 +4,7 @@
>  #
>  config INTEL_MEI_PXP
>  	tristate "Intel PXP services of ME Interface"
> -	select INTEL_MEI_ME
> +	depends on INTEL_MEI_ME
>  	depends on DRM_I915
>  	help
>  	  MEI Support for PXP Services on Intel platforms.
> --
> 2.39.2

Thanks
Wentong