Received-SPF: pass (google.com: domain of linux-kernel+bounces-622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20231215074619.173787-1-aravinda.prasad@intel.com>
In-Reply-To: <20231215074619.173787-1-aravinda.prasad@intel.com>
From: Yu Zhao <yuzhao@google.com>
Date: Fri, 15 Dec 2023 01:33:18 -0700
Message-ID: <CAOUHufZW8ZbNDnu3Cfc61oJ4FkXK+AbT90XpS5Ei++1_5mcFFQ@mail.gmail.com>
Subject: Re: mm/DAMON: Profiling enhancements for DAMON
To: Aravinda Prasad <aravinda.prasad@intel.com>
Cc: damon@lists.linux.dev, linux-mm@kvack.org, sj@kernel.org, 
	linux-kernel@vger.kernel.org, s2322819@ed.ac.uk, sandeep4.kumar@intel.com, 
	ying.huang@intel.com, dave.hansen@intel.com, dan.j.williams@intel.com, 
	sreenivas.subramoney@intel.com, antti.kervinen@intel.com, 
	alexander.kanevskiy@intel.com, Alan Nair <alan.nair@intel.com>, 
	Juergen Gross <jgross@suse.com>, Ryan Roberts <ryan.roberts@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 12:42=E2=80=AFAM Aravinda Prasad
<aravinda.prasad@intel.com> wrote:
...

> This patch proposes profiling different levels of the application=E2=80=
=99s
> page table tree to detect whether a region is accessed or not. This
> patch is based on the observation that, when the accessed bit for a
> page is set, the accessed bits at the higher levels of the page table
> tree (PMD/PUD/PGD) corresponding to the path of the page table walk
> are also set. Hence, it is efficient to  check the accessed bits at
> the higher levels of the page table tree to detect whether a region
> is accessed or not.

This patch can crash on Xen. See commit 4aaf269c768d("mm: introduce
arch_has_hw_nonleaf_pmd_young()")

MGLRU already does this in the correct way. See mm/vmscan.c.

This patch also can cause USER DATA CORRUPTION. See commit
c11d34fa139e ("mm/damon/ops-common: atomically test and clear young on
ptes and pmds").

The quality of your patch makes me very much doubt the quality of your
paper, especially your results on Google's kstaled and MGLRU in table
6.2.