Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6559128rdb; Fri, 15 Dec 2023 01:53:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVYvmcN0v1Qi9O6U9X307AtJjMnzrlOSRF5YUhJd5gDxxIGa+zUTL03uZghb0XPVI3gXgw X-Received: by 2002:a05:622a:10c:b0:425:9dcc:6f80 with SMTP id u12-20020a05622a010c00b004259dcc6f80mr17216086qtw.91.1702634021042; Fri, 15 Dec 2023 01:53:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702634021; cv=none; d=google.com; s=arc-20160816; b=G4TVcyBw+gBZb4SMYEONR7bggc1XeOwpo5Nhm+SqDE7hWuw8QYL3uEsxfcsCRrg4Li HLTI2GuXoGGuM8JEpvlK4lflvbi6pvUi5udSwwGyAGZY+Cjd5nOU6/FPYhRK4Trw40vQ Pf7rTz3wEHHSop/wad34gFVMJ2rJ1dF46kRF8jBeyhaltr/sSX3MHjXpRaAPrvxSuHEy I7ndRL9v7t41r/Oa0lHxNIuVgNo1TzLYs+VJMOmdUFwzse8F7puh4JZ/wZ+vrXi+U6T8 Obv74KQ55ezbq6XmZtfuKFmQ7+wBSsgfMwNsB9olvkzKzrrXoSLrarv9gP/jUYhvH9vU 810A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IpNMOaelJu1m+OhxDMKyjTfEg8jKBGFhtAqTcShaIjk=; fh=WSO8L1OIngBE0JjX70dXEie6DZHmzD7LqhlXuPhH7fw=; b=0cYUIV5Q9TNcvZhlKkF7EXlSeHIh4TDLMjRfhf8pQKr3a009hiXPG6uL+mDCeqNz3R 4C4i1ZJhZPK0rkjDPZSTvCWiJ9/XYDvceOsUyeID1LG3lwpWaUA1OYwiFosuqU2qJGQN T4/KZqootcU2FwUtWzXBfe8JFgTHIzqOjTz6gZdWT840cFWiZMRnEUTeykLk/ydxRUHf 3EqRRPTiSsrDc5CxhATIdSaMA4dMtzfMD2XUncKzFbFg7nC7NyOl3cIRv7cH7CK6Ydki x3XWKIXnwMoS3h6k/qT3t7BBamDG5VF7fS9QiAYp/D9qAbmH2miFFbR6ZTFTe0U/gdwU qzwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Tong0rwi; spf=pass (google.com: domain of linux-kernel+bounces-704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bb21-20020a05622a1b1500b0042550288bdfsi18597276qtb.29.2023.12.15.01.53.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 01:53:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Tong0rwi; spf=pass (google.com: domain of linux-kernel+bounces-704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B70E81C226D9 for ; Fri, 15 Dec 2023 09:53:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 469C618B1C; Fri, 15 Dec 2023 09:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Tong0rwi" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC15182A3; Fri, 15 Dec 2023 09:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IpNMOaelJu1m+OhxDMKyjTfEg8jKBGFhtAqTcShaIjk=; b=Tong0rwiixvKY5rAH76RgCywX6 nX7jU0Pk2KlDbWdbuarsRpeLYLb2pV0EWo0l9vEUsTwqeXpygWNrq/ihXAutMW09v0ErHAy+Ky/pv xP/lmJpkWqc+2D9a/FzhuMhZPOopJzYodfFRNZDPcT3Q53d/QS3QrBgWj1kNkD+Hz480=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rE4sf-0030SP-30; Fri, 15 Dec 2023 10:53:17 +0100 Date: Fri, 15 Dec 2023 10:53:17 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: Daniel Golle , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules Message-ID: References: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org> <20231214183123.0f0af377@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214183123.0f0af377@kernel.org> On Thu, Dec 14, 2023 at 06:31:23PM -0800, Jakub Kicinski wrote: > On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle wrote: > > Calling led_trigger_register() when attaching a PHY located on an SFP > > module potentially (and practically) leads into a deadlock. > > Fix this by not calling led_trigger_register() for PHYs localted on SFP > > modules as such modules actually never got any LEDs. > > Any suggestion of a Fixes tag? > Looks like the triggers were added a while back, are we only seeing it > now because we started exercising the code more? How about: Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") Andrew