Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6574848rdb; Fri, 15 Dec 2023 02:28:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7Xt6ps9SjW1v93DPL89ViQNBZaAxLs179JVIvGG5o45FdhxXHGdpZy6RPt2Knvj8mw3fa X-Received: by 2002:a17:902:6f16:b0:1d3:66ba:454d with SMTP id w22-20020a1709026f1600b001d366ba454dmr2599448plk.4.1702636098353; Fri, 15 Dec 2023 02:28:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702636098; cv=none; d=google.com; s=arc-20160816; b=AbNORIaLM9ZWwN8ZVfOiDjq9sMTReXcPP6dIdHfXWGeV1nzdshfVSWyv+KhETFOE5F t2V6PtYheBR+wJjcpJC4ub1As4xDnoMUeeegsynkKRYZ94V+LqzDeR0x00RWR7X1gooW 7io798rhxmk1bQqdaKEyxyxzZTiGXSt7z8zWFSINU2HFRaRJ8RVvOsdmpPI+Hq9zEGzA lZdZfizOQEVGR6qe/56z4vNwe+teekJfMeulStaxqXnfMXkDt1xBizh7EwACxK1Y2O3h 1WI/2cUX4t2zg8ewXIzj1SZXkBIe3dBN7M4jtBaWU434iFvmDtUnlIpheM9Xb1ynaVhD 968g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=yFkrN1vK3BylaBocXztGHMiijGax/EL/4gaHlS2BTvM=; fh=VnwSVWWzup1cnXPhVsjR9uOp2Lz3NMr8hzFQwFGvBqs=; b=Fewp58qu+Bilnj+/ad5eJJMGbM/JUN5+t0Io7hJwXWrO6TWMtOLriDpG6DDnyCOfRt l4AUSiNob6+1IWjaVzSnWg45iU+6HXQ0GOSFBv9ygwpHDS3ZyjFhtFXt9bl+juOAG03z zSF7AQgXc/D8ka9EtBn48PI6lyOPUV30BQqYzJOQ8bwb2efUO15A327yY6q2Rm/JzxSJ YLibE+lMXDFz7lvPUgL8qdlqVMrxXAk1zMfQ1wSDuBMIrL4XdTvrOQ9zj4JIjgRgfygz FlXw2Nu+wz1VM8M0F18+eTa0SdAJHqGVPiXy7Ut9JJyhEmWWaOHlul1OArtdN2NPvwmt cEug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=4A4ht8jm; spf=pass (google.com: domain of linux-kernel+bounces-751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h13-20020a170902f54d00b001d331f3e1e0si6668193plf.555.2023.12.15.02.28.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 02:28:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=4A4ht8jm; spf=pass (google.com: domain of linux-kernel+bounces-751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E7D4F281A0B for ; Fri, 15 Dec 2023 10:28:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0241199D5; Fri, 15 Dec 2023 10:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4A4ht8jm" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4E91945E for ; Fri, 15 Dec 2023 10:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-4b2cdf382d9so156449e0c.0 for ; Fri, 15 Dec 2023 02:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702636087; x=1703240887; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yFkrN1vK3BylaBocXztGHMiijGax/EL/4gaHlS2BTvM=; b=4A4ht8jme8JDkdqLMhO+eAuWQPted3jVl0gh2bPWcADF3jlNsGJ+uEZEzuPXfVvnk1 OsKgQdwRr9Syv9yYInmliQDGz7ibeB3CIWBN7PiIZVeBs3kR0HrABwfF9SwMLzTVsZ6h O5rKsHz4rEyin4B1Xbzq8P/Ik9+o4Reh2W5d1E0xPtB645KWAmfImiLFwMuWVEgW3hy/ YIZhrPkm3uFPG+8gFlqVmbH3mKv2+ILG1yaao3kQ3zWxKeqmuiYD6QrAnK4uHQMEe3L6 dqFWRHuPIeZ6tDgfcdMXGGfz/rg+e4cLjXBuWfNjHQhpeEwG1fTFzfJNVagaHrjmwKs6 MzOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702636087; x=1703240887; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yFkrN1vK3BylaBocXztGHMiijGax/EL/4gaHlS2BTvM=; b=vtX1aGjj6yDd2EP+9RqDgshbAMmA4nvC+tNhER42Q0iO9rH/BUKUwNuyapbkVIXPhQ CXqFNX2VqM7OOiT60gId3MtRJGHhrt3APMsgTpw8xKdmt6j27ywVw9wgtbhT0goF+icv IittOVuoSGiaV7n3F8NZ/alSMnehCz4PCV6k636I8hB9OebRWz+TrSEjtNcM97N2FJwn gFGr3M7kK35WhSsshhQUHyLN1vEoNhtYQpgudQHklbje2exS8tKOAFuqUzfXTT19in6E bTwyvSBdHsKaGZRhfhKdn51Y51NlPsD92gBQ9dy/Mg2k7U7eydAjyhn7AOXCuUMA+vIC 1FVA== X-Gm-Message-State: AOJu0Yz09v8XRn6txPX/E6jvSN7faCbsh3UvKeP95HJfoJzrtuUI0Xjb odJqabWYOSka9TrDwy2MKEOsKSpp40Q8qnmBa+PXyu/vXVOE5I9hmO9Ipg== X-Received: by 2002:a05:6122:448d:b0:4b2:df58:7de1 with SMTP id cz13-20020a056122448d00b004b2df587de1mr9223620vkb.23.1702636087417; Fri, 15 Dec 2023 02:28:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231214200421.690629-1-boqun.feng@gmail.com> In-Reply-To: <20231214200421.690629-1-boqun.feng@gmail.com> From: Alice Ryhl Date: Fri, 15 Dec 2023 11:27:56 +0100 Message-ID: Subject: Re: [PATCH] rust: sync: Makes `CondVar::wait()` an uninterruptible wait To: Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Tiago Lam , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Martin Rodriguez Reboredo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Dec 14, 2023 at 9:04=E2=80=AFPM Boqun Feng w= rote: > > Currently, `CondVar::wait()` is an interruptible wait, and this is > different than `wait_event()` in include/linux/wait.h (which is an > uninterruptible wait). To avoid confusion between different APIs on the > interruptible/uninterruptible, make `CondVar::wait()` an uninterruptible > wait same as `wait_event()`, also rename the old `wait()` to > `CondVar::wait_interruptible()`. > > Spotted-by: Tiago Lam > Signed-off-by: Boqun Feng The diff is a bit hard to read because you swapped the order of the functions, but LGTM. Reviewed-by: Alice Ryhl