Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6578575rdb; Fri, 15 Dec 2023 02:36:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTSiXa2V2TqU1chipTrqZkHz30Uz2hPMFwii5GnS2DDyH7fWXv4oYDj0q1lTBabY+V8cFw X-Received: by 2002:a17:907:b90:b0:a19:a19b:427c with SMTP id ey16-20020a1709070b9000b00a19a19b427cmr3245513ejc.231.1702636603738; Fri, 15 Dec 2023 02:36:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702636603; cv=none; d=google.com; s=arc-20160816; b=Z1G1cVa5xwwg5nOlx+w2HgdQCMWY0SFDYgkYVT8i2v1C8CZc5QrCqehF930or69OlV UChIZOGhSXCWhiSC+W8BQvfbBc1zkLXPcTwFcR1jRAI5GFaaWhTQnIJ1zZ7LL4RaOvhW Zy6zLpi41irvUXlH8w2ck5hILQobv5dTao7hcqFiKqDq6YSKKUU6+Yt6mW0orDHuYo1M L3HvJvZ6j34MilNZsYZcpCqdjtftJuAxr5kUu1rq/Gzhw7Ht64fY2WWFM/yl5fKetezK /tenWoHFnZ8ppYzkcLyUYjCbQrQ6r0Bsj2f2Vbq4eoSLMZj6UhtG/D3rtPSI+Yvgu4FH yUYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=XM/h5D6gBvqTs8m/c7l58VuMUUS/k6RzHzb8GrlZLN8=; fh=qRmEcxGMdNKiopvwtkFmQo3qWFB54a6NpQZMFZePCgI=; b=jrGaWM5CYwv5oih4YkiZpo3af/SM+vMmP61o8t4C/KVN9wOS/Lg+UDmEOoG7lu48B1 evk+Ynzg5w/1Bwy5Ivuz2pxzK2C5Uj2gdYvZ9b/BacgG0DkuR6tSATOcTq2hSEhAZ0UB wfT3Yj56H2nT5VjoO2ukYuQ/OQTWQyS0WusbLXsuYN9a7n/mbeOaNO6UKm+gi5L7rldJ GAPnavdxfPFItw6tkPiByZ3P6VrbjzbuP5cjTNwTe+V3vTj92J24975ik+aaoRHqz7ao F8cstMIhiEYvGGfGqdS59Djabn84v9UdSZKwaXb8lZWM1NnoHm7mq+TyuwoKZDPUxz0P kIHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EYTocbUf; spf=pass (google.com: domain of linux-kernel+bounces-769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ca7-20020a170906a3c700b00a1d156e9ffasi7284995ejb.491.2023.12.15.02.36.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 02:36:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EYTocbUf; spf=pass (google.com: domain of linux-kernel+bounces-769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2519D1F23EFB for ; Fri, 15 Dec 2023 10:36:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 747241A706; Fri, 15 Dec 2023 10:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EYTocbUf" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3383119BA8 for ; Fri, 15 Dec 2023 10:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a1f5cb80a91so66451466b.3 for ; Fri, 15 Dec 2023 02:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702636589; x=1703241389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XM/h5D6gBvqTs8m/c7l58VuMUUS/k6RzHzb8GrlZLN8=; b=EYTocbUf0SBlMNBZWRRjwqE/jZcyZxHVHhyAynZUWODD+YlGRbieHA81Fv8XNmTyqc 3AYXUzAgNzwLM9VBCuZWnVPcGzDMEK3FED+CM3chRWSglIfUc08B+QiOniZiQ3s2xF5m B0sgN2MsZCXe2UVW/iw3sFNOF9uKbJmPr1YGe07zE+/VBr0wwTq7FL4Ho+L3MU3HdGr4 q+k5avqyHq6emiURKkgDo1avxjteH6BaDW7CzQe9rIUJTwJcEzl8El8tU8vbC4TsIE7e 3giIJU+3mmiwxKbBMhvmy58Cx9dMf1XglQcWR8xDqoSblgRx7baPp7WcWr9bBKLUpan3 vhYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702636589; x=1703241389; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XM/h5D6gBvqTs8m/c7l58VuMUUS/k6RzHzb8GrlZLN8=; b=WGx88+k64lhY4VGjttgHmCkZrtRZP7jJId6zx5+KZzm+SvDbMwjM7sdZqO10QenlKx bb2esyEF18jFcNraKziAKc3FxD1ttCgdDgMzyQV54m6g0C/mz5xal/SzW4+/i+Mh6GAt wv0YW/j7GdPMHn64u3mxkJ/dneiqVxLgXT9pROhu9j9Detq38TaZcXq9bTNaU6rGySHi LcvpmVCN6tOcI7okwJ3WlFZITPw8hV5pddxFJXt28+0Xrpus+x6vk6p+kD8oG/pf/v35 mBM6EmINqc0r6AcCvxDhJyx7zGs1Bsi8AhIlDIZ6XQr3qFpUKxC5d73v07MSTyZjNMba OxJQ== X-Gm-Message-State: AOJu0YxGGj/CEqSwae3EN/jWUnHUYkknS2EWCMgRUKIlfh1kbC0Pduxk W5zoB2v1KcE3lkMtw2hSk5F1vg== X-Received: by 2002:a17:907:7f94:b0:9e5:ee70:5da1 with SMTP id qk20-20020a1709077f9400b009e5ee705da1mr4229160ejc.53.1702636588816; Fri, 15 Dec 2023 02:36:28 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id tj7-20020a170907c24700b00a1c522990ccsm10584022ejc.85.2023.12.15.02.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 02:36:28 -0800 (PST) Message-ID: Date: Fri, 15 Dec 2023 11:36:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: sprd: Add support for Unisoc's UMS9620 Content-Language: en-US To: Chunyan Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones Cc: devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Baolin Wang , Orson Zhai , Chunyan Zhang , LKML References: <20231215085630.984892-1-chunyan.zhang@unisoc.com> <20231215085630.984892-5-chunyan.zhang@unisoc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231215085630.984892-5-chunyan.zhang@unisoc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/12/2023 09:56, Chunyan Zhang wrote: > Add basic support for Unisoc's UMS9620, with this patch, > the board ums9620-2h10 can run into console. > ... > + > + soc: soc { Are you sure you do not have here W=1 warnings? > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + gic: interrupt-controller@12000000 { > + compatible = "arm,gic-v3"; > + reg = <0x0 0x12000000 0 0x20000>, /* GICD */ > + <0x0 0x12040000 0 0x100000>; /* GICR */ > + #interrupt-cells = <3>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; Put ranges after reg, if they are needed. Are they needed, BTW? > + redistributor-stride = <0x0 0x20000>; /* 128KB stride */ > + #redistributor-regions = <1>; > + interrupt-controller; > + interrupts = ; > + }; > + > + apb@20200000 { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0x20200000 0x100000>; ranges is after reg, which is after compatible, so here it is the second property. > + > + uart0: serial@0 { > + compatible = "sprd,ums9620-uart", > + "sprd,sc9836-uart"; > + reg = <0 0x100>; > + interrupts = ; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart1: serial@10000 { > + compatible = "sprd,ums9620-uart", > + "sprd,sc9836-uart"; > + reg = <0x10000 0x100>; > + interrupts = ; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + }; > + }; Best regards, Krzysztof