Received-SPF: pass (google.com: domain of linux-kernel+bounces-821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <202312151817+0800-wangjinchao@xfusion.com>
In-Reply-To: <202312151817+0800-wangjinchao@xfusion.com>
From: Amir Goldstein <amir73il@gmail.com>
Date: Fri, 15 Dec 2023 13:16:49 +0200
Message-ID: <CAOQ4uxhoYTtnwKX0k3GwORWzJaYAJwpxu9B-ONu5Y0gdkavo8g@mail.gmail.com>
Subject: Re: [PATCH] fs: remove duplicated including of posix_acl.h
To: Wang Jinchao <wangjinchao@xfusion.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, stone.xulei@xfusion.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 12:17=E2=80=AFPM Wang Jinchao <wangjinchao@xfusion.=
com> wrote:
>
> remove the second including of linux/posix_acl.h
>
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
>  fs/overlayfs/inode.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index c63b31a460be..2003425875d9 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -14,7 +14,6 @@
>  #include <linux/fileattr.h>
>  #include <linux/security.h>
>  #include <linux/namei.h>
> -#include <linux/posix_acl.h>
>  #include <linux/posix_acl_xattr.h>
>  #include "overlayfs.h"
>

Since both posix_acl.h and posix_acl_xattr.h are included by overlayfs.h
I would rather remove them both including the first posix_acl.h include.

It is far from being the only duplicate include in "overlayfs.h" and it is =
not
important enough IMO to start a cleanup project, but if you are going to
tidy up includes for a particular file, I'd rather use the opportunity to
cleanup that duplicity as well.

Thanks,
Amir.