Received-SPF: pass (google.com: domain of linux-kernel+bounces-895-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f16dfe78-2e31-45fb-b2fe-f72b7e6c51a5@quicinc.com>
Date: Fri, 15 Dec 2023 20:03:23 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332
 platform
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <robert.marko@sartura.hr>
CC: <linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_srichara@quicinc.com>
References: <20231214090304.16884-1-quic_luoj@quicinc.com>
 <20231214090304.16884-6-quic_luoj@quicinc.com>
 <1e4c55c8-8ed6-4f2e-8328-8a173f09b62f@linaro.org>
 <3c8e33b4-6ebc-476f-a00f-15cc8a1ad9e4@quicinc.com>
 <b89abf8c-57f8-46a6-a071-b1591340fbdf@linaro.org>
 <3de98516-9a28-4f58-8951-2a7752621fee@quicinc.com>
 <1fa2d219-63d7-45cf-9e05-b85dbce24076@linaro.org>
From: Jie Luo <quic_luoj@quicinc.com>
In-Reply-To: <1fa2d219-63d7-45cf-9e05-b85dbce24076@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 12/15/2023 6:21 PM, Krzysztof Kozlowski wrote:
> On 15/12/2023 11:03, Jie Luo wrote:
>>>>>> +  cmn-reference-clock:
>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>>
>>>>> Nothing improved here
>>>>
>>>> With this change, the warning is not reported when i run
>>>> dt_binding_check, looks the new added property needs
>>>> the type ref to avoid the warning reported.
>>>
>>> Nothing improved in the property name, nor its style, nor in the actual
>>> contents/values.
>>
>> This property is for CMN PLL block reference clock configuration,
>> so i use this property name.
>>
>> it will be appreciated if you can suggest a suitable name, thanks.
> 
> See example-schema about naming. Read writing-bindings. You need vendor
> prefix for custom properties.

Ok, thanks.

> 
>>
>>>
>>> ...
>>>
>>>>>> +  reset-gpios:
>>>>>> +    maxItems: 1
>>>>>> +
>>>>>> +  reset-assert-us:
>>>>>> +    maxItems: 1
>>>>>
>>>>> This does not look related to ipq5332.
>>>>
>>>> The reset gpio properties are needed on ipq5332, since qca8084 phy is
>>>> connected, which uses the MDIO bus level gpio reset.
>>>
>>> I am talking about this property, not these properties.
>>
>> ok.
>>
>>>
>>>>
>>>> Without declaring these gpio properties, the warning will be reported
>>>> by dt_binding_check.
>>>
>>> How is it even possible to have warnings if there is no such node in
>>> DTS? We do not care about warnings in your downstream code.
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> If i do not declare the property "reset-assert-us" and
>> "reset-deassert-us", the warning will be reported by "make
>> dt_binding_check" since i
>> add a example in this file.
> 
> This argument does not make sense, sorry. Obviously if property is not
> allowed, it should be removed.
> 
> Provide rationale, in terms of hardware, why this property must be added
> and why it cannot be deduced from the compatible.
> 
> Best regards,
> Krzysztof
> 

So i can remove "reset-assert-us" and "reset-deassert-us" from the added
example to avoid the dt check warning? even these two properties are
needed to be defined in the device tree to make this driver working
correctly.