Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6662215rdb; Fri, 15 Dec 2023 05:13:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXe9V+KPgTMeL2BlAdbDQQX1hcGIVhFLM5leDZ8ILGctgQl7qTUM3V6SKoJYk7Kgyt4rGZ X-Received: by 2002:a05:600c:314e:b0:40c:6aa2:c540 with SMTP id h14-20020a05600c314e00b0040c6aa2c540mr533373wmo.22.1702646032511; Fri, 15 Dec 2023 05:13:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702646032; cv=none; d=google.com; s=arc-20160816; b=ScvtaRReApPzredVCovwrDyzxrPfLOfAQzsWxLOdLwfAgVi2jrjC4l7rw9CIVf1GfV ociBbGFSCr6RlJrbJAZXf5n2KXZ13dO5vOpBSpSaKUVJqudwIqE2vd/br8Ds9pCwwHAO za4ilqlqSm84PRR+nYvZBxjYb81iXmP1MYKqVAxcLAEfeoGle3OZTiFwqHPHccZXBHvX t48+KufRDZ5by1+t0/en3q5jIGZnkvoW/tjcj5NOYdFyYgGs4MshRI5QllKbLpcnEdPn A/8o6x1F+QPpqx82K+KWv7BfsmvZmteRbHyXJwJB2HBCvp7koXVxS+5BciqONJKAZfal 1EjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=wrjeBXri5f/F73QANF64tGhcKg/5a/1Lu2flZkfZfgk=; fh=/yKR9sOv0TytjfRml5cCASV8S4X6bBh20SSVoLVU9CM=; b=eCgKUEoPetIw7MpMgfN7HmoIK+cGlASP0TBzKNAICKXI0x+VJ1XlEBo18g8+yYt+FT PPZ3tykSWJ+9KBW2UCMeZCjbR3dWgI99El1Y84CyqPXmleaUxoqEUuONw3mKCbV81ThX cLsl+91IdPwSFYz4Huh5/9T7N5GvbPtkUNkN5OcyqE2N6ydy9L/KVvzwmFBkv86qNS/3 08zttScU9JN4pJwRVjCgpSlMbcaf7Icq3zqJTHqsjE71g83eMGMnNps3iPx2SwGZjqOn 2EOwzytRK7oo2ubtYzRnjkrMbQiTOgw8gJTsHmBXzLpFqAhf0GH/487AUEXZ8+wxPGGY uG7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q9hDPZOD; spf=pass (google.com: domain of linux-kernel+bounces-978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-978-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id jp7-20020a170906f74700b00a1c936d33aasi7359744ejb.235.2023.12.15.05.13.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 05:13:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q9hDPZOD; spf=pass (google.com: domain of linux-kernel+bounces-978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-978-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 481A41F24986 for ; Fri, 15 Dec 2023 13:13:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 604D72E414; Fri, 15 Dec 2023 13:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q9hDPZOD" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A4EF2DF98 for ; Fri, 15 Dec 2023 13:13:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA9AC433C8; Fri, 15 Dec 2023 13:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702645993; bh=95CxUUbPl1kIpQU5C4sC9NMgOhe+jHAIEUlCPWtuLMY=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=q9hDPZOD0ZG7crnWA7ninOmRAjnXcZET6FUJyxW2/SK6lwe/+Oz+CbM3q9KXr6auW TwSRowOnABbwoDeYttl6dbRlIYY+hAsZowOE+c/c4wpKH6GH4nmXg2jqSkt+LuAAMW GX7kKthJszfrj6vA/W5XXy5mNW/a8vOmHs0p7Mr9FLVUkaSp8rGrPWmZfgn2Y2qnvD NGd+NQ7C0vCBFPQCuRKSJrUUW0Ufxm0TJ0Zcbh5HfucwqppRBmvvAffl54Nz7WXnyY v+DgaxLVrmGvqlJA4ikDG3VhkF0YILu9iZcComapnwsQ/uHyPgMIyGjfZC9S4lpfR9 fpzdOooXjG5YQ== From: Maxime Ripard To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Donald Robson Cc: frank.binns@imgtec.com, matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, Dan Carpenter In-Reply-To: <20231213144431.94956-2-donald.robson@imgtec.com> References: <20231213144431.94956-1-donald.robson@imgtec.com> <20231213144431.94956-2-donald.robson@imgtec.com> Subject: Re: (subset) [PATCH 2/2] drm/imagination: Fix error path in pvr_vm_create_context Message-Id: <170264599089.449619.14263811622575523526.b4-ty@kernel.org> Date: Fri, 15 Dec 2023 14:13:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 On Wed, 13 Dec 2023 14:44:31 +0000, Donald Robson wrote: > It is possible to double free the vm_ctx->mmu_ctx object in this > function. > >     630 err_page_table_destroy: > --> 631         pvr_mmu_context_destroy(vm_ctx->mmu_ctx); > > The pvr_vm_context_put() function does: > > [...] Applied to drm/drm-misc (drm-misc-next-fixes). Thanks! Maxime