Received-SPF: pass (google.com: domain of linux-kernel+bounces-1089-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 15 Dec 2023 15:12:54 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Zijun Hu <quic_zijuhu@quicinc.com>
Cc: jirislaby@kernel.org, quic_qiancai@quicinc.com,
	quic_arandive@quicinc.com, quic_saipraka@quicinc.com,
	quic_vnivarth@quicinc.com, quic_eberman@quicinc.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: Add comments for tty-ldisc module loading logic
Message-ID: <2023121523-cadillac-prologue-a81d@gregkh>
References: <1702640236-22824-1-git-send-email-quic_zijuhu@quicinc.com>
 <1702647690-6787-1-git-send-email-quic_zijuhu@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1702647690-6787-1-git-send-email-quic_zijuhu@quicinc.com>

On Fri, Dec 15, 2023 at 09:41:30PM +0800, Zijun Hu wrote:
> Current tty-ldisc module loading logic within tty_ldisc_get()
> is prone to mislead beginner that the module is able to be loaded
> by a user without capability CAP_SYS_MODULE, add comments to make
> the logic easy to undertand.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> Changes in v2:
> - Remove condition checking changes

As I asked for before, please get other, more experienced developers,
from your company, to review and sign-off on this patch before sending
it out again.  I can't take this as-is, sorry.

greg k-h