Received-SPF: pass (google.com: domain of linux-kernel+bounces-1121-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 15 Dec 2023 16:40:36 +0200
From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: yang.guang5@zte.com.cn
Cc: davem@davemloft.net, jiang.xuexin@zte.com.cn, chen.haonan2@zte.com.cn, 
	cgel.zte@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, 
	sd@queasysnail.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] mlxsw: spectrum: use netif_is_macsec()
 instead of open code
Message-ID: <zkadwo3imhhatvmkhuvxnoql4qmrgpkz77mugifckredfv5hxo@pbjp3ffoxvba>
References: <202312152145312776210@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202312152145312776210@zte.com.cn>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7LWWK8FvodzncHzctR2ql3Jx7dK8KMSb4LHP4MzV3T3/a8Ggq3Ri4ZBaw0Ku?=
 =?us-ascii?Q?Dn7AdaHFgwzRPoUQkS8uzMYq7cJhfVt3TvLJPZfax43t7CWeMJPtxeisiklm?=
 =?us-ascii?Q?pwJzIwDfxP4hUmAuwERmY9fHrzPbxKo1TghC4/e8XxPDhAUMa+4msLXytixT?=
 =?us-ascii?Q?9Ha0bzIH7Dl/f7/Wbqnp+CoxQp8QpWCJb73K3qjKqbAP0oUh8KpCW0zUqPv4?=
 =?us-ascii?Q?dO4B+y+aG4mLf1Cr7zY/WgNOOT5OBNM4YY7Kv3U+aA2TbJexQ4grJK88E0mn?=
 =?us-ascii?Q?x29WXVba05I3wqN2Hi/u7l0PEgFNyaGXI37olsgFBi5uVUt6xoCnPulAJwhd?=
 =?us-ascii?Q?BR4qn+v3Oq8Np/0z8ww3T9lEMTWhuOryX8vaBoZGnpSHSQZAV7vBsNCqkOIf?=
 =?us-ascii?Q?bacrk+qs/w32i4/vNeT47j18Qh9Z2QiYQ9faFs6j2ZpzwC+EMW0Ex0p8pptJ?=
 =?us-ascii?Q?S3OW6RVXBaEEydIpYtFoz6V2yHDcOP60ont+ppv6TTsHJyWES0LFggkTZeFi?=
 =?us-ascii?Q?QecmYozc1/jUOLVeyKMMIh5b+c3aGHxwP95OzTLenEGo8wMM7ti1v/cogDYs?=
 =?us-ascii?Q?EW97EbucYPNxIIMP1/LiBCw9vupb/jBHWtweqbwAUxHjg9CX9zIWIS9GwsW6?=
 =?us-ascii?Q?XBU3qpGOCAg9yDSYUve0euai/5BQxTidXT9xslrfMyB3N2Knfk7sc2Om2KGo?=
 =?us-ascii?Q?b32TgCPadp1CuJZfWuZTWqCrr7nuarlq396PEYuAlXAmuedUorEzevwxR/ij?=
 =?us-ascii?Q?rDoQBZPfiQvmzkSnWDlU2+SL0BYO9Ng/S8q4yLPXSRFFtYglBRRH43k79JZ6?=
 =?us-ascii?Q?9kSlv0frlJOnvdiGn05hcx7LdbH2cGyZNqii9VH7wu71b/mM6nBIS0YiZQFh?=
 =?us-ascii?Q?xd3m7ck+a8YFW89OgTJ4I7cJ5cEldTul5LlL3Eb7FTUKFLZTmEEoKFvA5WVH?=
 =?us-ascii?Q?c69aUGgbm7XZh2gRoRXC/CD7mMwZUI+QKjp8OMhUlRPraIj1ok2zFcJbInuT?=
 =?us-ascii?Q?n+7o2rQyTTfCAqFsvblm8tetE2wOiDFTMKsYpziVO+vInXOn1HCRk5K0Wnuj?=
 =?us-ascii?Q?rEQVHqWvw0RRF3aGfZEZuruMcwM8zhqGB+U+xdjDCZLeMNRwXQ5CV/aCXn5O?=
 =?us-ascii?Q?T0QrXgp8qaRqOOvjgAigqyD/4ra89x9Y28MDkXBCD1UKzCkSO1KL6LLcnQTQ?=
 =?us-ascii?Q?m1HN7ZVklWxmFem1RwOXu1w8OpN5fYxL9g87ATZnALxQSP/vlWYaEmA3QTex?=
 =?us-ascii?Q?Pnw0x49Ni3Z5ycwvoAez+P+bpOGHCeYQfrsjLCnLS6IEIZp/V4l7kseC3ujn?=
 =?us-ascii?Q?LFHgxyxKQBMW9KelH6XxmK+SO0Q7Q3SJAesb/oy4WTR29Xm/hyVazMwVQhnB?=
 =?us-ascii?Q?Mia+n7E4KSTUhl/vYQYFrGshGXGiZ0btvnbRdJmAkRJt6PWMRoDBKmZuohG2?=
 =?us-ascii?Q?omUZ7DMEKRXhI8wzVXm/+gJRqjN1bd9Ub+xHujDTNCDmdZtS4Fp+qUeSf3+e?=
 =?us-ascii?Q?VHbWnVn94xnyyfO5W+2whvSnua34cQI208hp4LRcLsaq0SWaWh4drbtB0V4b?=
 =?us-ascii?Q?vHJBQupEKrSiOfHRKK4Ues3chbKTm43zKOBdvtTF?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3b03bd-ce1c-4d6a-147e-08dbfd7bcef6
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9070.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 14:40:39.9292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xlPqqDLyo/JEuLjh+g7sjZjCA9aqSa1hZnzS9+clwc5eCDml5LjBRM1sjjmDNur9cJnHgsHNnlJuAvUvpDeMuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7361

On Fri, Dec 15, 2023 at 09:45:31PM +0800, yang.guang5@zte.com.cn wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
> 
> Open code which is dev->priv_flags & IFF_MACSEC has already defined as
> netif_is_macsec(). So use netif_is_macsec() instead of open code.
> No functional changed.
> 
> Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn>
> ---
>  include/linux/netdevice.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 1b935ee341b4..1f2b23d854c9 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -5103,7 +5103,7 @@ void netif_inherit_tso_max(struct net_device *to,
> 
>  static inline bool netif_is_macsec(const struct net_device *dev)
>  {
> -	return dev->priv_flags & IFF_MACSEC;
> +	return netif_is_macsec(dev);
>  }

So you are replacing the actual implementation of the netif_is_macsec()
function with a call to the same netif_is_macsec().

How does this work?