Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6728413rdb; Fri, 15 Dec 2023 06:59:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEyJUmPW6zpeeLHmGu+8kQazYSgqWaNylujZaaFEuas3yf7iwKnFF+9RsXgD+ZY8trpGs1 X-Received: by 2002:a05:622a:1a93:b0:423:7060:3d5e with SMTP id s19-20020a05622a1a9300b0042370603d5emr16214814qtc.11.1702652346093; Fri, 15 Dec 2023 06:59:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702652346; cv=none; d=google.com; s=arc-20160816; b=MCSE37YUwV4Qtx7YRCHvB+N+0CbrGnDaVzGhF7j8T1w6fx/Ld7Ze7vPJcl7nlq/noR A4D6aIc/rX/M7R7EcL0ccmdS5Gb8fB7Awy4/g9tviX0rb5gXW0ly3cCNElSIle6TYS2x LAxlyAwPQ0t4xyhwAu4ft+lyj0XZxykXT7nlDcQuJonD6aMXioGHDEWxlKSqfFpPAHuN YPLKK1/X3umjwkl6Sl3p6cwCa7+i7UeLpl0pv1D6vrGHoHvfsXOFjfat/K7s3uh2KWym VnZnjrWPCD8csWCmldyJeBJLZXO7wiZ9FL30QRa1UhEz6zeRCfeIL+ulTuRGGNoD5X6k 9fcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=1jwi2TaNw/idM6KvASCJXOcLUllXiF0b2T6DLjX2GXs=; fh=sNWiO2H4bMLj6IfG+Ecf05becpX/0vcr2aW/I4iJBgk=; b=jAEi6Vu/o3nJGn3Vre5raahKZt/qPMK8ZOmW3jeaPYQKBj1h2Ck7UCfnYP3nMzynjL NPj6Pb3xCX4piOIWsQYxtbroO9Wtl4tiyygMAeE4m3nERve+b3xTXuD2pFq6+kpbjC0X H84Uhm5UhwlkVFavfKJn9HiNWD5XaLLmM8YL+8oIhnk3Fqkp42Q0ynBeo3p1BGAk/YAd /foX7ZTgK/3m130YLEuAJua6qp8nj1El2cQMuxMk6OKzAw3bvVOVT5iDbjk2rFWWdA8J HcfXGshy3jOTQq1z6oVa09xHDfzfmWKNUEbh4hJC8PoqZRqeUBU3z5KpbL82ODgklKdO Tdrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dFZawHbc; spf=pass (google.com: domain of linux-kernel+bounces-1141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1141-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x13-20020ac8538d000000b004237fecbf12si16727674qtp.109.2023.12.15.06.59.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:59:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dFZawHbc; spf=pass (google.com: domain of linux-kernel+bounces-1141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1141-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D44BF1C23973 for ; Fri, 15 Dec 2023 14:59:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 00EF3358B3; Fri, 15 Dec 2023 14:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="dFZawHbc" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B23B9364A4; Fri, 15 Dec 2023 14:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BFDwLHD014411; Fri, 15 Dec 2023 14:58:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=1jwi2TaNw/idM6KvASCJXOcLUllXiF0b2T6DLjX2GXs=; b=dF ZawHbc8lkkd+IaIBuCV3RvswsfFPO4VYY0JL6V/1MjixsFbV0Waadzt0t2T8iZIA BFoMNjun/gJA36p5r/ARWBeWMMci37E5b8FQZCts2wRtjC7/gbjNPt7EvggrYKio RtIJDyPvNgfsWvCR+dPokQ5vj1nAz/Poz5d5hQP+OPL3eZDczHWdW0YTefpaiC4f gG1sX2TrhoFSb4MZUB6EbbBA6pJ7coEqI3ncmaZigOWgDSr4kGjcinwBJcs66An+ ZdijJmS6C1MYN6+WntQpRYW9u5h9MJwFHYl268JVGYRHYZs0pPweUSN74TIuvslO oBWpgUzhCCxV34NAH04w== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v0a37jc7g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Dec 2023 14:58:52 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BFEwpR5032091 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Dec 2023 14:58:51 GMT Received: from [10.253.38.198] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 15 Dec 2023 06:58:48 -0800 Message-ID: Date: Fri, 15 Dec 2023 22:58:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] tty: Add comments for tty-ldisc module loading logic Content-Language: en-US To: Greg KH CC: , , , , , , , References: <1702640236-22824-1-git-send-email-quic_zijuhu@quicinc.com> <1702647690-6787-1-git-send-email-quic_zijuhu@quicinc.com> <2023121523-cadillac-prologue-a81d@gregkh> From: quic_zijuhu In-Reply-To: <2023121523-cadillac-prologue-a81d@gregkh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: SucUcQ_HXS0ojCxNosUzLJ2XMtSXV622 X-Proofpoint-ORIG-GUID: SucUcQ_HXS0ojCxNosUzLJ2XMtSXV622 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 adultscore=0 mlxlogscore=946 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312150103 On 12/15/2023 10:12 PM, Greg KH wrote: > On Fri, Dec 15, 2023 at 09:41:30PM +0800, Zijun Hu wrote: >> Current tty-ldisc module loading logic within tty_ldisc_get() >> is prone to mislead beginner that the module is able to be loaded >> by a user without capability CAP_SYS_MODULE, add comments to make >> the logic easy to undertand. >> >> Signed-off-by: Zijun Hu >> --- >> Changes in v2: >> - Remove condition checking changes > > As I asked for before, please get other, more experienced developers, > from your company, to review and sign-off on this patch before sending > it out again. I can't take this as-is, sorry. > okay > greg k-h