Received-SPF: pass (google.com: domain of linux-kernel+bounces-1176-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 15 Dec 2023 17:09:16 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Add Intel Meteor Point pin
 controller and GPIO support
Message-ID: <ZXxsHKdADb4mfH21@smile.fi.intel.com>
References: <20231214154653.1087747-1-andriy.shevchenko@linux.intel.com>
 <20231215064417.GV1074920@black.fi.intel.com>
 <ZXxl161aJ8vZyiPw@smile.fi.intel.com>
 <20231215145824.GY1074920@black.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215145824.GY1074920@black.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Dec 15, 2023 at 04:58:24PM +0200, Mika Westerberg wrote:
> On Fri, Dec 15, 2023 at 04:42:31PM +0200, Andy Shevchenko wrote:
> > On Fri, Dec 15, 2023 at 08:44:17AM +0200, Mika Westerberg wrote:
> > > On Thu, Dec 14, 2023 at 05:46:53PM +0200, Andy Shevchenko wrote:
> > > > This driver supports pinctrl/GPIO hardware found on Intel Meteor Point
> > > > (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces
> > > > including GPIO interrupts.
> > > 
> > > This is driver for Meteor Lake-S and related, correct? Why it cannot use
> > > pinctrl-meteorlake.c instead? Same way we do for other desktop CPUs
> > > whose PCHs have the GPIO/pinctrl block.
> > 
> > Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die)
> > pin control IP is serviced by pinctrl-meteorlake.c, here we need to have
> > a different file as we would have a name clash. Yes, it means that on
> > the end user platform it may be two pin control drivers!
> 
> I see, thanks for clarification! Then this makes sense.
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko