Received-SPF: pass (google.com: domain of linux-kernel+bounces-1223-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 15 Dec 2023 16:39:07 +0100
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>, Paolo Abeni
 <pabeni@redhat.com>, Daniel Golle <daniel@makrotopia.org>, Heiner Kallweit
 <hkallweit1@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules
Message-ID: <20231215163907.7dbd5769@device-28.home>
In-Reply-To: <20231215105928.74608001@device-28.home>
References: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org>
	<20231212153512.67a7a35b@device.home>
	<ec909d14-e571-4a50-926d-fbef4f4f9e0a@lunn.ch>
	<ZXnNYJer0JrJxOsl@shell.armlinux.org.uk>
	<ZXn_id6-XWYr2Seo@makrotopia.org>
	<6dd8d8b62d6db979d6c2197a4091ebc768e6610a.camel@redhat.com>
	<ZXsyt+msigtNiLN9@shell.armlinux.org.uk>
	<37a66b85-3980-4553-8447-d040404bbc11@lunn.ch>
	<20231215105928.74608001@device-28.home>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi all,

On Fri, 15 Dec 2023 10:59:28 +0100
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:

> Hi Andrew,
> 
> On Fri, 15 Dec 2023 10:46:18 +0100
> Andrew Lunn <andrew@lunn.ch> wrote:
> > So, if i'm reading this patch correctly, it only affects PHYs within
> > SFPs.
> > 
> > The discussion went off on a tangent and also talked about media
> > converter PHYs, but from my reading of this patch, they are unaffected
> > by this patch. Do they however also suffer from this deadlock? Anybody
> > tested that?  
> 

I gave it a try with lockdep on a macchiatobin, but I couldn't even
reproduce the original issue (tested with the tip of net-next and net),
so I can't tell if the media-converter PHYs are affected as well. I got
no lockdep warnings regarding either paths.

Maxime