Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6789610rdb; Fri, 15 Dec 2023 08:20:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNlVoer2iD9QFIXWmLrpf5832YsHr1dhOJ4ir+r0R9xrLvuWsIk3VSAU7nY1hEDmr+jO/W X-Received: by 2002:a17:907:9150:b0:a19:a19b:55e9 with SMTP id l16-20020a170907915000b00a19a19b55e9mr4871294ejs.121.1702657230923; Fri, 15 Dec 2023 08:20:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702657230; cv=none; d=google.com; s=arc-20160816; b=dXiGr0bCL0sSN4hJp37F3U+EadCyMUqvKkz7cV/WQQL52IvTWw9QKDR/ZciBL/hB2w b1wxgikSKhIEGh4rG7Dkxj/Qckcv3phFTXEQ/UizgRRud8smbSpgz5QRGpleLfxv3hbK 5X+x5nnSMKZYAQ8RXUaM5EWj34fNeJorMbsaWIfw4jP9EH3c6TNUHSJ4nPIeEql/cO4J F3/qsaVFLdYxaCJKqY9lSw5s3xoIU2yml5CUw1xhJG34/9YKCKDuEU9ltdYjzSn45irA lT1LK8KwV7HA0KXTjPHlLzO+CNHsFiaf2B2hMyIgMoAWZfTu0TG9Y1+aHinAnQAnsBbU eunw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=I97n5IlePfC+B8aIdGE/BXn1GjJxLjOihJFqqGWbuww=; fh=tzIevuNZlW2e6Y509fBFfqFot3CdZOGXgOAjSwl9cdM=; b=z+MrF2a1+L5pQY5Zle6CFM79s5ap/C6eXO3SqGTt0w0rRn+boVMyJQ1cEziXj7aRog buCj4APgpHF/Uk+zbAmKn6Uj8/MIq7MPrX7dqfLOhQWdh9OlftC6XIaF4yP0mXoBmVO8 1tAPBP/F0HGhZgknmh20J3S21YPWHsvCHyaAYLrFK6pIlBl9Rwiz+ZiDOW13veY878Pu +hblW/UF6r8d/WEO82z9IF1d3sekNP6wmaXM5xdlD6/acgH56LCWtCi0VNEKHPgWMF2h rjdi5vEr6qljwUBYuAmAq3m1MMyNrVRiWnZu1Ieqs86MRNGbVIN6AgrAEmuSRYuaS+g9 /5GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eZdGiigm; spf=pass (google.com: domain of linux-kernel+bounces-1282-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m26-20020a1709066d1a00b00a1ceb9430c4si7173893ejr.367.2023.12.15.08.20.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 08:20:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1282-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eZdGiigm; spf=pass (google.com: domain of linux-kernel+bounces-1282-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ABC0E1F25253 for ; Fri, 15 Dec 2023 16:20:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E3CA23DB88; Fri, 15 Dec 2023 16:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eZdGiigm" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 273153DB81 for ; Fri, 15 Dec 2023 16:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B6BFC433C8; Fri, 15 Dec 2023 16:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702657223; bh=Cukggf5RuYjVp8uLz9Wr3r+uW+U+//IFSZh8tKw2rfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eZdGiigm9hf8PGZmgjujy6TgqZShWc7sm9yEQ3b0Rz074zkJ4wsqA+iulU6FMlJjg Nlayqgjgv/BzyS0xsJnfUFAspGZLMmZoVxVH+WRoCamW4YQtXw+HZRQKKvZpUXMmqr 7Rg4kssuffZvRvZsFv76vVY3BLwPvfsusjZYhBqs= Date: Fri, 15 Dec 2023 17:20:21 +0100 From: Greg KH To: Ayush Singh Cc: greybus-dev@lists.linaro.org, johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org, jkridner@beagleboard.org, nm@ti.com, yujie.liu@intel.com Subject: Re: [PATCH V2 1/1] greybus: gb-beagleplay: Remove use of pad bytes Message-ID: <2023121559-overfed-kisser-3923@gregkh> References: <20231211065420.213664-1-ayushdevel1325@gmail.com> <20231211065420.213664-2-ayushdevel1325@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211065420.213664-2-ayushdevel1325@gmail.com> On Mon, Dec 11, 2023 at 12:24:18PM +0530, Ayush Singh wrote: > Make gb-beagleplay greybus spec compliant by moving cport information to > transport layer instead of using `header->pad` bytes. > > Greybus HDLC frame now has the following payload: > 1. le16 cport > 2. gb_operation_msg_hdr msg_header > 3. u8 *msg_payload > > Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver") > Signed-off-by: Ayush Singh > --- > drivers/greybus/gb-beagleplay.c | 55 ++++++++++++++++++++++++--------- > 1 file changed, 41 insertions(+), 14 deletions(-) This doesn't apply against my char-misc-next branch at all, what did you generate it against? thanks, greg k-h