Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6805218rdb; Fri, 15 Dec 2023 08:45:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFVPZMXe2xnHUZPrZDp/Yr54e+SjzFVRpYXXp9lOZlTSIHreMEuRefRygdzsA/9ZEFyWmd X-Received: by 2002:a17:906:535e:b0:a1f:652e:d7c5 with SMTP id j30-20020a170906535e00b00a1f652ed7c5mr5445793ejo.111.1702658709291; Fri, 15 Dec 2023 08:45:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702658709; cv=none; d=google.com; s=arc-20160816; b=lOJr7A2E382c2JauuxCWoFlLII2Q8LMfyIu9xfRIWbGoFC0U3moZ7JCR/EWvAfe30+ Do/c1mTck7+Tuo9wld87vSA18FAp8UqDKqC1dALuJLzKicWKAP+T+DatOx9ia+0MZRqg cNhgCAaMZQ861AQV25BKKkD+D7Mq/oVzvNfsqGrftYYd7/kssbhkckhDOf18NlcukIhr PlfR1i/CJJnw5ONorXMhRF1Hs3QG+QbYcQNmrAq1Rps2Zwnz/OI9WtxIk8ZpugKAjl8h lVBlN4j9CToSxNganKobhYBsEQtxFab3qSuXalZufc1/EdxsbcXCev+3J3fJK7DxmJmo 4SeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=eFXKzuKWgD3LUiLYRzicQgixcKU/IYPgsPEtPEy1EKc=; fh=bEUUkxCtcWAoM+0QUmhtNDixjAfHmPTjnsrsFCDjYhU=; b=GUUjQthjNDkUALxBCsPJkIWezrhPXyr8DFRI+6t1+pF/Ztty0AUznoqBMnGV4BneGm Te4zowA84dS185zFzxxonNy7eIwAvRV2di1vHj+w5r2vd1wSo+yTdvgafAOP1+Wc2jaz a+VZuYr9RLzbmSgnR50hCikfmCir5Tx3eFBGS+3plUL2owb4vzqGPFUtMv67GfB9U3IP VlmGr4EtvQNvKz0m9vKa/KNXupZdJF7mQBVSL+w3RdhYx8ZwnQTIg9+rdYDI7YQiYlom OKJYnzp5NiK8ma0J5gi0hwiJtltoyrob++FPrDld4rWiuOUEGfR7zutaH+QG53Io+Lah SQsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="XIXpbTO/"; spf=pass (google.com: domain of linux-kernel+bounces-1320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1320-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p7-20020a17090628c700b00a23169c0d3fsi954871ejd.802.2023.12.15.08.45.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 08:45:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="XIXpbTO/"; spf=pass (google.com: domain of linux-kernel+bounces-1320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1320-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 10D7D1F2383F for ; Fri, 15 Dec 2023 16:45:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2F3E3EA64; Fri, 15 Dec 2023 16:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XIXpbTO/" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7762B3DB94; Fri, 15 Dec 2023 16:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702658686; bh=f+TCM7pGtaT/lQaRtao0Q8SkJwJVGAdBLHsGY6Pv5qU=; h=From:To:Cc:Subject:Date:From; b=XIXpbTO/l0VFnvYvsHNl//QYwLMgO5u4W/YAG6YNpFSQXbk4wfYRhPOLG6rSxIhYE rPG6pTfdxkV2clDrf4ByZQzmgBCZrWSjSMxRmmre/oegAbAWC89RuYbBCzN4nKZwgz uLA5++SiK19g91Serzhc4SgIYZMkT15B+K7juItNijlkL8c/nI/QXN8x/GyrjsjA5V q6r8CbN2+7oaQMvBydbijYvrxrpSFCb67JJGibwq9ZrSSe0ndAUWUEKorRGjEVCFlS u20zLmbvMOP0EuGrkyWm3LOCFCCYZFbpisS8Ucfl5zgNfMLBrz7Qa4ZG3GoizHbqxM btqrbS1cBUNYw== Received: from arisu.mtl.collabora.ca (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A662D3781F93; Fri, 15 Dec 2023 16:44:45 +0000 (UTC) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, Daniel Almeida , Mauro Carvalho Chehab , Hans Verkuil , Detlev Casanova Subject: [PATCH v4 0/4] visl: Add a tpg_verbose parameter for reference comparison Date: Fri, 15 Dec 2023 11:42:54 -0500 Message-ID: <20231215164447.743787-1-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When using visl in automated tests, we need to have output frames that can be compared to reference frames or hash of those to validate that the whole pipeline is working properly. Make sure that a given input stream always outputs the same frames. This is done by removing TPG information like queues status and pointer values. Introduce the tpg_verbose parameter to allow adding the more verbose information that this patchset removes This also adds some stable variation in the frames so that different input give more different output. Changes since v3: - Fix some more permissions in vidtv - Rename stable_output to tpg_verbose - Rebase on media_stage/master to include AV1 support - Remove code churn in visl_get_ref_frames() - Remove code duplication in visl_tpg_fill_sequence() Changes since v2: - Set parameters permissions to 0444 in visl and vidtv - Make stable_output true by default - Keep showing frames timestamps and remove vb2 buffer indexes only in stable output mode - Make codec_variablility non optional (remove parameter, keep implementation) - Add details on used variability fields Changes since v1: - Fix typo in parameter documentation Detlev Casanova (4): media: visl,vidtv: Set parameters permissions to 0444 media: visl: Add a tpg_verbose parameter doc: visl: Document tpg_verbose parameter visl: Add codec specific variability on output frames Documentation/admin-guide/media/visl.rst | 12 +- .../media/test-drivers/vidtv/vidtv_bridge.c | 26 +- drivers/media/test-drivers/visl/visl-core.c | 15 +- drivers/media/test-drivers/visl/visl-dec.c | 346 ++++++++++-------- drivers/media/test-drivers/visl/visl.h | 1 + 5 files changed, 237 insertions(+), 163 deletions(-) -- 2.41.0