Received-SPF: pass (google.com: domain of linux-kernel+bounces-1333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, "paulburton@kernel.org"
 <paulburton@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>, Tawfik Bayouk
 <tawfik.bayouk@mobileye.com>, Alexandre Belloni
 <alexandre.belloni@bootlin.com>, =?utf-8?Q?Th=C3=A9o?= Lebrun
 <theo.lebrun@bootlin.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 21/22] MIPS: generic: Add support for Mobileye EyeQ5
In-Reply-To: <6b747f3b-f0d7-4e40-a331-8d2323e4874c@app.fastmail.com>
References: <20231212163459.1923041-1-gregory.clement@bootlin.com>
 <20231212163459.1923041-22-gregory.clement@bootlin.com>
 <6b747f3b-f0d7-4e40-a331-8d2323e4874c@app.fastmail.com>
Date: Fri, 15 Dec 2023 17:52:19 +0100
Message-ID: <875y0zcssc.fsf@BL-laptop>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

"Jiaxun Yang" <jiaxun.yang@flygoat.com> writes:

> =E5=9C=A82023=E5=B9=B412=E6=9C=8812=E6=97=A5=E5=8D=81=E4=BA=8C=E6=9C=88 =
=E4=B8=8B=E5=8D=884:34=EF=BC=8CGregory CLEMENT=E5=86=99=E9=81=93=EF=BC=9A
>> Introduce support for the MIPS based Mobileye EyeQ5 SoCs.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>> ---
>>  arch/mips/configs/generic/board-eyeq5.config | 42 ++++++++++++++++++++
>>  arch/mips/generic/Kconfig                    | 15 +++++++
>>  arch/mips/generic/Platform                   |  2 +
>>  arch/mips/generic/board-epm5.its.S           | 24 +++++++++++
>>  4 files changed, 83 insertions(+)
>>  create mode 100644 arch/mips/configs/generic/board-eyeq5.config
>>  create mode 100644 arch/mips/generic/board-epm5.its.S
>>
>> diff --git a/arch/mips/configs/generic/board-eyeq5.config=20
>> b/arch/mips/configs/generic/board-eyeq5.config
>> new file mode 100644
>> index 0000000000000..d94e408145389
>> --- /dev/null
>> +++ b/arch/mips/configs/generic/board-eyeq5.config
>> @@ -0,0 +1,42 @@
>> +CONFIG_HIGH_RES_TIMERS=3Dy
>> +CONFIG_TASKSTATS=3Dy
>> +CONFIG_FIT_IMAGE_FDT_EPM5=3Dy
>> +CONFIG_BOARD_EYEQ5=3Dy
>> +CONFIG_PHYSICAL_START=3D0xa800000808000000
>
> ^ I still think by doing this you are risking overriding starting address
> for all other generic systems. make 32r6_defconfig will load config files
> of all boards.

I think at a point you mentioned a way to remove the eyeq5 config board
from the 32r6_defconfig. It would be indeed a good solution.

>
> Perhaps just provide an eqm5_defconfig will work better?

So you mean a defconfig in direclty in arch/mips/configs/ and not
anymore in arch/mips/configs/generic ?

Gregory

>
> Thanks.
> --=20
> - Jiaxun

--=20
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com