Received-SPF: pass (google.com: domain of linux-kernel+bounces-1409-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 15 Dec 2023 19:15:55 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
	r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com, horms@kernel.org,
	p-varis@ti.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v9 08/10] net: ethernet: ti: am65-cpsw: add
 mqprio qdisc offload in channel mode
Message-ID: <20231215171555.4emy5fn77ej6oti6@skbuf>
References: <20231215132048.43727-1-rogerq@kernel.org>
 <20231215132048.43727-1-rogerq@kernel.org>
 <20231215132048.43727-9-rogerq@kernel.org>
 <20231215132048.43727-9-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215132048.43727-9-rogerq@kernel.org>
 <20231215132048.43727-9-rogerq@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q6S0W0sjsvUQ5Z5aac2M53BuMVXGEsq07aO2Z7kQn+0PGItc5sO/NeoMHu0r?=
 =?us-ascii?Q?YyD1QdsVXmXrW8SpyYJftWPEZ+3nqwfNT5JPDmjmS32fSta7vnpX2zVXVdhK?=
 =?us-ascii?Q?Qh600Tia5Iw029C7TpnVeAhj3jw/AICduhEKo2rHjGFZdjUN5cyTsRbVPHeD?=
 =?us-ascii?Q?ybWLdkzChSDBVq1IEoIg/NkMsgZXvhGXwiDEhYqz3K6rBD9YZ44xx6eM6JRS?=
 =?us-ascii?Q?/zZPyhqYKqCCxD1HTXHdzaMo7fSDEli9+Lva7pvv6/Su6MWBt/McPkF84dBD?=
 =?us-ascii?Q?Mj66fgQrUFVjoxIYo53cXO9ZxsdAd6Gzf8hz8n+ZFAh+tta36+bldXdtVkIm?=
 =?us-ascii?Q?JKy5bJtmFz2ayyXKcuzKIXzmsfKiT787B3RDXzZrmn3UH4Ij7LnsoZJYoH+x?=
 =?us-ascii?Q?/mQhc4jEbLusbwcUmb28ZHoqV4McmQyCy7SL3V9IrLS+XjYAwVoDeoBsbN2s?=
 =?us-ascii?Q?pM33LfIS+3AeYzr2WQ4zJJqQDbV5Qo1SS0Gm+FScacS3r8yBEeGUFBWNRgzf?=
 =?us-ascii?Q?j5Wt2jvG4WCwpQRdnYFYDugrJbETlSZN5vzcpSNlKYd5tjVw6TGYbK5CAzns?=
 =?us-ascii?Q?xBmmRjdrAQkHNq5maU2IAAupc5Z12wSt+fAjXlvjDe9yOTA6eP45QcmkxCcV?=
 =?us-ascii?Q?bpLkBgjHiaGx8AyEwoJEsI9R+6tpp8BfrfhNIhoDW74Y45ROOZHcevTNYH9g?=
 =?us-ascii?Q?9z6ppAeS3spBmfZNzwk9oja8ktYehGduJyenTgTJ3pGZR1MtUs0MIaI4L2DV?=
 =?us-ascii?Q?9jq90ERjDzT2vGDFng8djdzRsI8wWI4o8tJi5wHN//70E8IxgHuKg8SP8LcO?=
 =?us-ascii?Q?OE6aiUzlGeiTvl64dERGKqB2XPCrtsJidgNT4zKieTgB3gGsQpqndrCLsuc4?=
 =?us-ascii?Q?VfH+BuuICtxa4h7mV+E1Cw4WWXMoWq1X8goGzokpIr1PWqta4jzoV7WUnzkr?=
 =?us-ascii?Q?6It1JxAnc3mX1CQMBBsHB2A0G4Jciwzxl77JhSUuKw6i6qAxnfDd6At506zW?=
 =?us-ascii?Q?zIyMm61qM8t+/rdocCPmc9M48dp0chXdevM24ceCMu9JjkUXkCXwoOsbhstF?=
 =?us-ascii?Q?GWG5ABsgmetOYI8gEzZFfJCdfCL0LC1TZvefPweHDYSREt2qtQVidiQPhEEp?=
 =?us-ascii?Q?4n6rZqHAJtYJoP1aAMTa2Nf7xUJ5ZmQA7jYDPtCcX2cfrRW2SazzfQekn9Z8?=
 =?us-ascii?Q?dVV0BjPGGVYTDjNdi2mmREx5LTHcmQB9GVj4XiLiBgmoa8I39IgaFCbvBork?=
 =?us-ascii?Q?Ao1JHZQiBRMi76iODVzQ+tRnpm4M3Wk2x3MIvFGB7PL8N6gpWyhgC9xtm34p?=
 =?us-ascii?Q?TbtOfxCjwLoXZ1KepNWT5H40XI81Mtx88sR9kDFJaxGAaCtXp44fGOho4D8X?=
 =?us-ascii?Q?7OPN439qlHpvhRfT7ZeJIeroYb9Nm9R/yPtnrfSAa7b0y9kdPnuaz0U0rfmL?=
 =?us-ascii?Q?OxmhX4MouESGvwHHVIVvhny60JDTcNakpdFj+8q1Xd8EyjlsuwNLoSNqnoU9?=
 =?us-ascii?Q?2nM8pl+jyUKpV8ScayuyQQ57vAbh14eIT4YR2oC667DO/0xFSGvGUM58J+Vt?=
 =?us-ascii?Q?+O5ANtLkd9J6yF9uq953roXU43skbUYvPdetRB91h6FxJOU0J/1yLWePbRGN?=
 =?us-ascii?Q?DA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98d3835e-0191-4442-32e9-08dbfd9181c1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 17:15:59.3813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40/UQzZbWaEebX0jJIDrJi13K6DcWNys4CLbSMaa75PXM6p5SzxUo14fXTGwDtpfNx8zJryYKeUwbbOOx0Rf4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8658

On Fri, Dec 15, 2023 at 03:20:46PM +0200, Roger Quadros wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> 
> This patch adds MQPRIO Qdisc offload in full 'channel' mode which allows
> not only setting up pri:tc mapping, but also configuring TX shapers
> (rate-limiting) on external port FIFOs.
> 
> The MQPRIO Qdisc offload is expected to work with or without VLAN/priority
> tagged packets.
> 
> The CPSW external Port FIFO has 8 Priority queues. The rate-limit can be
> set for each of these priority queues. Which Priority queue a packet is
> assigned to depends on PN_REG_TX_PRI_MAP register which maps header
> priority to switch priority.
> 
> The header priority of a packet is assigned via the RX_PRI_MAP_REG which
> maps packet priority to header priority.
> 
> The packet priority is either the VLAN priority (for VLAN tagged packets)
> or the thread/channel offset.
> 
> For simplicity, we assign the same priority queue to all queues of a
> Traffic Class so it can be rate-limited correctly.
> 
> Configuration example:
>  ethtool -L eth1 tx 5
>  ethtool --set-priv-flags eth1 p0-rx-ptype-rrobin off
> 
>  tc qdisc add dev eth1 parent root handle 100: mqprio num_tc 3 \
>  map 0 0 1 2 0 0 0 0 0 0 0 0 0 0 0 0 \
>  queues 1@0 1@1 1@2 hw 1 mode channel \
>  shaper bw_rlimit min_rate 0 100mbit 200mbit max_rate 0 101mbit 202mbit
> 
>  tc qdisc replace dev eth2 handle 100: parent root mqprio num_tc 1 \
>  map 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 queues 1@0 hw 1
> 
>  ip link add link eth1 name eth1.100 type vlan id 100
>  ip link set eth1.100 type vlan egress 0:0 1:1 2:2 3:3 4:4 5:5 6:6 7:7
> 
> In the above example two ports share the same TX CPPI queue 0 for low
> priority traffic. 3 traffic classes are defined for eth1 and mapped to:
> TC0 - low priority, TX CPPI queue 0 -> ext Port 1 fifo0, no rate limit
> TC1 - prio 2, TX CPPI queue 1 -> ext Port 1 fifo1, CIR=100Mbit/s, EIR=1Mbit/s
> TC2 - prio 3, TX CPPI queue 2 -> ext Port 1 fifo2, CIR=200Mbit/s, EIR=2Mbit/s
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>