Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6837168rdb; Fri, 15 Dec 2023 09:30:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfZI92MR4AxHfu8EGM8pA8VUFeqTZjBtt9KFaDI9Z6iAteOf4KWZvjB8uO/12uRxue511u X-Received: by 2002:a17:90a:dc02:b0:28b:2021:26d3 with SMTP id i2-20020a17090adc0200b0028b202126d3mr1339243pjv.23.1702661410526; Fri, 15 Dec 2023 09:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702661410; cv=none; d=google.com; s=arc-20160816; b=phZfB++o7I/td9dFhdmYueO1LGsS5AAKvOWaFtfhThN5WUi9CD3hdN7lH+IaOYPHCZ Hzn/Y8b2Nyk1OmQHl3JecaBjsEbIaCapOrdp5PpdTMBIcuABNL0w+azpWSxOgD0P40OE Jm3+QT/7tDpcKvKD5vn4izC4YOZwnQah/2k3Hglm/LxG4sWByDwx+B7LFGPR6vJfhyGl KIGughCXwmmbs0ByY5p+LphNudzejqVe6/4iGuVuz83lR0OSeRGjgV0uxaiDapWemURR pkI84ERW8v28QpXo5AierwQai853wQxN5As219T9uawtDOavikriyZP6BvPeQ3mhr7Tw YLlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:references:cc:to:subject:from; bh=sIgz+/bf+hGwrWc/Jbcs9WMp9CWyxnEu6NTk5H1GPUs=; fh=2RsYFHEIGT6SdwVMn2Fr/vWWtVyxDK3oO9pDiUb5rTA=; b=lIm/1vkL1iDGzEm6GPFiR5+AqQDJ4BD/xyE1QlhegZjnSOy9/mWnqk/fCFgXy20ct/ tTO3EgXOPb9s1dgwfpenwQ6/sJ4VqkuG1rRFqDmVMdviX14oT2gWQ1f77Bo/PgqAhvTa z+k7GC4IYljfk+Zl4Z5TsjNWsMZDF4vepOKXgweu6xcTBjIkqTr2GAjJZZ2QhAwL9Dzw dwGTRpcnF/EUaCPt4UNoq12XG++0CkC40uFIgYRBz+7uMkLPdH4MNOaod1e/x4liAJen gz1QS7ze4Vl4+KaTaj6BJiX/+yjO9+gfpegtzjbvPIBXYS/mNN55KIRu3M5VzpWeccjW TCuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d5-20020a17090ae28500b0028688bb3d17si4829457pjz.159.2023.12.15.09.30.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 09:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 31BC52873A6 for ; Fri, 15 Dec 2023 17:30:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10F0647F69; Fri, 15 Dec 2023 17:24:23 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B524777B; Fri, 15 Dec 2023 17:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (31.173.86.106) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 15 Dec 2023 20:24:12 +0300 From: Sergey Shtylyov Subject: Re: [PATCH net-next v2 07/21] net: ravb: Move reference clock enable/disable on runtime PM APIs To: Claudiu , , , , , , , , , CC: , , , Claudiu Beznea References: <20231214114600.2451162-1-claudiu.beznea.uj@bp.renesas.com> <20231214114600.2451162-8-claudiu.beznea.uj@bp.renesas.com> Organization: Open Mobile Platform Message-ID: Date: Fri, 15 Dec 2023 20:24:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20231214114600.2451162-8-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 12/15/2023 17:05:17 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 182146 [Dec 15 2023] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.106 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/15/2023 17:10:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 12/15/2023 3:08:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 12/14/23 2:45 PM, Claudiu wrote: > From: Claudiu Beznea > > Reference clock could be or not part of the power domain. If it is part of > the power domain, the power domain takes care of propertly setting it. In > case it is not part of the power domain and full runtime PM support is > available in driver the clock will not be propertly disabled/enabled at > runtime. For this, keep the prepare/unprepare operations in the driver's > probe()/remove() functions and move the enable/disable in runtime PM > functions. > > Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov [...] MBR, Sergey