Received-SPF: pass (google.com: domain of linux-kernel+bounces-1422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 15 Dec 2023 19:27:10 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
	r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com, horms@kernel.org,
	p-varis@ti.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v9 02/10] selftests: forwarding: ethtool_mm:
 fall back to aggregate if device does not report pMAC stats
Message-ID: <20231215172710.v6gtreijeqzocmv4@skbuf>
References: <20231215132048.43727-1-rogerq@kernel.org>
 <20231215132048.43727-3-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215132048.43727-3-rogerq@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?XRAM7/g15rRhhz4faMAUDVwqCn3Qpdija9/QWDCDVXjA3QpdxMzbyCUKv3yY?=
 =?us-ascii?Q?w3atCHslXFQx76p9BQQ02G2e4nevXuS/Rj2vr3YWx9GFceHebweWeqWVIdr8?=
 =?us-ascii?Q?/9pqsLJHAxXLKqXT3DEkpYjvLmAaJBOGbe0NJSEi5lNDpZ4PLV8TazIDWIlA?=
 =?us-ascii?Q?7Jzxb9tGGgDdK5T1KqpwWvyR+hyQIbTvsrmsZGELaALqoWFcb3FUn9MRPM5x?=
 =?us-ascii?Q?bqRTttqTM7+TJtqCcOcgO5sotk/jzxcovN9g326KaoVl8R8hQ+nZbAVQ5S9J?=
 =?us-ascii?Q?gwbgl1o+mTzP7gFDY1Ay1RFTcq+pY9mBqC/2agchPGha5Yc/EsE9ZYmF+Oqe?=
 =?us-ascii?Q?LsRdI2KBdL1jk595Cdngp6fh9RISgWQf6LvLx16642cxurYUKo1J075nuO1c?=
 =?us-ascii?Q?8FafEZ/wbk/VW4kuuPBzTbK9W3AXKCuGM3tLTSUVq67YAV3gloVv637N4/JA?=
 =?us-ascii?Q?XuAoFjGVCaWbvE6idAuGF0oLeXOVt8L9b6mkw6nMewAhP0HBoR3phc1IaCmc?=
 =?us-ascii?Q?NuLWCc+kkpfjJ++eGN4o8Xm5VFZgE8QSs3tWx4GfrhtfJWA3no+Xv7nDOxM1?=
 =?us-ascii?Q?09y/s0docJoZmdyUQzo3dQOZ5utJB4i/26snGj/li8cVE5hMfvxsj3ebEVLo?=
 =?us-ascii?Q?pmNZ5eO3LqDW8ULWeXGp/MeIRRlfs6+LswEemB+7Y6yH64I43MiX+V0OR5FJ?=
 =?us-ascii?Q?K9ZC01RBUWI7sT0xx62LWvq6AdoJ6ZdYC2brSH5HpFef9kPKQIlud3l/XGKd?=
 =?us-ascii?Q?QuG6i9jo5mf+JhZZKDWU9AGV5mLFG+XBpG041CfECUTOGVn7DtructR+qBNr?=
 =?us-ascii?Q?7skGs7+5gGwtu7LZVfV17EP87wHJHr99vSKhgXRNafahION1VqF7Co3BA5fX?=
 =?us-ascii?Q?0hWFIi/IXUERo7+MsvIe7/MM2BgxhMobX47yskrXu5pZEupzjNgv5rGoV3l6?=
 =?us-ascii?Q?7W7u2qiIFpCbVaH8mnkfH1M6nrAy1wvJVx8qjO0iYJVUn9MD+Moj4GqolqHP?=
 =?us-ascii?Q?Y4Na8on4PazsTqCtnt5kOysGb42nZq0wutfG08zawOc9AeJ2BFOgPjfGUcA1?=
 =?us-ascii?Q?XsXXQdpqmPcD+kyT2CWm6o5g0HRomnN1R+clBittZzb3gpj8zDHJI2dXEg9w?=
 =?us-ascii?Q?GGsKpQ65JHFJ81jdpePy6QwNmD4/FZ4gP26Di9S8GzjDIrVaDIDuoImi3CFH?=
 =?us-ascii?Q?uaM6RH5LtSqExJJh3i2pqB23EyBmeq0o4hHtEcXBNIbSQFOkFOeHCMDR11OM?=
 =?us-ascii?Q?17wG/3myGVw85MDWd05eUsGznawFjiogj4bx0J7ZaLwJf21acJUUY/qgMmbT?=
 =?us-ascii?Q?BzQXwFHZa3MSHXiFZsGlftg+GDP29NRz2OR/KTsE+Pu7NY42pk2R8adX6iW/?=
 =?us-ascii?Q?1nBeB9Z5zMKVyEEW7NLuJfMZr9v/UMeQsviwWIOAWFxxCZbjECqvg5vUUoI5?=
 =?us-ascii?Q?FcPowfxtNLvsruMYmikJQuG89Yg5kHpJfLy9jMhRj/G9+jvLXigciYjhIBDN?=
 =?us-ascii?Q?m/CbR3SfWjG5TZkbC4Cgv0HIIqDaMcLaPhogq8gEv5RhRRSLzjykMruNY1db?=
 =?us-ascii?Q?4Zfk5xKKtYsE51USgxKgr/Fxpp+LnLjp0BOvGhmzBYHR8XKTGTl8ADuAmE0x?=
 =?us-ascii?Q?nA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9446600d-0677-4a69-aa31-08dbfd931409
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 17:27:14.2523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tus3nv66Pumk5G+CQbqyTlI7PtTDc3AhtYcdZqx+uE2qe2Uk6jCd8k8jMvj0pSy4lxWF2TPWFiTqYVs4t42K4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9236

On Fri, Dec 15, 2023 at 03:20:40PM +0200, Roger Quadros wrote:
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 8f6ca458af9a..763c262a3453 100755
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -146,6 +146,15 @@ check_ethtool_mm_support()
>  	fi
>  }
>  
> +check_ethtool_pmac_std_stats_support()
> +{
> +	local dev=$1; shift
> +	local grp=$1; shift
> +
> +	[ 0 -ne $(ethtool --json -S $dev --all-groups --src pmac 2>/dev/null \
> +		| jq '.[]."$grp" | length') ]

This is broken. $grp inside single quotes will search for the plain-text
"$grp" string, not for the $grp bash variable. Use ".[].\"$grp\" | length".

$ ./ethtool_mm.sh eno0 swp0
eno0 does not report pMAC statistics, falling back to aggregate
swp0 does not report pMAC statistics, falling back to aggregate
$ ethtool -S swp0 --all-groups --src pmac
Standard stats for swp0:
eth-phy-SymbolErrorDuringCarrier: 0
eth-mac-FramesTransmittedOK: 90017
eth-mac-FramesReceivedOK: 90033
eth-mac-FrameCheckSequenceErrors: 0
eth-mac-AlignmentErrors: 0
eth-mac-OctetsTransmittedOK: 9181138
eth-mac-OctetsReceivedOK: 9182112
eth-mac-MulticastFramesXmittedOK: 17
eth-mac-BroadcastFramesXmittedOK: 90000
eth-mac-MulticastFramesReceivedOK: 33
eth-mac-BroadcastFramesReceivedOK: 90000
eth-mac-FrameTooLongErrors: 0
eth-ctrl-MACControlFramesReceived: 0
rmon-etherStatsUndersizePkts: 0
rmon-etherStatsOversizePkts: 0
rmon-etherStatsFragments: 0
rmon-etherStatsJabbers: 0
rx-rmon-etherStatsPkts64to64Octets: 33
rx-rmon-etherStatsPkts65to127Octets: 90000
rx-rmon-etherStatsPkts128to255Octets: 0
rx-rmon-etherStatsPkts256to511Octets: 0
rx-rmon-etherStatsPkts512to1023Octets: 0
rx-rmon-etherStatsPkts1024to1526Octets: 0
rx-rmon-etherStatsPkts1527to65535Octets: 0
tx-rmon-etherStatsPkts64to64Octets: 12
tx-rmon-etherStatsPkts65to127Octets: 90005
tx-rmon-etherStatsPkts128to255Octets: 0
tx-rmon-etherStatsPkts256to511Octets: 0
tx-rmon-etherStatsPkts512to1023Octets: 0
tx-rmon-etherStatsPkts1024to1526Octets: 0
tx-rmon-etherStatsPkts1527to65535Octets: 0

> +}
> +
>  check_locked_port_support()
>  {
>  	if ! bridge -d link show | grep -q " locked"; then
> -- 
> 2.34.1
>