Received-SPF: pass (google.com: domain of linux-kernel+bounces-1432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1a05246e-4468-4ca2-96f5-95c137813440@intel.com>
Date: Fri, 15 Dec 2023 09:39:24 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 01/29] selftests/resctrl: Convert perror() to
 ksft_perror() or ksft_print_msg()
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Shaopeng
 Tan" <tan.shaopeng@jp.fujitsu.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>
References: <20231215150515.36983-1-ilpo.jarvinen@linux.intel.com>
 <20231215150515.36983-2-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215150515.36983-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmZWc2pSb1VuRGZUdzRrcjVzREdGQS9wYkp3dHczVkNEMDJFR1pkZ280dmV3?=
 =?utf-8?B?d1orU2sxMWlVMkdxTUVXbXVoT1U1M1o3aGNURkRFQnQ4UjlQUW1OMUg1ZGFq?=
 =?utf-8?B?SFNCNTU3Q0Fxb2FHcTl4N3ptaWFvSnI1aGFaU0dEaFptSlNYaEpjUWtwWW9H?=
 =?utf-8?B?TUlHY2J1MG8rZS9vdVN0U2JSaGZPNDNJUVlOK2VUTThDem9rNktUakNVOTFo?=
 =?utf-8?B?TVppV2ZmUm5YVWFoTm8zRVJNSm9uQ2JQTi9oa3o3dmJCeDBmaHM2V2ErV1Nj?=
 =?utf-8?B?TmtzNTJOZ204emJ2aW01UTFmdEdpK3VCVmpaZ1pFZUZxQkVZQXhGSE05azRN?=
 =?utf-8?B?UGFtT3MzSExOZlFCVVlYanVPZnR2QTNzT0pOVGdLRDNmNHhaOWlvdWUyMTNm?=
 =?utf-8?B?eTkrVnExa2NTSGx5MmljVnpRa3FlbXFrVVhIK3c5c0tRcDBhUWtGYnlaR2lY?=
 =?utf-8?B?SzFqazY3bExQUGxuOC80N2pvajNDdFI1SGpYY2Y2M3NLU1hHa05oQlRFSnFY?=
 =?utf-8?B?bDExMUJRbWdZRXlPMitQSUN2dGpwcVkwVlJiR2h2U1krZjZ6aWE4ZWxsQXNo?=
 =?utf-8?B?empOMUkzOUVPNGV0R2JJV2VNblRSQnl4ZVU0Rk00eFFHV3d4MzgzQWdtMHBE?=
 =?utf-8?B?S01hRTAxTGVDRFN4SzlEZGh1Qzg1NjRPOC84OHQxL2hKN0ZES3I4UkVFdWZX?=
 =?utf-8?B?bkdkN1RPclQ2UmVpbC9GRi9OQkRrczI5dDNCVTF1V0RUUTdPZVN3aUFRbGV1?=
 =?utf-8?B?MVp3aXczajFFSHd3YnV0WllsUGFTMlVFUTdGS2lKSXJNOTJZOUhKdGFHQmY5?=
 =?utf-8?B?WHhIVGJPc2pNaUd5Mm55ZzV2NUJOMGRHTHBJUUtGUXFNQU10bW1QOTBuRTk2?=
 =?utf-8?B?MTB3WktrWlAyR0NyVnoydElySHVKbTJzK1R2NkRCcGhPdmZ2TFpkM1NleG5l?=
 =?utf-8?B?NmRhWUIyTnorR2xpZTBCcEZTbk5ML052Y1h1YU50bUJZL2NBL280VXZFbWNt?=
 =?utf-8?B?TUZIYmxkWlBiaHJTbVhJTGY5bG1hTGVRaGJBN2RUNWliRjRPRld6eFVZOG50?=
 =?utf-8?B?RUxqNEZTOXpvMlFUVVhjOXRFbXdXNVFHWWxmUVhObnhxZENaUUMxUWxvR2xo?=
 =?utf-8?B?bUxKZThzQUFJMkhTQ2lqUml3SVFsVVpBVVVMUWRxcXhldFRScENHMStUK25E?=
 =?utf-8?B?czY1Zlk3ZDR1L1lYZnpWaU0xT1IyZGlaMStDcDg3SFRnbUdaTW1KUkR0Y3BC?=
 =?utf-8?B?NWl6NFVqOW1jYmdNSWxVajBkK1FHY2d5Y3ZTdGxNMldFM0lHTFRtTFRLRHhj?=
 =?utf-8?B?ZHBmUW43aVorMjJ1Q0FuSmtqSVUrcEJIYjhNZG5VckViWktMRDM1b2owdW95?=
 =?utf-8?B?clp5VG14Mk1zOEY4MGg2THlVV3JNdEEwdUdJcXE1aXdNcXNwb3ZnTE14bUZM?=
 =?utf-8?B?a2FrVFJaZW9WaGlWa1Z4MDE5U21ZZ3V2b0s0MUpsd3JxL25pajM0aHlpak1w?=
 =?utf-8?B?SFlqU1A4Z3hlUGFlZEdzYU0vdWNBK21ZOTFvd0R1c1NFNEg4QU5iQ2s4ZGR1?=
 =?utf-8?B?bng4MFN2VVB2dHRueFA1OWMyUy9HTzAvSzkwUVVTaTh1b1E2eDgrWUFHb0Va?=
 =?utf-8?B?VE5ucFc5VnI3TFp6dFRTc3ErV0Rma2RZQ2o0Ylc4eVhyU2h0MktCY3E2dTRm?=
 =?utf-8?B?YVh1c0VNRnVhTXdmeXJ5Z2ZTb0NCZjRZQXBEU3MvZy9GSFg4WUtBN1VNV3Uv?=
 =?utf-8?B?MUZ2MkRKMUxSNFNLODBiSUViOHlqZnIvNloweVFVOTlZa1hORWdjV2lhKzh3?=
 =?utf-8?B?L1B6Wm1UUlE2VnBTRktJRTJxMlMrSUtTdEJhZzFkWHQ1R0VkODRuWXVvcm01?=
 =?utf-8?B?SjNCYWFDTXpTUU5ObEhyYTNRQUU1cUlDSGllZDJiWTl4eXk0U09jYldkdytK?=
 =?utf-8?B?ZDVrK29lamNtcFFZVThWV2dBZStyWmd6NDRKMG5pTnc0VzZlNzFsekU0VVEx?=
 =?utf-8?B?d3U5Q2hKT2d4WHVic1hMcWJUenpuaUMyWUY4ZlB1SSthY2NLYmphMXFSYWgv?=
 =?utf-8?B?UnloNXRJclFJWk5XUnBKbVBOZExzck1HbW9yL0poVFUyUkpMQXFXekZGYi84?=
 =?utf-8?B?VTVueEhYeGpsSlRwalhjNkdaRHVqd0VscG1HZDk4VGM3UmpXWW9RWTN3R2Rs?=
 =?utf-8?B?RUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57e9b467-1fb8-4496-4afe-08dbfd94ce81
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 17:39:36.6156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ipsWteSM5cAQqX3WrU9iDaGT1qVmD7M/UYtT1NsUH4CMJcQ0ifb+5YcPpUMDlcBmAxd1TEFC/VAFHiGAuub52vWlCU0i2x3BHcwYBD66T6Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5878
X-OriginatorOrg: intel.com

Hi Ilpo,

On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:
> The resctrl selftest code contains a number of perror() calls. Some of
> them come with hash character and some don't. The kselftest framework
> provides ksft_perror() that is compatible with test output formatting
> so it should be used instead of adding custom hash signs.
> 
> Some perror() calls are too far away from anything that sets error.
> For those call sites, ksft_print_msg() must be used instead.
> 
> Convert perror() to ksft_perror() or ksft_print_msg().
> 
> Other related changes:
> - Remove hash signs
> - Remove trailing stops & newlines from ksft_perror()
> - Add terminating newlines for converted ksft_print_msg()
> - Use consistent capitalization
> - Small fixes/tweaks to typos & grammar of the messages
> - Extract error printing out of PARENT_EXIT() to be able to
>   differentiate
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette