Received-SPF: pass (google.com: domain of linux-kernel+bounces-1464-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <056a2d2b-3b09-4a70-92b0-8634a24464b9@intel.com>
Date: Fri, 15 Dec 2023 09:45:21 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 00/29] selftests/resctrl: CAT test improvements &
 generalized test framework
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Shaopeng
 Tan" <tan.shaopeng@jp.fujitsu.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>
References: <20231215150515.36983-1-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215150515.36983-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enFKd09lb1FyRURURWV5TEJ2SVRnUCtscU42UE9pbDdxMnYvQzV3VnIvaFN0?=
 =?utf-8?B?ZjhoemNLTHplczVNMjQyVnlMWkdJc25hZXRVRm81dFo5ZTFqT3ZTY0s5WUhE?=
 =?utf-8?B?cVdKQWhLZjZONGIyaTYvYmNWMUNyQ2hiK0xaT1lrbU4zRWcreHpqd0E2Unpv?=
 =?utf-8?B?cDJVcGRLYlpGQ0c0YkY1d2dhZVhsUklXWSttanZXcGtwZDRDbkxpVnJXcGRu?=
 =?utf-8?B?V3hiWUpRMDRtSm5UWERPcmZ0clliMFdlWnZTbENmaUVHYlJNOVZmU254M2lh?=
 =?utf-8?B?N3ZDdHF6U0FMSThWdGxzVFVDYUl2eFh1eXRkbDdsdmRrNkVNV2NndWQ5VS9o?=
 =?utf-8?B?eERzclZXV0d5R3k2b0FXS2dEQUxjZW5yMStoOWZ6YlhOQ2QreCtyaWhTa0NI?=
 =?utf-8?B?SXVrRWcwNmJvYkFZNUc4Nkk1Y1daWVFaMEFTZy9mZ25jQzZyS0VINkVZc2cy?=
 =?utf-8?B?WnIxbm4ybGNqSTdJVlJoNzEzLzY1WERrbnNOVyt6aGpibmxGTE1Fb2ZYY20x?=
 =?utf-8?B?MlQ4MlkwV2dnZmlzNUlxTlZOamRGZmhCbmpQOGhSU216b1NPckRiNW9mMjJy?=
 =?utf-8?B?d3diSXhWUnEwRGY4VlBOaFBKM1dObUFEeGtJQTAzMzVCdnNEZHk0cVJzSG42?=
 =?utf-8?B?YUlWSGRydjJDNFl5WTdZS0RaVFZ3YUxVTmpMazF2SUlERmtyemkrb25WTXE1?=
 =?utf-8?B?MTB4ajZCN3cxRmE5MVc5K0VxdkFOaVFwSFBFNGo3WU43eEYxMnMyQkVjbDlz?=
 =?utf-8?B?MFhNazd0R2pVcERqNjNtbzZwaGxJMGxaNk4xWEZ4d3RpS1dweHRQNkY3SjJJ?=
 =?utf-8?B?SUV6TEY4S1M2U2VHOG9NVERELzBWMFB5ZytHZ0M3dUZGQjdkVjYyd0FGbmsw?=
 =?utf-8?B?UVNvT1c2Uk5obSs5YTNQR3dXVFBRNHJkS1loM3I3dm8ybjd6bWd0OE05eDEz?=
 =?utf-8?B?dWxlYjNSQnlaSXFmc0R5S1ByQnNtaDdPTCsyWmtJTjZXcUlaKzBqaUJSdzhi?=
 =?utf-8?B?b0tlcnQ1bmg1OGt6SDBhZVZSWTVuRlBWNjFEMFdKaitla3M0WE1kUjFZNUpK?=
 =?utf-8?B?Z2E5d1NzZ3pZUEdSSXBZRmY0aGpUenBDMnM1d1kwUEVETWRJQXdDTjZUblgy?=
 =?utf-8?B?c3BHR25tVFgzUXpwL3o5V1NkeHIrQ3ZKSGEycEY4Wm4yWVdFVHkvaFRqSkhk?=
 =?utf-8?B?YkFaTVRRSFFKSDE0bTJqSkgrZ3kzbTg3aG5PM3VYb21CbWNrdWRYTkVpcThz?=
 =?utf-8?B?UVF2aEpsV25rdXVnS0JWV1NqcEFhaGlqTkZXejNrSnA5bHc0bkVjMG5MWjhT?=
 =?utf-8?B?cmNLc0VKWXFpbzRXZ01tR25obTA2K0JDNElKUzBrS1ljWERmTkJORTU2QUFT?=
 =?utf-8?B?NDhtMHFKUFVlWXBMWCswOUh5QUlZVCthajk0Y0RqWkkwRWFMMFJsWXBMaWox?=
 =?utf-8?B?YkZLVitnbkVXcFdVcUE0UVEyYnFpbWVYV1hvb3VlMHRBcGw4TkpaNTZWVmFo?=
 =?utf-8?B?cEUyY0xROGExR2tsTnFJV0FlS2tpc0FrR2ZkeHpSVi9zK3c1dkRvQUhCcUJM?=
 =?utf-8?B?WXEzWXVSbGM2MHRlZCttTEEvdFlLaGczVStyMlYzMVErK2tpSmZTUDhHTmls?=
 =?utf-8?B?S1JmdGVEVzBZS1BDUmZ6MU0wMlcrYnFWQ1JvQTZyeDZ2ZFNodS9MU2JVS0tC?=
 =?utf-8?B?QzRnQ3kvRyt5NGU5NFNObzc2azdvMGtTK3VtODVnVzNOZTF3RzhFeEg1RVpK?=
 =?utf-8?B?aHVkeHJYZXkwWnlTNXRqSXdlY3hGWlFwMERVVHY0OWlORGR2aVo5RDlRRTZC?=
 =?utf-8?B?L0l4TDNPVUd3ZlFPZVVQaVF4RXlxeldRcDBLVFIrclg3ZnNxWHpnbUN0SEpG?=
 =?utf-8?B?NWQyN2QzTCtmdnR5N0dzSmk0U0NQTlRsSFlrc0huQlhUTFhoYTJmSExXRy8w?=
 =?utf-8?B?RlRsdWpiTjdrZ1dqSVRBQTR2bG9maUZFb0dBdWIxWGFIQ1VESzFaZi93eWFZ?=
 =?utf-8?B?anhPZ0VVc0IzNFhqRk9peGRDcEdLSE1HbEN1NGhjWmMwTzRhcGtRU1BDUzJP?=
 =?utf-8?B?alMrMXBkUGdiN3NYOEtockQ4NWZ5dWZSYVY0YWhVR3NnbGJ6ZWN2ZDVEWXAw?=
 =?utf-8?B?U0lxNE42VzRKRVpBSFNYN0E0SHJFd0xja05lVHhYYmpOcWxXSDJleDJqQ1RY?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a3b78b0a-536e-42ce-f50f-08dbfd959d1e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 17:45:23.2496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GqFcS+MKilnmTbqXc0ekGz0LuNWruYQcDocbtvMX6c1AAyTM/W51JUwLp7O7+Xr8UZMPZPNCPjkMFFJdn5juDzGs08RSOLKBJOF+/sgW8Gw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5791
X-OriginatorOrg: intel.com

Hi Ilpo and Shuah,

On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:
> Here's v4 series to improve resctrl selftests with generalized test
> framework and rewritten CAT test.
> 
> The series contains following improvements:
> 
> - Excludes shareable bits from CAT test allocation to avoid interference
> - Replaces file "sink" with a volatile variable
> - Alters read pattern to defeat HW prefetcher optimizations
> - Rewrites CAT test to make the CAT test reliable and truly measure
>   if CAT is working or not
> - Introduces generalized test framework making easier to add new tests
> - Lots of other cleanups & refactoring
> 
> This series has been tested across a large number of systems from
> different generations.

Ilpo, thank you very much for this great cleanup and a creating a
reliable CAT test. This work is focused on kernel health and greatly
appreciated.

All patches in this series should have my reviewed-by tag. For
confirmation, for this whole series:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Shuah, could you please consider this series for inclusion at
your convenience?

Thank you very much.

Reinette