Received-SPF: pass (google.com: domain of linux-kernel+bounces-1434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <51821c81-82ef-4b39-a8c5-660a8ee355f0@intel.com>
Date: Fri, 15 Dec 2023 09:40:12 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 07/29] selftests/resctrl: Refactor get_cbm_mask() and
 rename to get_full_cbm()
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Shaopeng
 Tan" <tan.shaopeng@jp.fujitsu.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>
References: <20231215150515.36983-1-ilpo.jarvinen@linux.intel.com>
 <20231215150515.36983-8-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215150515.36983-8-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEFIUEVPcW96SnFnSlZBamRDc0hUcWYwYXhGVkJZNVUrY2VycEFkWDBhZkFN?=
 =?utf-8?B?dnQvSUwyMmZwdjgyeHJVeDhEaFRSYjVjWHh0M2hlWDFlajVUNjZ3QkhKcmZE?=
 =?utf-8?B?cEFKN1UvUVhaTlVlY2F3V29OUUZWTFQ3WkxPaUkrY0c5NTVsZ1RQbzF6VmdP?=
 =?utf-8?B?dVN1MEFWNUJRMWh4aU5kc3pyQXN0OFhNbU82Mm50d2paYUs5RVUyNEhyTndF?=
 =?utf-8?B?V2loSjFvMHlwSEtDdFZVQ3R0WTd2aW1pRStOUmNGSWg4L29tSzFNdFpPRzhy?=
 =?utf-8?B?c1NxTzh2cThTU1I3c3VJeHlseW9Ga3VmRXlOVEpVRFFmeDZlTFZrM3V5ZlJm?=
 =?utf-8?B?dDJMQmN4NDR2TnF0R25EeFh0M1ozSmsvbVlFOVhLRWw0aUdyamNnNjBBbXc3?=
 =?utf-8?B?eUVhSmpkelljeEJUczY2ZU50dlk0Um5pTVk1TnZRNVRmZCtPQWJtVWJuQTJr?=
 =?utf-8?B?VWtBTjZCTHhaMXJKTG1qU3I5bUFldFBRUTZaYXoxYi9Xa3lJK1dFa3ZmSkhY?=
 =?utf-8?B?TG1vSkNyK2IxNWxHdGF1R2paN05lTXVnV2piWlYwdEh1RjVMOTA1TlF6OStu?=
 =?utf-8?B?RU5YdVRQVk4wa3Q5NnFNSWdGejl5OGR3c1p2MkJZMm0wTkRWNHJZQkppRjRO?=
 =?utf-8?B?UHZnaC85UjNvdjhJK0lhcC9KWjV5b2RhYm1XVXNuZ1ZIQ1MxSno0Q3ZDcUNw?=
 =?utf-8?B?NTV2VWlET1B4cFo0NEhGb1Bqb2tpVkx5Q0NQc2Q3VDVMOW51QUh3TTRTQTR1?=
 =?utf-8?B?YXVXRGI0TTRZN0gxNW9xLzFYVUZlTW5ncDZGb1hYVGplWGNkd0tLcjhzblV3?=
 =?utf-8?B?TjBrOWpYcGdtNlpyYThLck8rNkIzNFNTeVdUbElQQWMrZDRuMjhXYmZaTFdz?=
 =?utf-8?B?NEJMM2dJdDVhMDA3YUZTcWNwRDBXTE1mUnFnSndUeDBkNGxvaXprZTBJd3ZK?=
 =?utf-8?B?bWp4cGpBQWhFRHVQSUZ2eU5MZHgweE50MVMzT3V3MWFFdVRlUjA0dVBLRDJ2?=
 =?utf-8?B?dFFNWjNVN29FMGxoT3FsQkdYdGJ2T0xDSzB3VnJwSE16Y3MrMW5rbVMyTjRH?=
 =?utf-8?B?eWxodWdTVER1QVpId3h6Y3VraUpiaTI1ZS82UGdVdHM3NUJGVTVlaWtKdGJ6?=
 =?utf-8?B?bnFDT3llUURBUEllNVZ4ems3MDk3bVF0Y1ZSM0o3NTV1a3dTU0dKRmZXR0FY?=
 =?utf-8?B?RmhZT2FlUmtIUThoOVFrUlBaazZoWEJPZU9kK1QwNlRrc1ZJUmFsMG1oQnRn?=
 =?utf-8?B?em9hbGNrNWErbFpYcXNPMnBmbkU3YVcyOVJJcDlWLy9SckFDbUU0WEVYS1hG?=
 =?utf-8?B?Z3pvSVkzZE84VVVPOXZZeTJjbGR6TGpIZW8yamJJRGkyNkJsU0QxaU94a1hD?=
 =?utf-8?B?RUZuTHlHZnlwSXlJZ1krV0NBZFdxRGFCcDU4d1VZaldhUDd1a1VVQkNFMWg4?=
 =?utf-8?B?azRLZVFqejRBZ2RlN0JnTGhGL1hrTFFmYVhGS1lOR1lGR0dlTmlvbS9DNnBJ?=
 =?utf-8?B?dnNoS1c2Nkl2c0lJRkptckU5MjFmZkgrRWIvMW9lblA0dUdmMHRaNXZwOElQ?=
 =?utf-8?B?N2IyMjE0VDJGWi9UNFM4VjI4MXIxQmk5VmozRnJTRnd6Y29sR3RLNkE5dFlV?=
 =?utf-8?B?bDRwTjB1TDBVcVlGL05kZDhMZ1ljSVVJd0U2SENSUWZaUUpLVlZPYTE4YU81?=
 =?utf-8?B?Q2xiWnUwOXAyM0FhMzhJWFV6K1pSQ3NtLytwU2JUTnVEMzN6c043QXEzNTZq?=
 =?utf-8?B?d2xiZkxhaCs4bTRKWjMvS3NkR2xxc0dkSmxPWVZZVk1senRSalVyeVZ1bEVk?=
 =?utf-8?B?V3RnVklWbHRmSGNiNVFJbWpvMG1UVnoxdDVLazk1RVFlbWExQTAwT1JTT0hz?=
 =?utf-8?B?ZWMwejJ6Y1ZHRTRPMUdoY3Jjd0RTa0J4aXpBdWkvYTNNckszbDIrbTFQMXpI?=
 =?utf-8?B?SVhUUk14YWdOK1NsNGhGdmsvcGNzSEoyeGxyWE9Cb1NFUXdtVkxDdXdkVVlS?=
 =?utf-8?B?NDBQd3NXVnlvVDc4aVgyOVZzaDFocFZtdldubHRrdFBvQ04vYlI5aXYxZjZB?=
 =?utf-8?B?UUltalgxY1o0dk5SNXJOUi9MbjcvUnFpTExna20yUGlGSmlTYWV5K1NpMjRK?=
 =?utf-8?B?RjAyVUFsd0oxdk9OZXFOSC9YVWFnNWNFRnByZlJTckl2M3RQaDNCY0xrYTIy?=
 =?utf-8?B?dHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a6985b44-23d9-482f-d0b7-08dbfd94e423
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 17:40:12.8862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VpygzJBy4unvQObs7uHP3k3wTnoVeCUBbITaDXXNbwOaD8hiwBiyMIXceW01PCYO1p4O1R8tTWgXtq+ICHhDIQQQ1Nsw1NTqz22wvxJLoqs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6722
X-OriginatorOrg: intel.com

Hi Ilpo,

On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:
> Callers of get_cbm_mask() are required to pass a string into which the
> capacity bitmask (CBM) is read. Neither CAT nor CMT tests need the
> bitmask as string but just convert it into an unsigned long value.
> 
> Another limitation is that the bit mask reader can only read
> .../cbm_mask files.
> 
> Generalize the bit mask reading function into get_bit_mask() such that
> it can be used to handle other files besides the .../cbm_mask and
> handles the unsigned long conversion within get_bit_mask() using
> fscanf(). Change get_cbm_mask() to use get_bit_mask() and rename it to
> get_full_cbm() to better indicate what the function does.
> 
> Return error from get_full_cbm() if the bitmask is zero for some reason
> because it makes the code more robust as the selftests naturally assume
> the bitmask has some bits.
> 
> Also mark cache_type const while at it and remove useless comments that
> are related to processing of CBM bits.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette