Received-SPF: pass (google.com: domain of linux-kernel+bounces-1519-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 15 Dec 2023 19:20:32 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: James Clark <james.clark@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org,
	linux-next@vger.kernel.org, will@kernel.org, mark.rutland@arm.com,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2 1/1] arm: perf: Fix ARCH=arm build with GCC
Message-ID: <20231215182032.yainbyffntkqpkye@pengutronix.de>
References: <20231215175648.3397170-1-james.clark@arm.com>
 <20231215175648.3397170-2-james.clark@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="itsdxshq7bgb2hps"
Content-Disposition: inline
In-Reply-To: <20231215175648.3397170-2-james.clark@arm.com>


--itsdxshq7bgb2hps
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 05:56:48PM +0000, James Clark wrote:
> LLVM ignores everything inside the if statement and doesn't generate
> errors, but GCC doesn't ignore it, resulting in the following error:
>=20
>   drivers/perf/arm_pmuv3.c: In function =E2=80=98armv8pmu_write_evtype=E2=
=80=99:
>   include/linux/bits.h:34:29: error: left shift count >=3D width of type =
[-Werror=3Dshift-count-overflow]
>   34 |         (((~UL(0)) - (UL(1) << (l)) + 1) & \
>=20
> Fix it by using GENMASK_ULL which doesn't overflow on arm32 (even though
> the value is never used there).
>=20
> Fixes: 3115ee021bfb ("arm64: perf: Include threshold control fields in PM=
EVTYPER mask")
> Reported-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> Closes: https://lore.kernel.org/linux-arm-kernel/20231215120817.h2f3akgv7=
2zhrtqo@pengutronix.de/
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  include/linux/perf/arm_pmuv3.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/include/linux/perf/arm_pmuv3.h b/include/linux/perf/arm_pmuv=
3.h
> index 0f4d62ef3a9a..46377e134d67 100644
> --- a/include/linux/perf/arm_pmuv3.h
> +++ b/include/linux/perf/arm_pmuv3.h
> @@ -234,8 +234,8 @@
>   * PMXEVTYPER: Event selection reg
>   */
>  #define ARMV8_PMU_EVTYPE_EVENT	GENMASK(15, 0)	/* Mask for EVENT bits */
> -#define ARMV8_PMU_EVTYPE_TH	GENMASK(43, 32)
> -#define ARMV8_PMU_EVTYPE_TC	GENMASK(63, 61)
> +#define ARMV8_PMU_EVTYPE_TH	GENMASK_ULL(43, 32) /* arm64 only */
> +#define ARMV8_PMU_EVTYPE_TC	GENMASK_ULL(63, 61) /* arm64 only */

As expected this fixes compilation on my end, too and it's nicer than
v1.

Reviewed-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--itsdxshq7bgb2hps
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmV8mPAACgkQj4D7WH0S
/k70Nwf/RKlhvu5kU7OLm1mwdjKU6aYfvAZkSBnFv1UIDqNO8kUiqQ1LNc7dYKYT
+fmz88BDDkzJF8QYG73bLrwtn9paSrbPxc6kg24tdp2mH4Fq8FuDH7FuMK1Dd8CW
L9zcHcVt1ymmRmY86UgGxSihpmeXFbqg+dt0R67TiWE/4fGMe2ilVFHtaYpZfE1s
cw0fN2tiFUqbpWu50lokbStcsxkwhZ4RF1OCodVW4vPYUDnYyvLc/P//GS3Er6vn
aVCFZT9WoUom77pG9L0q2f5CmZeUHC0ra2qAnguUvCIja3goldOYe0LKgetBcpK6
PunHLJ35H+n7OoDkZiBm9fedtquNmw==
=E8iy
-----END PGP SIGNATURE-----

--itsdxshq7bgb2hps--