Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6871117rdb; Fri, 15 Dec 2023 10:24:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+rQfWOips0jtGn44apiKl6WTs2trGAzd+ULI9A+OO9slXSmYrPzo5jGpOfOUzgE531sWU X-Received: by 2002:a05:6a20:1388:b0:18c:3729:7867 with SMTP id hn8-20020a056a20138800b0018c37297867mr4874934pzc.21.1702664678665; Fri, 15 Dec 2023 10:24:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702664678; cv=none; d=google.com; s=arc-20160816; b=d4KkaSMDOHBhAp+sOPsh9k2K0psHOBoVCMp1a82BzVAGLOseYG26NQJX3BKZkNcLGz 93gMPfDvAnHga9dE7xFtCgz96td7TZCHfGQ50HCJNVZsFr/Syg7AsT5oVMPWsorIQ57B rNs8i5eTqLhNzYCgFnggGlJG1SA5zZnXUGpE9bkvs+5sgHXlaAcWVEQq3HJbpNfMkwMB oJXfp2QNFMmz/RALkGNmeI+PdhD9G+H1xywlz26GjYFA8mkL6GDQkSGmj9wpYO2x+KPI TD4o8AztmJ9DsjyjoKwT1BUVKvIZZQQ+yslGffdfV5SnV9OHihZsH8g3hGlQr2+RsdWh 2tyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=cWdUXwpzV+VA3O0sS2vlYrQ97X4HVSi9NyhxCaNhYmg=; fh=76/2EbnIhkCye407T3bAmdPmb9vuH/8Af3wrgnfvwCo=; b=PU3s8qdSdELaevnsNUVKmq+LCFGVloqaZz36KeW5l2G8JHBjTNz8zil4Z98KJVWM4j YudV60U5pjpxOE+64FbpnqjRXzHpmJlvihFXrz9E77Hx+GwIyDwb0alvfl69KookdjPx Rq5+pYWlraLOV9UACx+kKnPYeZMShgm/haJpmOyClkKotfeOBNWkqd8h+mSO3nqSGy/A pjYiBxf2umLkUf0iRJUro9CEhVq6seHFjVuK0CFLd/x9FBUDJRoHsYCi3KG1X7bIiYVH KUFi66naRJbH0RkQuKoPStaEgGltzxHyV+Ax1mKi+9TRxhyUpcIuB0roAKqwzNJLZ7Ch mYXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J9zMamcC; spf=pass (google.com: domain of linux-kernel+bounces-1521-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1521-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 23-20020aa79117000000b006cdaa195ea6si13353511pfh.69.2023.12.15.10.24.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 10:24:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1521-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J9zMamcC; spf=pass (google.com: domain of linux-kernel+bounces-1521-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1521-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8B922284017 for ; Fri, 15 Dec 2023 18:24:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E17C73013E; Fri, 15 Dec 2023 18:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="J9zMamcC" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED0F241841; Fri, 15 Dec 2023 18:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BFIDlsE018866; Fri, 15 Dec 2023 18:23:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=cWdUXwpzV+VA3O0sS2vlYrQ97X4HVSi9NyhxCaNhYmg=; b=J9 zMamcCErsQqC16RoQoXhNYjKz5meI4ZW9Tqn95r8kXMnZtNn0E0SGFsH3KML/CkH 5GLm7jFAZzBDGscQLg4NjpXwBaaDxnJh+Cn2HWII4vNWyKIyBqS2HVA1fHx7+X15 3mxPJuMjDjKymGYdGwYCCUxPTEzTMbDBp9BDc48atf7Oh0Erw+CAJphdoJor4JVA HTS3mVMgXFmn33kQExMfaPgrnNvZXOBZ3CG2WiEntlpXRgB29vogr1xAoacffMNZ K40C6mYAsCpJMFdP8NyhtDL9gWwVDRIKc28fQHipCM0VhYMrl9B55aVTpbLA/FBH JWFBmJt/9V7xyc6IBPVA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v0up201k9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Dec 2023 18:23:53 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BFINql3004272 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Dec 2023 18:23:52 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 15 Dec 2023 10:23:51 -0800 Message-ID: Date: Fri, 15 Dec 2023 11:23:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v5 2/2] bus: mhi: host: Drop chan lock before queuing buffers Content-Language: en-US To: Qiang Yu , CC: , , , , References: <1702276972-41296-1-git-send-email-quic_qianyu@quicinc.com> <1702276972-41296-3-git-send-email-quic_qianyu@quicinc.com> From: Jeffrey Hugo In-Reply-To: <1702276972-41296-3-git-send-email-quic_qianyu@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 1_u18HEpdg9l0T19LQ1qzMD5DX3VY7LA X-Proofpoint-ORIG-GUID: 1_u18HEpdg9l0T19LQ1qzMD5DX3VY7LA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=692 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312150129 On 12/10/2023 11:42 PM, Qiang Yu wrote: > Ensure read and write locks for the channel are not taken in succession by > dropping the read lock from parse_xfer_event() such that a callback given > to client can potentially queue buffers and acquire the write lock in that > process. Any queueing of buffers should be done without channel read lock > acquired as it can result in multiple locks and a soft lockup. > > Signed-off-by: Qiang Yu Seems to work fine for AIC100 Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo