Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6931114rdb; Fri, 15 Dec 2023 12:12:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWS5wPcMa+WWW29+DZ13qEMo6g8xfANz5aePuMYGq2WAYR8ZcMVWHiuwmveFg+OyHuoZ0a X-Received: by 2002:a17:907:280f:b0:a1f:4d21:301a with SMTP id eb15-20020a170907280f00b00a1f4d21301amr13195358ejc.13.1702671129082; Fri, 15 Dec 2023 12:12:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702671129; cv=none; d=google.com; s=arc-20160816; b=WGN8B/ntr8xxZzXc+7Ef04cc5cCLJunpI5t/kIvxHOOQFbwHqahtZsrC16foPq0iuv oZHQPkwhcYZ93ABhwTscwpPaVfoYXC4n+sODOX5bVPvNYumwPI0xpjBhvVAoIfxcITLe PguglHNRrAm25K5dWoPGQiL9XDX2SfjFUQHDUBFOleI8+ksyWxcj1YMZBRoi8e5uYP6m q38NWSVZSwh4IOderkxDoBv6kW3oVY7dqSnwFh4XWnIDHFDO1CMRjkQNv9NbjocxyeY+ 8seMd0yZACle6+wt9t+AH5GygMnhBjgODDpcpjsQtIJnxHmzeg5KUD/+ye2MDHp9sv4E vl+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=iWuo/17AnVV2eL2F0kRsj8EINE9372h1+vI87BJPV7s=; fh=timWtHA7UGScEpXk98kbQKGrJEBXaf2Y1JfEnqzAnNI=; b=xl579159LORHeCZ+uyf1t8S7tv4h0AvQ3JK2ATfsTfz9nhCbpi2KeTJpXvhwx8NBNc aQ7fZ6sC83T30kIZ90nlI4pmeTOKb31VPvHb0/JX3ckpUsRtRhyodQOS3bbbElUQ6+F4 D6r5sY8YTe5lFnKWzD1ejY6sZ5uZmgHfYLgspZTx9AxNVSPf0hXnyEgCg6n7GGerXEQV X5Y91PqKa07zxQC5LnhQP3pLRtJs/EkICJ5OHMxPL07z5rFWqUIKUhnuYxr36TkHzCqC 0T9Pp8cI+XcMOOFoMPJkEQ0hydjwySEGA9PUbPl2JBQFa1ITRD+hse7AO0MMYc5eHyMF P32w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=o+JIP3Od; spf=pass (google.com: domain of linux-kernel+bounces-1601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1601-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s5-20020a170906354500b00a1d86e102a9si7794231eja.470.2023.12.15.12.12.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 12:12:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=o+JIP3Od; spf=pass (google.com: domain of linux-kernel+bounces-1601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1601-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2C6161F27DC1 for ; Fri, 15 Dec 2023 20:05:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5C696721F; Fri, 15 Dec 2023 20:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="o+JIP3Od" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240AC563A7; Fri, 15 Dec 2023 20:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=iWuo/17AnVV2eL2F0kRsj8EINE9372h1+vI87BJPV7s=; b=o+JIP3Odm8bEnfQ/co0ItO1vUz FRCFZFMMWJh39c2OJ4pHnnRSXol2eGTQzvKBUoVSfB20fwKFrZA3wKsqZsr2YHyafQXYFUXMn1rHH cOBIOb2YY6Hj+KAdXak5LJb73NiqYrROPbU2EToKFYA674ZKv5LZ6kwO7ouX7viF9OkbnbswbwXrC TBz9oRgmsR+zHSkSbjXKk0DrWRe1fpVRuNRq5Xko8CZ/QKM1AnM7qXh2R85fsPkqeqmLjEAMlH9yx LyW4Nkj0nwO+PgXBVY42quKEd4SYEgBXDxoM1aAg713iRRDworTk/HNRX5qmCjzEQVeuu7roWSeKk +wect5ww==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rEEOV-0038im-ER; Fri, 15 Dec 2023 20:02:47 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH 06/14] bfs: Remove writepage implementation Date: Fri, 15 Dec 2023 20:02:37 +0000 Message-Id: <20231215200245.748418-7-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20231215200245.748418-1-willy@infradead.org> References: <20231215200245.748418-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the filesystem implements migrate_folio and writepages, there is no need for a writepage implementation. Signed-off-by: Matthew Wilcox (Oracle) --- fs/bfs/file.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/bfs/file.c b/fs/bfs/file.c index adc2230079c6..a778411574a9 100644 --- a/fs/bfs/file.c +++ b/fs/bfs/file.c @@ -11,6 +11,7 @@ */ #include +#include #include #include "bfs.h" @@ -150,9 +151,10 @@ static int bfs_get_block(struct inode *inode, sector_t block, return err; } -static int bfs_writepage(struct page *page, struct writeback_control *wbc) +static int bfs_writepages(struct address_space *mapping, + struct writeback_control *wbc) { - return block_write_full_page(page, bfs_get_block, wbc); + return mpage_writepages(mapping, wbc, bfs_get_block); } static int bfs_read_folio(struct file *file, struct folio *folio) @@ -190,9 +192,10 @@ const struct address_space_operations bfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = bfs_read_folio, - .writepage = bfs_writepage, + .writepages = bfs_writepages, .write_begin = bfs_write_begin, .write_end = generic_write_end, + .migrate_folio = buffer_migrate_folio, .bmap = bfs_bmap, }; -- 2.42.0