Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6932354rdb; Fri, 15 Dec 2023 12:14:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHPYdIfLL4LX8HoPmI1z+STYLEfERlwN3HNRcVnh9V29KcIhnGKT9Zn5pFDr9k00nQ7pGC X-Received: by 2002:a05:6359:6c8a:b0:170:6d2d:2eac with SMTP id td10-20020a0563596c8a00b001706d2d2eacmr9451735rwb.59.1702671269034; Fri, 15 Dec 2023 12:14:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702671268; cv=none; d=google.com; s=arc-20160816; b=hP1ydoFDkQ0c5SLGPEwPoe17HIrMXhU7hBEKaEvLlXT3498iQp3BK0O1qMPM1xaN6D /ukrPfQOt6d5F56G6qXHS3ZS+KxXeW++ST1hffhzDTi+QR38zbQIIlydyOLh9/Oh96mG IRNSUaVwaaTNL5rwV96+XRT2GtwpxgEndr1Li5mkX80LVU3HpJfLYu1Z2kgISLWrwELd Jlkh0J838Imo0+ybydi2/baU0wKNYAp/zS7ar30UZuyA7ay/Nx9ntAAru0Rcugxx9NYP d9QXyuqeW+dHOKpqCdCU5J1h6gup3E4jw2g9d6Sf0dh/Ju5N8qOtMWdSiEzZN8A1ssY8 d6Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=h/m/ubY/K1ZdLR6hCbBi+7ePQUK5r4QCjij0zKQvyNA=; fh=timWtHA7UGScEpXk98kbQKGrJEBXaf2Y1JfEnqzAnNI=; b=Hshwri+hvDcvvB9pZwPb+7a7qxk24+nVdSx+gPGIxufFkwxewrxHbB9GztehY8Fgnt Nqczo8pm0SYdFGyMJ2VZm4NYFtw6svSqSY9eU6kLQ18a07oqLPZHfWgTn1vnZbANW6wy bkl71obeMkt55M3QsDyyzlI/7OYzh+Qe153nIoPBOLnURtI2/BPFauNbQDQD3C1sIKC0 KGJLHsYYOJwJtWCwfy6oD6oFVeohdc8OzvfED5nM6kZzJDBYq1RKESe9K2RgpRfF/Y0f xgUiWdXHyworEfxaC3CF4IfFaZgWmnXn1sqFmpRO3vAJtQLYz71G+LaXaWh58rATWY5H 0u1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OGngCJBo; spf=pass (google.com: domain of linux-kernel+bounces-1605-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1605-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l7-20020a632507000000b005c623a19e63si13239637pgl.721.2023.12.15.12.14.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 12:14:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1605-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OGngCJBo; spf=pass (google.com: domain of linux-kernel+bounces-1605-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1605-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9F037287DFC for ; Fri, 15 Dec 2023 20:08:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E5326A004; Fri, 15 Dec 2023 20:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OGngCJBo" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24122563AC; Fri, 15 Dec 2023 20:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=h/m/ubY/K1ZdLR6hCbBi+7ePQUK5r4QCjij0zKQvyNA=; b=OGngCJBoPBlEI+RqZXEcVMjqRl Qs0RtPBChjAntMDeQuzdkssVP8YWEwS0ct376855NHwDMuflJICChxLuWjQ7+KEUFLcnPdSVLe6qu xlcTvlR3XwWm/xBXcNYrKtsqr27sJQh3SK0z+Zg4xfOWbfrjkqvISl40ERmV/4lghTZqFIY7xLZqV 9GrrPM1pNuw2V1zm7x5pHi+0erxePu3LhUl6aN8ArUcB3R7WGi0jeEE2pYlH5u0WVZ6QoTzEg4MWB Wyzd4bRJusV/elmO8cspKm2yyXbwjm1zgoyZjuzIMdau2klbXbAoPmhbixT+VNmAVIm7TzUbjUrH9 nH5uEX9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rEEOV-0038id-AP; Fri, 15 Dec 2023 20:02:47 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH 05/14] adfs: Remove writepage implementation Date: Fri, 15 Dec 2023 20:02:36 +0000 Message-Id: <20231215200245.748418-6-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20231215200245.748418-1-willy@infradead.org> References: <20231215200245.748418-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the filesystem implements migrate_folio and writepages, there is no need for a writepage implementation. Signed-off-by: Matthew Wilcox (Oracle) --- fs/adfs/inode.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fs/adfs/inode.c b/fs/adfs/inode.c index 3081edb09e46..a183e213a4a5 100644 --- a/fs/adfs/inode.c +++ b/fs/adfs/inode.c @@ -5,6 +5,7 @@ * Copyright (C) 1997-1999 Russell King */ #include +#include #include #include "adfs.h" @@ -33,9 +34,10 @@ adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh, return 0; } -static int adfs_writepage(struct page *page, struct writeback_control *wbc) +static int adfs_writepages(struct address_space *mapping, + struct writeback_control *wbc) { - return block_write_full_page(page, adfs_get_block, wbc); + return mpage_writepages(mapping, wbc, adfs_get_block); } static int adfs_read_folio(struct file *file, struct folio *folio) @@ -76,10 +78,11 @@ static const struct address_space_operations adfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = adfs_read_folio, - .writepage = adfs_writepage, + .writepages = adfs_writepages, .write_begin = adfs_write_begin, .write_end = generic_write_end, - .bmap = _adfs_bmap + .migrate_folio = buffer_migrate_folio, + .bmap = _adfs_bmap, }; /* -- 2.42.0