Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754979AbXLGEwV (ORCPT ); Thu, 6 Dec 2007 23:52:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752970AbXLGEwF (ORCPT ); Thu, 6 Dec 2007 23:52:05 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:51003 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbXLGEwE (ORCPT ); Thu, 6 Dec 2007 23:52:04 -0500 Subject: Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage From: David Woodhouse To: "Eric W. Biederman" Cc: Linus Torvalds , Andrew Morton , "Rafael J. Wysocki" , Pavel Machek , kernel list , netdev , Pavel Emelyanov In-Reply-To: References: <20071119191000.GA1560@elf.ucw.cz> <200711192304.25087.rjw@sisk.pl> <4743026B.2020907@openvz.org> Content-Type: text/plain Date: Fri, 07 Dec 2007 04:51:37 +0000 Message-Id: <1197003097.13978.557.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 (2.12.1-3.fc8.dwmw2.1) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 40 On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: > Well I clearly goofed when I added the initial network namespace support > for /proc/net. Currently things work but there are odd details visible > to user space, even when we have a single network namespace. > > Since we do not cache proc_dir_entry dentries at the moment we can > just modify ->lookup to return a different directory inode depending > on the network namespace of the process looking at /proc/net, replacing > the current technique of using a magic and fragile follow_link method. > > To accomplish that this patch: > - introduces a shadow_proc method to allow different dentries to > be returned from proc_lookup. > - Removes the old /proc/net follow_link magic > - Fixes a weakness in our not caching of proc generic dentries. > > As shadow_proc uses a task struct to decided which dentry to return we > can go back later and fix the proc generic caching without modifying any code that > uses the shadow_proc method. > > Signed-off-by: Eric W. Biederman > --- > fs/proc/generic.c | 12 ++++++- > fs/proc/proc_net.c | 86 +++-------------------------------------------- > include/linux/proc_fs.h | 3 ++ > 3 files changed, 19 insertions(+), 82 deletions(-) (commit 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416) This seems to have broken the use of /proc/bus/usb as a mountpoint. It always appears empty now, whatever's supposed to be mounted there. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/