Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6954530rdb; Fri, 15 Dec 2023 13:02:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlmZdZDvMMw9TR4hPxnt2ly6rtgYTmzPHyZSyh7Z3PO9FBpVGsouG1+k++GC8mkhDv8MyA X-Received: by 2002:a05:6808:148a:b0:3b9:dba9:d2c2 with SMTP id e10-20020a056808148a00b003b9dba9d2c2mr15305677oiw.57.1702674144819; Fri, 15 Dec 2023 13:02:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702674144; cv=none; d=google.com; s=arc-20160816; b=KZPnaTQDJFyN3vIfdxJ4OSfdkjcxV/N9PD5hWEAprh4FiTb64nKb2otCdhUOOPmIge kKRvDOX5UdkZ2YRyjMMbXNiw8oJfR/KPmpwF9jX/IA9GVsXL2UyU/M5UD4CIfOo9N1TH bkVF0vwMprKpdkRz7T4rQVKiDdKWV5v2cwXD3+iXGFTLT5HK6VCLdgkhTfxp+Hz1qfaH Fr0eyFWqir8SOm+IDJ82DUDl4RRQRYMkKgLlD2VIF2b0Wp2p+R86X+rJu9HxZjqCt+dl WEOaLMTcxGQQec5c+dp+rVyt12eMkBx9St1DCPSEPHPSUumF01B7pZjfDcJy/k2Q+cqd epjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=MTDZCEFmSpT07ZfLz7vZkizeT1MqLax9S/t8QTl1d0Y=; fh=56PpeFD0eMhU2LV2e2Eo33XANc7+SAoczsG7exjftHg=; b=g5zVa8iM640odPKggNsspF4hUkEGg36pRoRioRSNyZTBiiPBTeVZtTzltO673IgZkm IgruQv69bMbSxwkz3RzgmhsQylec4jAlhDY3xQ7ZzQSAiS2EhhT+VNhD4CWGuSGZpW5l ry19+PyoLeEtRnzUY2e0Cfud5j1I04AcbAFyBAY+Mkf1WpVt4eEuulU2/Tim7d5F3bjJ vUm20SbAPyEPUySoRa6tGX/ltpmxmNEySFfTq4ttcZ9ThVWatPU2cyriSlfnjWxp0apH kdzHrlfLzgAQ4V3PCp+sdno2wjUXs3TauAINsGSygx0qprs3ePtBla5KN1EQShhaGTMa hPSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MGySH0OO; spf=pass (google.com: domain of linux-kernel+bounces-1649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1649-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n22-20020a0561023ed600b0046615d17103si3222694vsv.746.2023.12.15.13.02.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 13:02:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MGySH0OO; spf=pass (google.com: domain of linux-kernel+bounces-1649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1649-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 820F01C232E7 for ; Fri, 15 Dec 2023 21:02:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7334947F41; Fri, 15 Dec 2023 21:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MGySH0OO" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC9447772 for ; Fri, 15 Dec 2023 21:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5e266e8d39eso10385147b3.1 for ; Fri, 15 Dec 2023 13:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702674135; x=1703278935; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MTDZCEFmSpT07ZfLz7vZkizeT1MqLax9S/t8QTl1d0Y=; b=MGySH0OOMUNqrEQTGPCH+XoWVEmJdxkS8rLTZ6L2p/hOhN1bwyZqChJfpZhdJZ7s/H 3LY8bpnXViu521lOEVFvQWnN1sllD7upoTCwM+DYbmtz6I1W08RraW6y4rJg0wdtyjWF bKv5+HcBa5OtL+9c027CsEh7ijhbO09o5QhSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702674135; x=1703278935; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MTDZCEFmSpT07ZfLz7vZkizeT1MqLax9S/t8QTl1d0Y=; b=YFX7znyomS8SAPR8qmQ0VV1+l8WfOf+/l9AvXhLV5vgYZ34YypCTDim7X7Az2IhLhe 9LzK0QjhvtvbGDi81EztjXnSdA5jZKhx5WGJ0ZjlEVCeKyPwVL9DLVMzCioD/jn9pPr0 ZbpeqHiBnva5tz8rF06mmWB+/o2yTca1tXjFzdhSuSqHitqIXfo+Mf3L8kvsPGTSv0KI 7CNx1c3xP7YPu6PzM3VAYGCUbs0DGhKC0OGHyH1DbU0+ue/hIYUNp1cCsAF8zJb3SFYi i+cyFTrhGSKJ69Gq/QX2PAJ2qhe0hKMlNPcecr4YJIgMX/4rA/JGsDycEUo3D8xuNNYS 7W9g== X-Gm-Message-State: AOJu0YyKG4tmdwshYV9zPijs3wtdR47TlWLxiV7CLit/GY9gDh6VMVOp 5fUlK9wCmNC8OO8Agr1QOiXl9ZxUhTrkxGmSD10ORA== X-Received: by 2002:a0d:c482:0:b0:5d7:1941:2c3c with SMTP id g124-20020a0dc482000000b005d719412c3cmr8885843ywd.105.1702674135254; Fri, 15 Dec 2023 13:02:15 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid> <20231213110009.v1.6.Ieee574a0e94fbaae01fd6883ffe2ceeb98d7df28@changeid> In-Reply-To: From: Mark Hasemeyer Date: Fri, 15 Dec 2023 14:02:04 -0700 Message-ID: Subject: Re: [PATCH v1 6/6] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq To: Tzung-Bi Shih Cc: LKML , Raul Rangel , Benson Leung , Bhanu Prakash Maiya , Chen-Yu Tsai , Guenter Roeck , Prashant Malani , Rob Barnes , chrome-platform@lists.linux.dev Content-Type: text/plain; charset="UTF-8" > It looks to me the patch combines multiple changes. Please separate them into > smaller pieces for reviewing easier. Unfortunately, I don't see an easy way to break up this commit without breaking EC wake functionality along the way. > Another confusing about the patch subject: "6/6"? Is it a series? I don't > see the cover letter. Sorry about that! I'll make sure to add a cover letter and CC you on the next series version.