Received-SPF: pass (google.com: domain of linux-kernel+bounces-1732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Received-SPF: Pass (protection.outlook.com: domain of opensynergy.com
 designates 217.66.60.4 as permitted sender) receiver=protection.outlook.com;
 client-ip=217.66.60.4; helo=SR-MAIL-03.open-synergy.com; pr=C
From: Peter Hilber <peter.hilber@opensynergy.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Hilber <peter.hilber@opensynergy.com>,
	"D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	jstultz@google.com,
	giometti@enneenne.com,
	corbet@lwn.net,
	andriy.shevchenko@linux.intel.com,
	"Dong, Eddie" <eddie.dong@intel.com>,
	"Hall, Christopher S" <christopher.s.hall@intel.com>,
	Marc Zyngier <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Richard Cochran <richardcochran@gmail.com>,
	kvm@vger.kernel.org,
	netdev@vger.kernel.org,
	Stephen Boyd <sboyd@kernel.org>
Subject: [RFC PATCH v2 0/7] treewide: Use clocksource id for get_device_system_crosststamp()
Date: Fri, 15 Dec 2023 23:06:05 +0100
Message-Id: <20231215220612.173603-1-peter.hilber@opensynergy.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 22:06:31.7321
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c9f8e431-5ab2-4816-d457-08dbfdba1867
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=800fae25-9b1b-4edc-993d-c939c4e84a64;Ip=[217.66.60.4];Helo=[SR-MAIL-03.open-synergy.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB8EUR05FT046.eop-eur05.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR3P281MB1614
X-TM-AS-ERS: 104.47.7.168-0.0.0.0
X-TMASE-Version: StarCloud-1.3-9.1.1015-28060.002
X-TMASE-Result: 10--7.044400-4.000000
X-TMASE-MatchedRID: KBpjYDzav4OUP+0hdpOx0lmcWIT2GKzJi9V1e7G8XUijN1SoAtAGxtsH
	8mvO8CBHCRqqhJm8rIn5mjPOVI6+s/oKZK4fc4pdc6MQph12+/qgn19QHAlOzICpIfHsTRJvaQX
	O0KwCdXrdTrmsiWLAxD3Dhol2PU5Lmbpduk4zUf/BcAkkfZSxiKJDaGSlxWd0nFPS5wCjpHZ01t
	kgbj61ndpXJMrozGW3YpESvCL4it1Y7t9efcoDgBY+KkMeQFa+ifMOGvxuFI/ksZ3zvFw4d9MBf
	XdbvQpitKCRYZK7Rz5nTzlpJasG9DWKJWzdd27zFNCHhVgQN+RF82F/3Qm0nzB4jJltGVDbLN5w
	GPX3TPXYeXOEzfM22ez1ZBVjJwp/DeUZOJCXHMgMHb/7t/XFB6JYuGaIjh0/IOKWWMbJYW1HjTo
	zLyxgvg4Fzev3p4hIwM0DNfudA4D90bqmL8lIO3PngqD95asR
X-TMASE-XGENCLOUD: c8459977-1676-496e-a985-fa28a5a45d09-0-0-200-0
X-TM-Deliver-Signature: E7EE09502309D7E1DDBA639E64FB9010
X-TM-Addin-Auth: NGr+b3azPpS3/Zeb0aqcby3cr4qWfbpHOOylJ0ffizsQXN2xoOM9FP24F//
	S2Y8DSUO8qDV7rA1UMox0zrZRtF6huNVVfoCBEMI7DOskjye8jV5DJMgYVqfVvhtIO4OZRC5fF8
	5+OmvRIHtOK3oPdmWywNr3F5721WrL/l7pSRRTw/x+Iw+n5fVmwoLBj8ttKjtUmKKduV2/o9IBJ
	A9+8rag0Eff/Ga2QeVdwepXq9mFfyDrpYaILbyDBppknlo5VFJQQNqksJaF8So61dirRg6hQ7OR
	R1rIS1AnzTFeS2E=.mcgyROZTglXZnihSqlUEHXD5imG+ruOwFkZiSILJsbXSPt1P9GoG+yw3Hm
	8Cu8tJZHwveLF5k7AMMS7XUKpEeWU7kc7odnJkmk6FM/AXKChuBsmYK8Yw3NScxtoR1c8nJBw9b
	/d2WwHkv8bawcpqT7LjDV43vU2WpONUGuD8vO0eejHCNidVvZ4S628BrEcqPYC0h8ZGnZ9p94Vl
	bxdAMBw1mi4RdNZjki4J3w8EDSFURZtfcYv2BD3JQqGhLt1pZxEf+xLByXSZ3yeHzjz/tnRfp1A
	aLzSiE/RX5w01/ercq777t3rsSDehzZzkEB99/1OICTpBIg/zCcdS2O24bg==
X-TM-Addin-ProductCode: EMS
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opensynergy.com;
	s=TM-DKIM-20210503141657; t=1702677996;
	bh=fNjbMei4ZWHGq/zEoYBHmdHxSKAaRDbd9h90JPhEwTU=; l=4561;
	h=From:To:Date;
	b=O1XlcfNmz/P0Wr/aCaggb/jVdmLZM5OVq4WpvJV8Kv1KQiZidHvBhlFuc+vMc5kEZ
	 IA9elnN5Wc4B54JlEE2jJ2pDx5p2n2uOQOPw40stPwUZfYg98gPxNd5xmYNp558cr+
	 EVlZnUw6LDI5xxEjgoSRMy6UGDUdUTDFh/crgFO5weKzZa4s3bBRwjjTqkWKFDLxQc
	 ZX+tuSi80hCxdbQLXlcJZWyKLLjXpS3yig8zd18qLlZXV0FRClFvebquQMe1cyg2VT
	 iVRSJ5prPvxf0JisQrHq9wfwUhSAGx0dTRJZ8qjWXUBM26lmIbGa3fnz/TN0A5YGQN
	 uhllv7Edf8XLA==

Overview
--------

This patch series changes struct system_counterval_t to identify the
clocksource through enum clocksource_ids, rather than through struct
clocksource *. The net effect of the patch series is that
get_device_system_crosststamp() callers can supply clocksource ids instead
of clocksource pointers. The pointers can be problematic to get hold of.

The series is also available at

	https://github.com/OpenSynergy/linux clocksource-id-for-xtstamp-v2

Motivation
----------

The immediate motivation for this patch series is to enable the virtio_rtc
RFC driver (v2 cf. [1], v3 to be published after this series) to refer to
the Arm Generic Timer clocksource without requiring new helper functions in
the arm_arch_timer driver. Other future get_device_system_crosststamp()
users may profit from this change as well.

Clocksource structs are normally private to clocksource drivers. Therefore,
get_device_system_crosststamp() callers require that clocksource drivers
expose the clocksource of interest in some way.

Drivers such as virtio_rtc could obtain all information for calling
get_device_system_crosststamp() from their bound device, except for
clocksource identification. Often, such drivers' only direct relation with
the clocksource driver is clocksource identification. So using the
clocksource enum, rather than obtaining pointers in a clocksource driver
specific way, would reduce the coupling between the
get_device_system_crosststamp() callers and clocksource drivers.

Affected Code
-------------

This series modifies code which is relevant to
get_device_system_crosststamp(), in timekeeping, ptp/kvm, x86/kvm, and
x86/tsc.

There are two sorts of get_device_system_crosststamp() callers in the
current kernel:

1) On Intel platforms, some PTP hardware clocks, and the HDA controller,
obtain the clocksource pointer for get_device_system_crosststamp() using
convert_art_to_tsc() or convert_art_ns_to_tsc() from arch/x86.

2) The ptp_kvm driver uses kvm_arch_ptp_get_crosststamp(), which is
implemented for platforms with kvm_clock (x86) or arm_arch_timer.
Amongst other things, kvm_arch_ptp_get_crosststamp() returns a clocksource
pointer. The Arm implementation is in the arm_arch_timer driver.

Changes
-------

The series does the following:

- add clocksource id to the get_device_system_crosststamp() param type

- add required clocksource ids and set them in
  get_device_system_crosststamp() users

- evaluate clocksource id in get_device_system_crosststamp(), rather than
  clocksource pointer

- remove now obsolete clocksource pointer field and related code

This series should not alter any behavior. Out of the existing
get_device_system_crosststamp() users, only ptp_kvm has been tested (on
x86-64 and arm64). This series is a prerequisite for the virtio_rtc driver
(of which RFC v3 is to be posted).

v2:

- Align existing changes with sketch [2] by Thomas Gleixner (omitting
  additional clocksource base changes from [2]).

- Add follow-up improvements in ptp_kvm and kvmclock.

- Split patches differently (Thomas Gleixner).

- Refer to clocksource IDs as such in comments (Thomas Gleixner).

- Update comments which were still referring to clocksource pointers.

[1] https://lore.kernel.org/all/20230818012014.212155-1-peter.hilber@opensynergy.com/
[2] https://lore.kernel.org/lkml/87lec15i4b.ffs@tglx/


Peter Hilber (7):
  timekeeping: Add clocksource ID to struct system_counterval_t
  x86/tsc: Add clocksource ID, set system_counterval_t.cs_id
  x86/kvm, ptp/kvm: Add clocksource ID, set system_counterval_t.cs_id
  ptp/kvm, arm_arch_timer: Set system_counterval_t.cs_id to constant
  timekeeping: Evaluate system_counterval_t.cs_id instead of .cs
  treewide: Remove system_counterval_t.cs, which is never read
  kvmclock: Unexport kvmclock clocksource

 arch/x86/include/asm/kvmclock.h      |  2 --
 arch/x86/kernel/kvmclock.c           |  5 +++--
 arch/x86/kernel/tsc.c                | 29 +++++++++++++++++-----------
 drivers/clocksource/arm_arch_timer.c |  6 +++---
 drivers/ptp/ptp_kvm_common.c         | 10 +++++-----
 drivers/ptp/ptp_kvm_x86.c            |  4 ++--
 include/linux/clocksource_ids.h      |  3 +++
 include/linux/ptp_kvm.h              |  4 ++--
 include/linux/timekeeping.h          | 10 ++++++----
 kernel/time/timekeeping.c            |  9 +++++----
 10 files changed, 47 insertions(+), 35 deletions(-)


base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
-- 
2.40.1