Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp7019744rdb; Fri, 15 Dec 2023 15:30:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9fyX+3GEDCD9aN2lo8KIBW7ke0yGbP4QgOQqfs4F+ZPAmH0p5OpSsuIT7clNBqtVdp5// X-Received: by 2002:a05:6870:d0c6:b0:203:4dfc:7eea with SMTP id k6-20020a056870d0c600b002034dfc7eeamr3498687oaa.83.1702683016939; Fri, 15 Dec 2023 15:30:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702683016; cv=none; d=google.com; s=arc-20160816; b=CdLKHWejs8C+YrIY2w3v8zfU9I4Tnc9qVZtjqi8JXgNbhhcI7PA9DHTX/SmKL+Kxh/ kTNkKrXBdtYxXdNRagxH0eXZB/QzAQhT6rw4Q2DbxiJgkmHyK30mS+j3RV/Q9jPyYxdH clflYCC9XvrkiX9ogp5Oyf19/rHsJToeO3S1stDIR1uMDE+gg3QM2mssP8LS2dsNkBs4 Z0nspLg8klGlZga3hR0Tlroh4L+sI/rfDEhCymb8n+OiUY+owHyJV98NnWumlWcrAcfP Y7Kf/ogiCKn9Er4mrIO4sZhGO70gUozv1g+trTpOKdbkyRTtmYv3PwnJxxWaOiM4ScI+ I+JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=u6kJztnhe/3aZlpo9pIougEjAVG2pXtlFDhjZ2imK8A=; fh=Hh3no7HBdIBJ75jl3DeW8gwY+yltQdIZBvUGF0a78fY=; b=nd3qsPssWbhnm71j7qykNdRhHeIFKw5YrRIwKq1mq74Vewnbty9rOOzywbpvJ/IzcG mjyaYiIumTeXv0vGeCse/xOj/JKFr8hhAN6cmKjL68Z3XsEVDliE+Up54qf6Q2b28/D/ Z4b3Rlql2meMCUkv7YjWtR7EiDEDf2v7CODVn8AW+BjQSyXKHz6RBiH3Jja3siONlE3W ZzPLmchIkdBlyBXSbdVVh/6p2Z+G/0x/bSvNn5/LZq/PS8EFFSo4ADq3C9gOO66qEPdu vcrUTMb3gui/yf2lhJ67FHTvgrnmG7O7dpa6xiguqiFyY2F9HcRji6ResDoCL8XS8Xra 6tiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HA9ELnLX; spf=pass (google.com: domain of linux-kernel+bounces-1822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1822-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s2-20020a63f042000000b005c65c11ad09si13774212pgj.768.2023.12.15.15.30.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 15:30:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HA9ELnLX; spf=pass (google.com: domain of linux-kernel+bounces-1822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1822-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 93541281FFE for ; Fri, 15 Dec 2023 23:30:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB92F18ECD; Fri, 15 Dec 2023 23:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HA9ELnLX" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 680AD18ECE for ; Fri, 15 Dec 2023 23:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a1ca24776c3so437591066b.0 for ; Fri, 15 Dec 2023 15:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702683006; x=1703287806; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=u6kJztnhe/3aZlpo9pIougEjAVG2pXtlFDhjZ2imK8A=; b=HA9ELnLXM76d7oJ1VLMo0rpbMRfVVp7641FnyV9fHbvJc/Sli9LC2AzWiTcE8sABVc jAzN1jSmI9woG4DCvamM0kCeQ1WZVWu11/+lztGJTFFs9mZTuuEQJ1ftDRsyiTThyxx+ YAXa9r6us1ma1ai9wP1vRNOZcTUMZCnx3uc4m0WgxYWYhfAQ9tIZa8X2tturuzF2ek5W 9+Bi1eIZHRAkGWYRpv9I3zT3i+JsXxf+17Xg7zBUfwf2Iwg7wh5YDJT21wkvBQ/sOmD0 Agu6QxvuRmI/ahNnuSM3urMacWJyTZW2bYtI/I6aj7AWyFSEk9ziMsx7+zLLdEa0VKFm gD/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702683006; x=1703287806; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u6kJztnhe/3aZlpo9pIougEjAVG2pXtlFDhjZ2imK8A=; b=WmX0jrKheQmun7sNnLl74QsxCUS2LFqVZX+D2dVmeNh/NMEo08tTczwAOdAPzsukeV do9yw7eDdZhGoOeq4ygiXgoqVc737oVWsCAxD6yFk3vCxJ/OTZvbu4wHob5V6Sn7Sfvg j8yH78R3ltTMn3BWBZXLkQ34PqDsVlO7vbNojEshTHe/Seu4e5F/pS5ofv6OBl9ty9lZ UgUzm+DGIdfZCvJaCDVBmvyqoNw6XS4smyzMSFzjfusEEnRs16gMQ07u3yx9TZZlCYbF cSMiZuNlYQgbEWo2vAF/3qDcj6QibKxVBEEQe2OFjbuPLfgUIFTvLv5SGSfjtMeSUhXG Cnxg== X-Gm-Message-State: AOJu0Ywce48C5ljkgyQ7xsZCnjV+cHHWjFytWLsN258rkaWLEvb5elzs Ygjdqq/fJV/rEcjg2EW9Udvkzw== X-Received: by 2002:a17:906:af04:b0:a22:e827:fb7b with SMTP id lx4-20020a170906af0400b00a22e827fb7bmr7253559ejb.23.1702683006561; Fri, 15 Dec 2023 15:30:06 -0800 (PST) Received: from [192.168.199.59] (178235179137.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.137]) by smtp.gmail.com with ESMTPSA id qo5-20020a170907874500b00a1b7b0cc30dsm11218955ejc.7.2023.12.15.15.30.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 15:30:06 -0800 (PST) Message-ID: <37ab347b-2d94-42a9-97d0-274ed8a4c791@linaro.org> Date: Sat, 16 Dec 2023 00:30:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/18] perf: qcom_l2: Convert to platform remove callback returning void To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Will Deacon , Mark Rutland Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 15.12.2023 14:59, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Konrad Dybcio Konrad