Received-SPF: pass (google.com: domain of linux-kernel+bounces-1824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231214151458.28970-1-gouhao@uniontech.com>
In-Reply-To: <20231214151458.28970-1-gouhao@uniontech.com>
From: Song Liu <song@kernel.org>
Date: Fri, 15 Dec 2023 15:31:04 -0800
Message-ID: <CAPhsuW5Oj67XR6EhndSXCkd52h8P4nAXipxrhG31fy7YNOZg6g@mail.gmail.com>
Subject: Re: [PATCH] md/raid1: remove unnecessary null checking
To: Gou Hao <gouhao@uniontech.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, 
	gouhaojake@163.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 14, 2023 at 7:15=E2=80=AFAM Gou Hao <gouhao@uniontech.com> wrot=
e:
>
> If %__GFP_DIRECT_RECLAIM is set then bio_alloc_bioset will always
> be able to allocate a bio. See comment of bio_alloc_bioset.
>
> Signed-off-by: Gou Hao <gouhao@uniontech.com>

Applied to md-next. Thanks!

Song

> ---
>  drivers/md/raid1.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 35d12948e0a9..e77dc95d4a75 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1126,8 +1126,6 @@ static void alloc_behind_master_bio(struct r1bio *r=
1_bio,
>
>         behind_bio =3D bio_alloc_bioset(NULL, vcnt, 0, GFP_NOIO,
>                                       &r1_bio->mddev->bio_set);
> -       if (!behind_bio)
> -               return;
>
>         /* discard op, we don't support writezero/writesame yet */
>         if (!bio_has_data(bio)) {
> --
> 2.34.1
>
>