Received-SPF: pass (google.com: domain of linux-kernel+bounces-1834-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a110877e-2b5c-40c6-9128-2f4d6e205f39@intel.com>
Date: Fri, 15 Dec 2023 15:45:14 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 00/29] selftests/resctrl: CAT test improvements &
 generalized test framework
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Shaopeng
 Tan" <tan.shaopeng@jp.fujitsu.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>
References: <20231215150515.36983-1-ilpo.jarvinen@linux.intel.com>
 <056a2d2b-3b09-4a70-92b0-8634a24464b9@intel.com>
In-Reply-To: <056a2d2b-3b09-4a70-92b0-8634a24464b9@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?biszSXY3L0dKZzRzdVJ0VXBJT0VBeWZrcUREandKeWYwRjNKUHRTa3VLeDRG?=
 =?utf-8?B?R3FVbVFWVldvakVHaSt4Qm1yRzVuRnFCbTkzeEZKTnY0aEdSTEFuTElOTEhJ?=
 =?utf-8?B?WVRYTzVlQVQrR1F6U0k0MHhjTDRWN2VBUitHOXJ4VDArbllPV0ZnWnY2a1JX?=
 =?utf-8?B?cURUZkRFOUgrSXYyWVFJWUNEMGRKSjNkVG5kVWpsRkt4ZDE5RWprYllqc0Jn?=
 =?utf-8?B?VmNCMWI0cVdwT0dPTitvTmRoNTJ4WW5LakVtRnRRdC9ncWU4MUp6SVVpWGU3?=
 =?utf-8?B?OUg0ZmZodnN4akhweVRQTHVURlNnQ1Yzd2NpUEZwd0k0Z1hJdldQVjZVYi81?=
 =?utf-8?B?cmRuR2tpYWkxaGtHYzFRcmRzZ0huZ0Y0MUV0V1cwbVVwUk9FRm56b1N3aHhN?=
 =?utf-8?B?ZzJqbXBvWnBrUTdaaGdnNzFvakdGamNjbHdmSW0rNTdWUVcrMkJ2WEphLzhK?=
 =?utf-8?B?Zyt3S1BycVhsT2pjUmZEaE5HYVZPb1lBdGZsT2FVQXFNSXB4VWlMMVlWa1Mx?=
 =?utf-8?B?bUpiblpRZmJic1FTdjVxMEI5cmtMeHhYUlFTNDRmSFB1c1VXU3RMSlhHNGxH?=
 =?utf-8?B?dndxT2srRDdXaUx0SytibmVLcE9UTjBjNzBqYllnb1JMNnJab0prZGhMMU1P?=
 =?utf-8?B?R2R2a1JvamkzVHVyMTJRV1ViN1pnSndWL3hlNVh1ckNBYnJvRnpUY2FYa2dO?=
 =?utf-8?B?K0pOMCtWbEcrMzJTSFpFaWhIUTBINWQzMkRKbHh0Q3RaOGMxV00zZzkxMldo?=
 =?utf-8?B?ZHJXWXlRQ2V0cWM5cXB6SVo1dTJWa0Y5czNuTEtaOU84eGs3THVMM1BIM3V3?=
 =?utf-8?B?WWNJUm1GVkZMNTErbTR6Ri8yZ0kyMXRRSTVvUHl5T3BvQVkybWNuV1hzVTdR?=
 =?utf-8?B?eUNqM0ZBS0FNRDNDallwQXpub3U2T1pweXkwSmg0bDdCQnA5ZVp3bUsxWHlP?=
 =?utf-8?B?YVVVY0NvUFcxSkVqSnBFTG84K0FVNUZkeW1zMlczYW45TDV6UlFTRHh5dVk1?=
 =?utf-8?B?SEdUQ3kwVFA1NlVza0NoZUp5MThhZ2pjUkVMQThVSTF3UnRMeFp1QVIxUFFL?=
 =?utf-8?B?WGlwaGQ0cm9jWERmV0dzMjJhN0N6eFhTb3JTTjVad3F2TWVZK0dQOUFHYU5P?=
 =?utf-8?B?d0J5NXo2SmVtMjJHR3RXM0g3TVNTb3huLzZqUE0rZUNWYTJoaTJONi9nUEJD?=
 =?utf-8?B?VnpLU1k5d0g1MFpNSFY2ZFZJdkFBR2FUN1NxOXlXdG5oYnlxRXBFcEJRczZ2?=
 =?utf-8?B?RUo1Rll5S1llcDNKVVJwUG5RTlJtWGxLZWZQa0ZnNUxLZktxN2ZDOVgrTnZi?=
 =?utf-8?B?T3hOYWVweDM0amlSbStFZ0FsT0RiaFFzUnVZdmZsc3E5Zmd6aC9uRVFhb1ZO?=
 =?utf-8?B?VFM5UEJBUEFMSkdNQmFjMEpCdG1BbWZaOW9hcG9wSHFHalZleVBPNVMvT2c5?=
 =?utf-8?B?RkIyQzR1dE1DL2NsUDBlZ0dCdWdZek1VMDlVTGh3RTl3ZjJlWUJLQUx1WE1h?=
 =?utf-8?B?Q2VrUzlLc1l4K29OVm5ZQW1uTmdCSFJrK3R6aitqNm9tVThoWlhKZEI3UzRa?=
 =?utf-8?B?YjJ5eGJrSmx3Ryt1dTl0UVVSNHZjdFo2cGwwU0E0dXFrM2tKRm9EeExQY3h2?=
 =?utf-8?B?Z2VrSFp3bmFlUk9ZL2pIVDJodjFlbEROMUp1a2NJaVpMZnVmK3pTN0dCV0Fo?=
 =?utf-8?B?THhBRGNpaVh1WlRSSGxhanExYUEzUUtCRndkMkV0T3J6UHVhVU9nWlc0VkdE?=
 =?utf-8?B?MjhINDBacFk3akxKL2lzTldOZWJVakJiTStOQm1qUzFxd0dBbzVsWHNGbFUy?=
 =?utf-8?B?K0xodmJ5ZjR0L2J6UTVLWXZhc0w3ejM5bDROUUFQdEdBVE1yV1ZUeVpsZGh2?=
 =?utf-8?B?RnJwdFRBdEh6QS9ndHE5ZytaK0NJRFpqOGtFWFNCbG1oRmVRUFJXak5JUnNi?=
 =?utf-8?B?QXRyQkxTdXpuaWJtdWFGNkZVQlZYdVVFL1l5bUdNN1RIRjI3ZElSTGVRZGYw?=
 =?utf-8?B?V3BQM3RFVm5FNW9aNEZQb1lqMDV1cjZWaVZLK3pzdGFQL2JGS2t3bE5SYjB4?=
 =?utf-8?B?MHlQMDZjbjNvakNaSFRxb0Z2TklYWGtiV1ZSb1RNMDJvTGEvS0ZXT3BwNXBj?=
 =?utf-8?B?Tmh3RHlMZnVkVkdpVkVuYVByNjE2dUd3SGkvR3oxZEVsc1FZYjZoU3VjbWU3?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a6d2b22-a6b6-4011-4d73-08dbfdc7e3ac
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 23:45:16.6426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lsnCT7hAWP2qsiwYfYKLpcQ5+pM8coPwaJg8cTl9L1PkAHuM9D33nJFDlWm4jOUCX4VvzNgLPGEN908BLtu6qS1trHv1alh1mOOP1FJCTBo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7393
X-OriginatorOrg: intel.com


On 12/15/2023 9:45 AM, Reinette Chatre wrote:
> Hi Ilpo and Shuah,
> 
> On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:
>> Here's v4 series to improve resctrl selftests with generalized test
>> framework and rewritten CAT test.
>>
>> The series contains following improvements:
>>
>> - Excludes shareable bits from CAT test allocation to avoid interference
>> - Replaces file "sink" with a volatile variable
>> - Alters read pattern to defeat HW prefetcher optimizations
>> - Rewrites CAT test to make the CAT test reliable and truly measure
>>   if CAT is working or not
>> - Introduces generalized test framework making easier to add new tests
>> - Lots of other cleanups & refactoring
>>
>> This series has been tested across a large number of systems from
>> different generations.
> 
> Ilpo, thank you very much for this great cleanup and a creating a
> reliable CAT test. This work is focused on kernel health and greatly
> appreciated.
> 
> All patches in this series should have my reviewed-by tag. For
> confirmation, for this whole series:
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> 
> Shuah, could you please consider this series for inclusion at
> your convenience?

Just in case somebody tries this series out against kernel v6.7-rc5 ...

A problematic perf patch made it into v6.7-rc5 (v6.7-rc4 and before are fine).
When testing this series against kernel v6.7-rc5 the splat reported at [1]
is triggered. A perf fix [2] is already queued up so all will be fine when testing
this series against a kernel with [2] merged.

Reinette


[1] https://lore.kernel.org/lkml/20231214000620.3081018-1-lucas.demarchi@intel.com/
[2] https://lore.kernel.org/lkml/20231215112450.3972309-1-mark.rutland@arm.com/