Received-SPF: pass (google.com: domain of linux-kernel+bounces-1930-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9ac4a3aa-602a-4bc9-aa73-c6896effefe3@huawei.com>
Date: Sat, 16 Dec 2023 09:37:04 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <shenjian15@huawei.com>,
	<wangjie125@huawei.com>, <liuyonglong@huawei.com>, <lanhao@huawei.com>,
	<wangpeiyang1@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on
 ras mod
To: Simon Horman <horms@kernel.org>
References: <20231214141135.613485-1-shaojijie@huawei.com>
 <20231214141135.613485-3-shaojijie@huawei.com>
 <20231215080104.GV5817@kernel.org>
From: Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <20231215080104.GV5817@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


on 2023/12/15 16:01, Simon Horman wrote:
> On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
>>   #include "hclge_main.h"
>> +#include "hclge_debugfs.h"
> Hi Jijie Shao and Peiyang Wang,
>
> hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.
>
> With the above include added, these constants are now also defined
> in files that include hclge_err.h. Which leads to them
> being defined but unused in hclge_main.c.
>
> At a glance, it seems that these constants are only used in hclge_debugfs.c.
> Perhaps they could simply be moved there?
>
Yeah, I also plan to move them to hclge_debugfs.c.
So I'm going to add a patch to the v3 patchset to move them

Thanks,
Jijie