Received-SPF: pass (google.com: domain of linux-kernel+bounces-1939-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] platform/x86: wmi: Remove unused variable in address space handler
Date: Sat, 16 Dec 2023 02:55:56 +0100
Message-Id: <20231216015601.395118-2-W_Armin@gmx.de>
In-Reply-To: <20231216015601.395118-1-W_Armin@gmx.de>
References: <20231216015601.395118-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:g6TJpMyVtzg=;8NJD8ZkcZbvWcPGjTdnCYAfn48e
 rS/yojc3meuqmvJ5oso+pp5CEd9xvsTzahRVyRzmg949loKL46jyAcNCZI5ImHrGZKmXUswtv
 BwY23woQqcu1Uqm87Pzi8gfgrqdymGcCdNudKJxPW/+tKW02ZgfJOaFJxxCvr/ueTZuLoiKug
 /vuc8B7amK/VtZngUoqt+TmBDPbQ4MDc4DdsiYe2vT3oLWhJHgSCtJ176knmVXVF5kI5t75xp
 DGsOWLfA9XH5uDqIxO3UvN9k132jmxzQ/ZzQPwIxfPxIK18SyvCMDcle4fExUCdws3hQNY7Ze
 RM1+m3PLYeLm8ma7XGzx6DDcUR3XayOmfnkUIjNHU/WD00JKI7SJ3bfmypl2vST4bXYtIRd2V
 8wZ+yaRLUNrMD61NIFenRs1KPdNEOxGmn+zFnvWLOYn2LAwIj9mz4u1lKHdQHfP03uE3KUbiS
 WyV51xWuM0POH4BOpsBcmPA2C7mzgp21VPf2NnN6cQwwK3CqSDru291Zz2qJycLe7JkLLiiiG
 V/LcFOZYgNLi11OPsIZ6o1+aJRPfOqkY5iGgtusibw/VmKKsJuisg8hJGAM8P9Xzso1sgdNMR
 BqRRuRGPE725kooFahxDm8nHFXKWkojFYTq5fGsrk4I5bvX0mzE7Cdm1/WFUYNNv+3YWObtLk
 T/NdslgPL8YNrH5e0s8CrIikPzu5CSj1w6yrBCOvrZpnz6nFwRdLi/Q0rSKrJ9KywJRe/5PWA
 Mxb3jVHaK/v8xVGN+zePFUsR8VMZ3ZZUBkO2FoOi01JbHcVEvKWM9av+63+MEI+2rJLjj179M
 A16yZHI969PbnXwd7DZXHVnhwACLNnCaqW5yG7/SQop7IXrouOltIQJVty4fxzYnzupUlsGJJ
 EFY0JmZ4OLy02346Xbz8yPUXGnPwifm3f+QAAPIslQr21+Dd1B74cTVAYJmoXxkAdB+luyOV3
 Q8aXwqqSRlozaFZ4MPrQ5WXHpN8=

The variable "i" is always zero and only used in shift operations.
Remove it to make the code more readable.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/wmi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 7303702290e5..906d3a2831ae 100644
=2D-- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1144,7 +1144,7 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physica=
l_address address,
 			  u32 bits, u64 *value,
 			  void *handler_context, void *region_context)
 {
-	int result =3D 0, i =3D 0;
+	int result =3D 0;
 	u8 temp =3D 0;

 	if ((address > 0xFF) || !value)
@@ -1158,9 +1158,9 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physica=
l_address address,

 	if (function =3D=3D ACPI_READ) {
 		result =3D ec_read(address, &temp);
-		(*value) |=3D ((u64)temp) << i;
+		*value =3D temp;
 	} else {
-		temp =3D 0xff & ((*value) >> i);
+		temp =3D 0xff & *value;
 		result =3D ec_write(address, temp);
 	}

=2D-
2.39.2