Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp7102786rdb; Fri, 15 Dec 2023 19:23:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjVnyeOax69h5sBOFpXXGRX0Gw1t+CFzcXBYi3LqN/s2nWSeBt6iY7cVaLYHwUjWWye7HT X-Received: by 2002:a05:6808:3196:b0:3ba:231:cd43 with SMTP id cd22-20020a056808319600b003ba0231cd43mr12727921oib.94.1702697037048; Fri, 15 Dec 2023 19:23:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702697037; cv=none; d=google.com; s=arc-20160816; b=IV2Aq5hlmhIgbXgHTUlWbGxsuXVcyKwSWbzZCei5gMC0nzlqN+jtnDFx5PeLqInaA5 MKjr8Uf8Z9kI+EfpMirGlRQown/dZ/pw6LioSrDiVQdPqqe+UQRM910EB3a8cbZQa15z JvTLlG/aySOI4OPMddmC41q9is8Rv4c1meT8WDdhMSEU/mrD+Rvs5P+FLgxnuGJ7yabY I3OJ3maHRZiA1lFnA2lopeTBZGwVJ1o08OemgqHnEuhPNcyAcfy7mvOIdrEI0KBvLJPQ eOiou0dJBWgtdApEHq225Lll0qZa9sUgqaCw025/smjH18GP5JjBm6YUBJ+v7374iuzw lREA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zvGx6PP/uRDz9dSF69qI0IfQy2mDB445jARJru4hM9E=; fh=iae8W7+YsuOdP40WCytoCMmYg2BD/IEWEocE6dbe21o=; b=FElwAsuZbNuVnsPZojArVWCkFVPHxkUTFI1mTGxSC66C6vvQWTZ89ReikanbdB5AM6 YzdXUhuRmA7ORsTguo8gFtOTYHVNevAohnULOr2tMlzpjj4hCYdQclj3ssFfdJDGGz8C LX1YAjEYxn5Z5Mb5Z/iVw7RD4cUs/+pmrdcTlqznzuHzoERbfqLpx6P6v60T+kYGgeyR mqEhR1HWgwhL7gECwCTbLZvjCkYiQqt2x3p+RRF1SuIKGRN0rNtZeKzlQFjgFdwFU5NF jwe8jLEeE2ndBPk6tJ1vvE10zlOmhGIuyi5vBGLIpc+6gFEMHydiRjMx+GxKg9hFvfhE 9UBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=thEZbMM8; spf=pass (google.com: domain of linux-kernel+bounces-1984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1984-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bw32-20020a056a0204a000b005c663eae37fsi14180151pgb.295.2023.12.15.19.23.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 19:23:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=thEZbMM8; spf=pass (google.com: domain of linux-kernel+bounces-1984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1984-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 90208285FB9 for ; Sat, 16 Dec 2023 03:23:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 98F6E1FDA; Sat, 16 Dec 2023 03:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="thEZbMM8" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7491C2E for ; Sat, 16 Dec 2023 03:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zvGx6PP/uRDz9dSF69qI0IfQy2mDB445jARJru4hM9E=; b=thEZbMM8tE+gqTe19eS8twWfyo DJxfdx8KapmltVHgpYmGeZSKu7GOkrrnsKXmRJABYAxLagjkJgj6DWGt0dxj0c/on8NPg9nw6xPEa rYhWCDqs1qes9uYU54zK5usRZYl8kdfQIHg+ptO1VgSoYFlXNV/KVJAgva2N6bDByrinhcvLO0gSk /CFBnVJWP2k0lavnekQ5reH6FuGjNAXuMazGaW5CSTxa4PpZquYyljbUAsjpFDNOQIGLurIH5XVdQ jYyKwx9V7oboYwNjzLDtWdTFVAOmPE3RHhfQGYm5WaCFYTk9k9gB1HcC6SBrKZcmg/PO09M+0pEMJ T19p/LCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rELHB-0067r7-7f; Sat, 16 Dec 2023 03:23:41 +0000 Date: Sat, 16 Dec 2023 03:23:41 +0000 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: Simplify __free_pages_ok() Message-ID: References: <20231216030503.2126130-1-yajun.deng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216030503.2126130-1-yajun.deng@linux.dev> On Sat, Dec 16, 2023 at 11:05:03AM +0800, Yajun Deng wrote: > There is redundant code in __free_pages_ok(). Use free_one_page() > simplify it. > > Signed-off-by: Yajun Deng Reviewed-by: Matthew Wilcox (Oracle)