Received: by 2002:a05:7412:8d23:b0:f7:29d7:fb05 with SMTP id bj35csp9416rdb; Fri, 15 Dec 2023 20:28:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHq+AzIE9URxxIsUI3DRh4cjbBzYDPBpHDpQj5HmYW8uXfz4AMEBntOaegh0JHTYQQgVMQr X-Received: by 2002:a05:620a:3604:b0:77f:9540:56ac with SMTP id da4-20020a05620a360400b0077f954056acmr5746871qkb.16.1702700894089; Fri, 15 Dec 2023 20:28:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702700894; cv=none; d=google.com; s=arc-20160816; b=hsWoTJzArY/yGqpIk73/VZEyD/MepJWTU58oU2YFncnSX5e/oMwNU5QDqxH44pHs0t goOYGVXRJO3BfMXHR5Ydb6S8QcT9XHqBQsOh2LGP1YfjXp+GF++AXyfNYsbSvtgRpx1Z BN2HSDx5Nt5AtwN7RVe1KTk/JTuzpfJKjoR9dP/5bVJ/vL5IsqlJUciE4lE4hu8dBjlG xURtq7Jfd1+wmQAgxGIkoW+AGvwZLFfVwwB1SbH/ymrGeAtiTwJEeMsIPC8uaZzE8pp4 rsnQt3CJGfFy5uwYQkbzTPdh3+Rbu33MoFXDMj4uMvQhEhBRwNzpJwXEWa1HXv2n8TLI OMlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=a27Q3qOXK5v8jMnK/cFsYwoe5NUrJkRbFoVPY7U1Ig0=; fh=sZiEiD2fSHk+vUFwkUJd9PbdBDETSDhzPH1FyEFE5Xg=; b=DDz8EIAm0csPb+m72mgBUptGd9QbFS5a1H0swEryPzdL38KsSInxbX/Kl2Rm8Mcaik VFvV8rsIrirWoBn2xmUwOqjWE1lRF9Our9ICEmfeuK83DqOvXPgnk84OHJEUvlXM+Zau yOME84NUCBsIsYc3CMPhZcHt0c7hvtH+1MS/PckqSL7Xj9dtGTSe/MNbiPAfkwuOZKhx oTJ68vXF3Wa9/LZhJmH37hzDQftn8pQvrvCetPNKTfHCWtOV34yIB+ws24BYkfCyxPTi 5mwfC5P/t4/U/73A12xO3VKzRDBPpJn4qFjFuUnvjhL59HLr7DqeZnx+PoO+AN1BWSuS TDGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2061-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2061-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s3-20020a05620a29c300b007759f94721asi17234673qkp.209.2023.12.15.20.28.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 20:28:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2061-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2061-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2061-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D4DA61C247FF for ; Sat, 16 Dec 2023 04:28:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5859314A88; Sat, 16 Dec 2023 04:27:37 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E230013FF8; Sat, 16 Dec 2023 04:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C266968B05; Sat, 16 Dec 2023 05:27:31 +0100 (CET) Date: Sat, 16 Dec 2023 05:27:31 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 02/14] fs: Convert clean_buffers() to take a folio Message-ID: <20231216042731.GB9284@lst.de> References: <20231215200245.748418-1-willy@infradead.org> <20231215200245.748418-3-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215200245.748418-3-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 15, 2023 at 08:02:33PM +0000, Matthew Wilcox (Oracle) wrote: > The only caller already has a folio, so pass it in and use it throughout. > Saves two calls to compound_head(). Looks good: Reviewed-by: Christoph Hellwig