Received: by 2002:a05:7412:8d23:b0:f7:29d7:fb05 with SMTP id bj35csp9502rdb; Fri, 15 Dec 2023 20:28:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAMzIYw8ajm3tbp9IcsRXKlIsi1yjK2zi/bjOejWwRlV9JWpoGWBWklKUhhIrXJpwm9AeD X-Received: by 2002:ac8:5881:0:b0:41e:acf3:37f2 with SMTP id t1-20020ac85881000000b0041eacf337f2mr12322689qta.23.1702700909823; Fri, 15 Dec 2023 20:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702700909; cv=none; d=google.com; s=arc-20160816; b=rYx/X7GPXc4IP7TslTUDa0T9aJzfjtVkflWvlHR1zfry3EdTc/GNjMZi+Xb6ANz7l1 mPu709G/Ww+uBhPb0Ue6HHI6fkTGuF+oHhEHk9GKw7ilh52Ry+2I3MoTd1FdPzGRDTfk p1qu79pFQJQCrr20S+0k677dQ4u1W0lHhqhlJhD+TCmPnSLR8ESaCtRD9BM+rCsL0VCP tSIaTVRIuOS7lZLBrR43Cv93fjVWCOuXyYLHhT7GgGBlM9yknFvageTtevLg/C5fBDbU ORcebJiAeOw7/PDvivWW24LCi5JH8w1XU3rG8/ebIZ0Lw7Z30s+xDFo6R8z7qV1rbn83 A+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=qbPixjqMdYslzfmrhXMxSH3bQWLr5UG0Y1lVy7ic9p8=; fh=IMATOKwrBuyx3eHJHxl4QLsVkzBX6eVdGuRR13hIDtU=; b=VuVHPIK/77083KqbbKNpHcbz1WceQZNAhu7IF4dirRsiItSTPLtQwB/QyLLe0Z7a/4 AVFUuPXKuI6xoMPFF5KPsHWGas3E3/vlJsotRYMOUbzj8kwVhDhve7Yb8AsWKgyeWq59 /y58fT12WZKCvLTWGokiSkJMMAu+riMOYM/Aqjd5vhaHlxscd63BuWQpsxEg1W/Co0fy ZN26Q2D/JhT3PFkPwOCqRLvYYVKCbenYSJrgn/LN30SOqBGfVsDyJmvO9RfbsG3JfYZh ArizF1JSGA2GcjvZdoZ/MqWSxs55uhWpcwDjn6t5EZt8GlXHot7+0p3288FfHJGC3irG Zxyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iWqrv6tR; spf=pass (google.com: domain of linux-kernel+bounces-2062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w4-20020ac87e84000000b00425c1e87b6bsi15002205qtj.487.2023.12.15.20.28.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 20:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iWqrv6tR; spf=pass (google.com: domain of linux-kernel+bounces-2062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9437C1C245F5 for ; Sat, 16 Dec 2023 04:28:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E25D410A31; Sat, 16 Dec 2023 04:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iWqrv6tR" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF1818EA0; Sat, 16 Dec 2023 04:27:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DD19C433C8; Sat, 16 Dec 2023 04:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702700876; bh=qbPixjqMdYslzfmrhXMxSH3bQWLr5UG0Y1lVy7ic9p8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=iWqrv6tRNmkJEzGLIY1HXibt0a3ionwOxz5W+nQK3A7TFPum1b4wpMbrF8din/Db2 bJxXCZIBAwihpdrVF7PpSPoMyw79OHNHfODVEVGmOoegvMzbDvDyp1w8l7773Mt8tY HVPA4CHTeyTt1Ru2mJSjKk6ZyJN55uN16NrnzNWlv6xSDljrzIhVXRpKeLW3zhnz5Y nbgCmH1bP12CLTTrXW929U9vSV/oAqSRbcZPhJG9DRN7oC0vB74n3GFNpSwyeVoyZ2 OHX1HePEVIb/FelUbidZQ6yvXUoYV0tQlDL7CZe8Pb/6kFvyu0bXgEmFJoyCtA8+4b C3QaVbXLwKx+g== Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-20364459774so821579fac.2; Fri, 15 Dec 2023 20:27:56 -0800 (PST) X-Gm-Message-State: AOJu0Ywqa6UJgUKbt6h3EpbYxmBmF68kga5VNTHn5EHVU8ZoUy2KslUM 8S5eZ5nV2Xsb9wfdJS9kIgT/QOiFogle2QaRQRs= X-Received: by 2002:a05:6870:56a3:b0:203:7b73:64dd with SMTP id p35-20020a05687056a300b002037b7364ddmr1781512oao.104.1702700875761; Fri, 15 Dec 2023 20:27:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received: by 2002:ac9:7f88:0:b0:507:5de0:116e with HTTP; Fri, 15 Dec 2023 20:27:54 -0800 (PST) In-Reply-To: <20231216032814.10560-1-rdunlap@infradead.org> References: <20231216032814.10560-1-rdunlap@infradead.org> From: Namjae Jeon Date: Sat, 16 Dec 2023 13:27:54 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ksmbd: vfs: fix all kernel-doc warnings To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Steve French , Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" 2023-12-16 12:28 GMT+09:00, Randy Dunlap : > Fix all kernel-doc warnings in vfs.c: > > vfs.c:54: warning: Function parameter or member 'parent' not described in > 'ksmbd_vfs_lock_parent' > vfs.c:54: warning: Function parameter or member 'child' not described in > 'ksmbd_vfs_lock_parent' > vfs.c:54: warning: No description found for return value of > 'ksmbd_vfs_lock_parent' > vfs.c:372: warning: Function parameter or member 'fp' not described in > 'ksmbd_vfs_read' > vfs.c:372: warning: Excess function parameter 'fid' description in > 'ksmbd_vfs_read' > vfs.c:489: warning: Function parameter or member 'fp' not described in > 'ksmbd_vfs_write' > vfs.c:489: warning: Excess function parameter 'fid' description in > 'ksmbd_vfs_write' > vfs.c:555: warning: Function parameter or member 'path' not described in > 'ksmbd_vfs_getattr' > vfs.c:555: warning: Function parameter or member 'stat' not described in > 'ksmbd_vfs_getattr' > vfs.c:555: warning: Excess function parameter 'work' description in > 'ksmbd_vfs_getattr' > vfs.c:555: warning: Excess function parameter 'fid' description in > 'ksmbd_vfs_getattr' > vfs.c:555: warning: Excess function parameter 'attrs' description in > 'ksmbd_vfs_getattr' > vfs.c:572: warning: Function parameter or member 'p_id' not described in > 'ksmbd_vfs_fsync' > vfs.c:595: warning: Function parameter or member 'work' not described in > 'ksmbd_vfs_remove_file' > vfs.c:595: warning: Function parameter or member 'path' not described in > 'ksmbd_vfs_remove_file' > vfs.c:595: warning: Excess function parameter 'name' description in > 'ksmbd_vfs_remove_file' > vfs.c:633: warning: Function parameter or member 'work' not described in > 'ksmbd_vfs_link' > vfs.c:805: warning: Function parameter or member 'fp' not described in > 'ksmbd_vfs_truncate' > vfs.c:805: warning: Excess function parameter 'fid' description in > 'ksmbd_vfs_truncate' > vfs.c:846: warning: Excess function parameter 'size' description in > 'ksmbd_vfs_listxattr' > vfs.c:953: warning: Function parameter or member 'option' not described in > 'ksmbd_vfs_set_fadvise' > vfs.c:953: warning: Excess function parameter 'options' description in > 'ksmbd_vfs_set_fadvise' > vfs.c:1167: warning: Function parameter or member 'um' not described in > 'ksmbd_vfs_lookup_in_dir' > vfs.c:1203: warning: Function parameter or member 'work' not described in > 'ksmbd_vfs_kern_path_locked' > vfs.c:1641: warning: No description found for return value of > 'ksmbd_vfs_init_kstat' > > Signed-off-by: Randy Dunlap > Cc: Namjae Jeon > Cc: Steve French > Cc: Sergey Senozhatsky > Cc: Tom Talpey > Cc: linux-cifs@vger.kernel.org Acked-by: Namjae Jeon Applied it to #ksmbd-for-next-next. Thanks for your patch!