Received: by 2002:a05:7412:8d23:b0:f7:29d7:fb05 with SMTP id bj35csp11480rdb; Fri, 15 Dec 2023 20:35:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IECxCCYCFzTY41ODh2/nL7yzno6igPjePbrJjKQIcidQY92MFIPQuvC2iaqPpAH2AIN4IpT X-Received: by 2002:a05:622a:164f:b0:425:8c37:ce7d with SMTP id y15-20020a05622a164f00b004258c37ce7dmr17252918qtj.40.1702701334596; Fri, 15 Dec 2023 20:35:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702701334; cv=none; d=google.com; s=arc-20160816; b=yO0dvCt55mYHtO/vXypHpAHLkZnZ7HngHzJWW6G8KlJrwYr2KOwc4OjiBOG7GPtocU seae8G/PswJNwP5q/bnJ708ODa2Bp1z6JcDvwd5uHHBgTPTzWTLpsyF7q9Hp4mR4x/RR Y5KBj1jiBcJdafgUegSAPdCn26kTS/rWu0ZY3h7WOIybyawQJoe6u71IZ5SVLrKWKk+1 cJIeIXqlpMzo1jixfpx7D5nuTYRnkzJiEwZRjfw7ypW3EcKYOtwAnU+IEx11lT+P2ls6 Lzv3Q7B84fUjSZiigf0B/8xZO9BobhYUNSKHc6UVJE/JjUjzSNTFIMaSmGrbx2zojxOn tF5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=tOICM9/N+wPvdWYHvPDa4TysZ6CNrQgv3KgZjTUpdLk=; fh=sZiEiD2fSHk+vUFwkUJd9PbdBDETSDhzPH1FyEFE5Xg=; b=oNeIb17Ncg/B1xmmuNUgPG7xpzky88PZ5ROe+vhWrMKgn2ny2AKFvvP+B6PBTRVg4N AZtietQTyolFTyJKcf7SYuN/w8zeLyOMiBL0PksEP+JZstTNrWp/MikzPkUnbiQGiKmH quV/Y+aANYQ9Lmxt+dLN8fr9/jnZ0EXiRazg4f80kHhYQDCS0RQrtH/KrGsrMunvaKl+ t0G0T9NCAB72ZQfgzehlafVoc9ASdtyI/gJJI9sXV8w/oU3EXeeivdnaJyMg9Jxg165H jMHK+PLgKZ739lUMzPVyfK6+BSRCPkudgA055Ps3CPZ4Nc2UToE8TiiWlcR8svRkFyXd +1Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2072-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id jd8-20020a05622a718800b00425431045a6si21444933qtb.666.2023.12.15.20.35.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 20:35:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2072-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5CE2D1C21522 for ; Sat, 16 Dec 2023 04:35:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0D32134AD; Sat, 16 Dec 2023 04:35:19 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1125A11C97; Sat, 16 Dec 2023 04:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id D96A468B05; Sat, 16 Dec 2023 05:35:14 +0100 (CET) Date: Sat, 16 Dec 2023 05:35:14 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 13/14] fs: Convert block_write_full_page to block_write_full_folio Message-ID: <20231216043514.GI9284@lst.de> References: <20231215200245.748418-1-willy@infradead.org> <20231215200245.748418-14-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215200245.748418-14-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 15, 2023 at 08:02:44PM +0000, Matthew Wilcox (Oracle) wrote: > Convert the function to be compatible with writepage_t so that it > can be passed to write_cache_pages() by blkdev. This removes a call > to compound_head(). We can also remove the function export as both > callers are built-in. Looks good: Reviewed-by: Christoph Hellwig