Received-SPF: pass (google.com: domain of linux-kernel+bounces-2081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0072e1fe-7c4e-4bd2-a1d9-24c2161d14d6@intel.com>
Date: Fri, 15 Dec 2023 20:58:16 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 06/24] x86/resctrl: Access per-rmid structures by index
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20231215174343.13872-1-james.morse@arm.com>
 <20231215174343.13872-7-james.morse@arm.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215174343.13872-7-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a01mMnBLbzRSdFVaMmY5RTA1eld6NFg1d1A0ZW1GNWV6VGpRTGI2MndEWmJo?=
 =?utf-8?B?YllsREFubTdmSVFiOVVFWFp5SHF5T0lrR0t2MUp2K3MzZzRTcXA0dG9VL2xq?=
 =?utf-8?B?b01QR29JdmlzdTBJRnFWTnRZV3hmcU5qeWdWanRZV3NVUVlpSnpjVWlWZTFp?=
 =?utf-8?B?KzNUN3hrK3FvejJEbjB4a2o2OXAxN1lidEVFN0VjU3lXYzZHSFB1WjFyTjV5?=
 =?utf-8?B?RDh6S1l6dytEQkxXSVFiQjNRWmNLejNCdWRlT0c0UFl5UXN1b2tXYm1CQjFM?=
 =?utf-8?B?RmZsRkIvbi9VMTNYT21HYmNGZlVWMStnSVBpKzdydFJzM2hFWEVxMmhYZ3lJ?=
 =?utf-8?B?R3NXZU9lTWtpZWVZbFEraXZ0ZjVBSER0Y2JDQXRMK3ZLY1pocEQ0TFJCMWRO?=
 =?utf-8?B?a3FFTDdsSHNRTml0aU1JZVBPNDlLSVZLV0pXTjlEWHk1R013R3dZQ1NpSFRm?=
 =?utf-8?B?NTd5K0dlRjdZTlJ4ZjE2QmJ4ckxwUzBpUzYvU1NtcS9ad3AvVXNlU0p0NXBR?=
 =?utf-8?B?U2RuN004TTF3c2d5N1pvUEZyaWgwN0c2cjhzYXpkTmVlZjFtUWZVTVZ2VVNT?=
 =?utf-8?B?L0xnSFU5cGN6VzM5M0hMcnpobHRFVXlxakNraDA3VnI2ajhTM05pWHNhOXZi?=
 =?utf-8?B?SFk4Slg2L1AvakhkcEtHQVd5eERFd0dLdGR5Uk9OV3lkZjBVano1Qi9BUFdt?=
 =?utf-8?B?YmIwQjVLVk52Mlhxb1BTWk5NZVNocEhOMktoU0liMzcrMEtYUWxpVkpyMGFu?=
 =?utf-8?B?UG5NUGpaeTYwbDA3OXBEZWc2ZW9pMVhrSFdiZjZ1TkpVcFlOZCt1N2hYMElu?=
 =?utf-8?B?R291YU1LUTZXRkJ3TUZtNnFpeFEzMzVWQjZqdkZxZ1dIUXRWS2N0dSt6cTZD?=
 =?utf-8?B?R1VJU3gyNUZTekVkSXRyS3VIYVRZVGE4aUtRWWt0RDBMVy9FdnN0dW00MFJt?=
 =?utf-8?B?RTlXaWpKd3VyRkx3TXZEZUJxWjV4V2RnOVVBeWNSM1Z3Q2M5NjhyZHNOa3pX?=
 =?utf-8?B?eFNKSEZ3ZVRHNHdjSjJ4U3N4QVNWL3JVeUR1RVJUS0xMejhyYzUzRFFJYXZH?=
 =?utf-8?B?OUl0dmx0N2E1Y09jLzhaZXVvYkM3SFlEWFVlMmxkb0oySndwakl3anhDeCtx?=
 =?utf-8?B?Tjd0TnV3bFZueGkxak1WR0lYcHBOSU5tUmFRajc2QURTQktpZHg1OWpaS09Q?=
 =?utf-8?B?czRVS0c0ZW81RXg5Q0VvOUNQZFFrQjlzQ0U1WHlJZmYxcVFRL2haTWF6d0dW?=
 =?utf-8?B?c1E0TG1NNDZGOUtPSVVsL3ZOdUlGQUhFT1RHRkZlWnBvVVliY1RramtvRG9t?=
 =?utf-8?B?K3d3bFlkblVqWW1raWlpU3pjZnZPOXQ0a1gxYWRVZWZWRk1NV1RuTjZHaDRH?=
 =?utf-8?B?Y0g0bVkvVXNOd1VPN3hadUlxNzlDUnJENzZrMUdyQWJVRkorTDF4Z3FJVzcy?=
 =?utf-8?B?c2tFSE9PblUrQlZwNTB0cGpQQmZ5ajFrVHlSRzNxeEg0THpzc2tZQTUxaHE5?=
 =?utf-8?B?aSsyWUlMbm4xUTIxWmcycW4vbERjblp2d1ZWa1lWVTZvQzV1UnJ5VHE0bzRa?=
 =?utf-8?B?bXhRcEl6aFZBUmJzUkVBcjNQbWlobkE1NVVndyt5TzlhK21nWkZRS25SaUxU?=
 =?utf-8?B?ZDFETGtVcm5NRHc2ZnpOLzMyeFplZHZGNDgvNkZYSFVSbkJTTHkwZW9xeXdD?=
 =?utf-8?B?ZWJha1cyQlc5QzAzYUZMeEIrczN0NXYzZ0FjbXFKcDFOaWU4RnVVcVdFSDRV?=
 =?utf-8?B?YmlhMHNqVU9FTDU4WDVRNnNlZ1loYzZ2eDZzZFNDQ1dpQkh4RWlJM0tHZ0FE?=
 =?utf-8?B?Q0FKeDM4QThwaGMxVlMxTm1NMEowdCtSbWc2WUtoZ2JiM0k0ZWdYaGx2M1FD?=
 =?utf-8?B?VUQyQUdMTG0yOGM5Nmxody9YVDBYVTZPaGpGMXEzZnBoTE1jVTQ0TWQ5YVgv?=
 =?utf-8?B?ZWpyYUVlRzdicmtOeURreWVFaUhTZEp6T1FJbnp4TGtSSG1mVEgrVkV6cHZz?=
 =?utf-8?B?OWF1bk00aklsNUl5b21id29UUDFXUDZibm5XVTZrZzZlTzN4QW12R1Q2NXky?=
 =?utf-8?B?MXlqUlowdU5xUWpvQXBSblZ3MlRPcXVxVnBYNjZUYkx5VlI0NmdaVXAxTUJF?=
 =?utf-8?B?NmozeXExWlphMEMrU0xhSHpMRFp2SWRsaXFGNS9BRHBvd1loTmgzN1hydkZ1?=
 =?utf-8?B?SVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca665e8a-5202-46fe-a80e-08dbfdf39e66
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2023 04:58:18.0492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bl0rlxiEQurMTIdnejGbyxOyWSXmZdKaVQHKDuspwaXqvcnpo2NexkglA39897eHY/aWUGw4u/WGIvIPiqZc+GjUsQrb+IF4zBJK67SNp2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6147
X-OriginatorOrg: intel.com

Hi James,

On 12/15/2023 9:43 AM, James Morse wrote:
> x86 systems identify traffic using the CLOSID and RMID. The CLOSID is
> used to lookup the control policy, the RMID is used for monitoring. For
> x86 these are independent numbers.
> Arm's MPAM has equivalent features PARTID and PMG, where the PARTID is
> used to lookup the control policy. The PMG in contrast is a small number
> of bits that are used to subdivide PARTID when monitoring. The
> cache-occupancy monitors require the PARTID to be specified when
> monitoring.
> 
> This means MPAM's PMG field is not unique. There are multiple PMG-0, one
> per allocated CLOSID/PARTID. If PMG is treated as equivalent to RMID, it
> cannot be allocated as an independent number. Bitmaps like rmid_busy_llc
> need to be sized by the number of unique entries for this resource.
> 
> Treat the combined CLOSID and RMID as an index, and provide architecture
> helpers to pack and unpack an index. This makes the MPAM values unique.
> The domain's rmid_busy_llc and rmid_ptrs[] are then sized by index, as
> are domain mbm_local[] and mbm_total[].
> 
> x86 can ignore the CLOSID field when packing and unpacking an index, and
> report as many indexes as RMID.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette