Received-SPF: pass (google.com: domain of linux-kernel+bounces-2080-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e54dedf6-158f-4553-b309-e4c61d69587a@intel.com>
Date: Fri, 15 Dec 2023 20:58:03 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 05/24] x86/resctrl: Track the closid with the rmid
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20231215174343.13872-1-james.morse@arm.com>
 <20231215174343.13872-6-james.morse@arm.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215174343.13872-6-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWxxUVl1K09rVzh3RXBySkNucjhtM3pmQVRHTUYzaFhUZHBxTlZVVHo4VjRV?=
 =?utf-8?B?Q1cwVjRXV3pLVUlKOXd1dmRkb1EvMFVSTm5QS25pL2hsVUIvTmN6TVBQOGVR?=
 =?utf-8?B?czdhUVlVeC9zN2t6dUkwZGtBeFhTeVljMjR1M3I2VG9EZXMzMG5zTlliNHo1?=
 =?utf-8?B?TWFVOWtPcUJIMklLMFNBL0JERFJNU25tUFBhb1QyMDFUU3lXQ0pMR2Qybk9W?=
 =?utf-8?B?aERUTVBNNDNKWjdsME5rR3FoOHFHeExMR0piN0dqQjRyZklyNmxDZ3lmU1Jl?=
 =?utf-8?B?RzRsT0Zqb0FUdW5zTitSMGlYLzFiWkw2ZjBCTmpIRFd1SC9LZDlkMERXTGti?=
 =?utf-8?B?WmxEekRQVnRKNHV4MVFhR1c5M2p1S3hDV2FmZ1NhbVpxblRTV2hranN2RXpV?=
 =?utf-8?B?MXBlRnNwZmlZMnIrc1FRYlh2VFloQ3h0cWFVQmo5b1hSMklONHVEc3JLRkJ4?=
 =?utf-8?B?Zm1rdGEraldJVVJsOGlkR0xJdCthRFNxTkFYMWorR0RSMjlObExyejFzSDZM?=
 =?utf-8?B?NTR6b05XQXFKVDg1UW1XdnZyY3lZSmhVU0NMVUFjSFN0RFlKNTVnK29yaUpQ?=
 =?utf-8?B?cEZEZW4vL2U2SWZYNDRXcDBRdmwyZzJQa2hIQ2w1ZTNxTGdBT2toT0dXN3JL?=
 =?utf-8?B?WnZmSllZYTFpVjEraG4rNGFRRHN6bzBQVGR5RGhOaXlwZ1JjSTlFTnZDVFcz?=
 =?utf-8?B?a3FaYlRRZ2xyTkpxdW1ZTmU4TzM3SXJyZmhlNEZJTVNwV0ErVmpRL2owZnFv?=
 =?utf-8?B?NkhoSGhWOXBqbnhDS1I3ZnBWeXYrdFM1UVl2b2F0VUpvM0RYVlljT0RGdWdF?=
 =?utf-8?B?WXVtaEdqMU5TZ0p3RlllVnNma01mZzdhS1BqTEZTam1DektoOTR0emFHNXNV?=
 =?utf-8?B?WE1kVXI5SDlTOWQwRlIrY1Rjc1lDU1pOTjNrWHhCcmhKVnVtUUkvcHExeXdJ?=
 =?utf-8?B?Z1pGNUorcWxBdUo5VTFKTURESkpoeFlnVjlFanRpYVNTWkMxRXl5ZmQycW5s?=
 =?utf-8?B?eGYwMnpzdW1KZFlueW1xN2picUFicFBFNEtIdkY3U3pzQ1BNMHZlYU9nNjE4?=
 =?utf-8?B?cUdsNlNERFJUL2pLNnFZSEpNUm4vakI1U0FZTVQ1eURwZUxNMHp5RGh0aTZW?=
 =?utf-8?B?ZVJNaFJYSlIybjkyRUlic08xRDNXeFppZkNsVHNkaCtBdDlmckJUYk5peTh1?=
 =?utf-8?B?WThMTnZDNkJYUUVwdENiTkx1YlJsblhzeWtUVGNUTzh0M29TOUlycXhFWnJY?=
 =?utf-8?B?bk9mMENXWU1BSGFsU2t1ZnNNQzVaQzVaU28wU3ZEMWFyc0FLcG1hT2NCRVF1?=
 =?utf-8?B?STZQS0xaYUw0K0RnZlZuaFgrNGpZR3ErK1lDL3IwekdYdFpSc1RockdOcFlJ?=
 =?utf-8?B?aXZvSFBlM1F0RWRpcE5Edk9UR1l4WldyRFRXb3NFYmxOZXg5MFdQWWdlYks5?=
 =?utf-8?B?T2dPSi92SVZET2EzbXV6c2NGY2dBYWxpZmlLSGxBRzVmdHowTnU0SEY3dmEx?=
 =?utf-8?B?NFQ2bVhoeUYxS1R4K3I2eXJKZmJESnpXai9MNFVianNKY1JKZkxiVnJncUsz?=
 =?utf-8?B?V0pBRk10MUZybkUzb1FHOGFhZTYzWUM2RlVjL0JhUWlDQVRFUWJiUEhiakcz?=
 =?utf-8?B?ak5ZTnRDc1ZGR0RXMUFDWElULzRlb0hVMFhuMC9DYUoxb2pVVFFPWjN0aDJZ?=
 =?utf-8?B?dmlJZzF3VjhqdlpZK0VJQUlOdzJWNlFucHVsZ09kR1pvRmxBQnZBWUhIWTI0?=
 =?utf-8?B?K1JQUU5jbGQwaWZWZk16aGlSQUtudjVBd3BBNEV3OXplZjhNd1JvZXF1a3pm?=
 =?utf-8?B?dGVMeTlweit3VS9wL3ZidXdGWlprbDJWWmJFWHJOZHhTekY0Wllra1RYUXRQ?=
 =?utf-8?B?cFlndzU0STIwUkJnbEZkeHNCV1NVZzYrRHFzMS9Ba1FCaS9hcVVSNUFmb0NU?=
 =?utf-8?B?bjUzSUkrZ0J5ZE9ZMGJsc2VOVDVqVUI3RWVEbnpNYjBJN3FEcjY5VzhQcVZp?=
 =?utf-8?B?WXdpZ2xEejQ3bXkvY1ZUL3dHcWtudWZ2NHFMenJ5dFRNbDJwb3ZsOWV0M2Nh?=
 =?utf-8?B?SHB4SDVKa0R6REFGU3M5S3BwMnJnbjhOT05UZXMzNit1YnhEZHJYSWx6eVY1?=
 =?utf-8?B?UzVUaUxvc2RjWVBaUkdoYVZUNllId1EzbUpmRHFZbCtVcmt5STFqeXk2Q1Bt?=
 =?utf-8?B?UWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e0b5cc8-0fee-40ac-5dc8-08dbfdf396c8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2023 04:58:05.2900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XMhxaqPHxv52Q1kGdNIoCBXTSYbplsV0T6h6FcIE3B2GfRleXed/ngCBvFLG1oWGq6vJtNDI+ZNRX+fwJHEbk/YLJHz1eabEGxuoog72A0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6147
X-OriginatorOrg: intel.com

Hi James,

On 12/15/2023 9:43 AM, James Morse wrote:
> x86's RMID are independent of the CLOSID. An RMID can be allocated,
> used and freed without considering the CLOSID.
> 
> MPAM's equivalent feature is PMG, which is not an independent number,
> it extends the CLOSID/PARTID space. For MPAM, only PMG-bits worth of
> 'RMID' can be allocated for a single CLOSID.
> i.e. if there is 1 bit of PMG space, then each CLOSID can have two
> monitor groups.
> 
> To allow resctrl to disambiguate RMID values for different CLOSID,
> everything in resctrl that keeps an RMID value needs to know the CLOSID
> too. This will always be ignored on x86.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Xin Hao <xhao@linux.alibaba.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette