Received-SPF: pass (google.com: domain of linux-kernel+bounces-2084-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <25e75e7a-7cda-4099-8331-8fb1050a9dd5@intel.com>
Date: Fri, 15 Dec 2023 21:01:37 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 10/24] x86/resctrl: Allocate the cleanest CLOSID by
 searching closid_num_dirty_rmid
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20231215174343.13872-1-james.morse@arm.com>
 <20231215174343.13872-11-james.morse@arm.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231215174343.13872-11-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEJRU0lPTnREZ1g0cXk2bjlkaGlFdmszY3NaQ2VrVVRoVVJiWWs3NitpTUlz?=
 =?utf-8?B?bHF4YmM2bmtzRm1HTk5uUTFWU2dKNy9BTzl4VU12RlBPemtPQmg3OGZoek43?=
 =?utf-8?B?bHJJSXVlS3lxR0lSdTZUdm9ZM2I2M2w0OFJkc3lwcVpNMHoyRzFJL0YwNzIx?=
 =?utf-8?B?c051RkcyaHdxS2N3T2Y0aHErSHBsY3o2RnlFY0h5azJzYyt5Rm5jUFQ2S2My?=
 =?utf-8?B?UDM2UWNNdHk4TEczVW1uM21zbDlJNmFEZ3dFakJ6UzdVS2llQW05aGNlelpy?=
 =?utf-8?B?RG5YeWhOZjFmWjRaTC9BejRLWUxxVGdlTmtSMWVuS29KUXVOSHVqd2Z1YTVE?=
 =?utf-8?B?VmwxUnhJbUp2d1VQTFozV0RVK0lWZnNSRjNNOTdoZnFDK2lVZDdaYjhkNXhp?=
 =?utf-8?B?ZWQwTDY1OU44R3Q3MTYwZ3VPSTVmOHBZZHZSRzFEUXFHTkd2Y0dEaHU1NDR0?=
 =?utf-8?B?a0FoWHM3eWtsWi84NUVWWml4L0c2em80Sit2VnNXV0QwOGtCbWlnblV6bXFr?=
 =?utf-8?B?MlFqbWNsL0lCeWNQNkp0aklhMjlwTTREelM2eldkSmh1cDNGSWQwQjJScENP?=
 =?utf-8?B?K3U2WXplUStpRTllMDNLMm5nelZpUXBUNUZ3LzllZzNaMjN6V1NvTWNPWkR4?=
 =?utf-8?B?TWNFcUtNaXFDR3k0YnROblE3d1B5ZkREbWJsOFZUbC8yUW1rMXhETEhKd3Va?=
 =?utf-8?B?Q1k5Und0aHFpWWxiUlBudVFCVUJxZW1VdzZGYi9xMEJKVzhCaFRmclpMLzBa?=
 =?utf-8?B?L2huT1R4UnNIMHVVNDZQUzZBVUtrQ1NsQnA4N2tPSyszbXJXbThiUytzdzNs?=
 =?utf-8?B?WWpudzY2SUNobzVYYWlUVjlkRDVuSzRPQzNnQ3kvN2JwdENrMHZ5VWhybCti?=
 =?utf-8?B?MEUvREJLd1Y0WVJFZ0NtZHhiOVFZRVFhSjVRSEhBWlQ0dkU3eU5KMC9XbExP?=
 =?utf-8?B?SHBpN0FrV1QwYllzVWVkZ0RvNzB6UGU0bWxuenJGSkJ6VzNvZWUwcW1RTzFB?=
 =?utf-8?B?WUFKVE51MXd1ZmdZdENSOTREZ3lsUW9tM3BpVVFiYjB3eDY4ak5XdUFpK1R6?=
 =?utf-8?B?WTFyOHdwVjNZbjZobVhCY1ZCRVlHZVdJVjZSalN6TDhtQ3JnZXZaVG5qclFa?=
 =?utf-8?B?LzA2ZURFSHdJbjNxTXBoZUk3RTFVZTJkRklVVlpseUtmWk1VUFZBTlQxRGVk?=
 =?utf-8?B?M2hNa1FqbjRmclN6T3lSRHBJMXlXdlB0SU1oSUxyZkpsRzc3TXkwMVBrZEZh?=
 =?utf-8?B?NzVTeVg5RVVKaExSalZ5ZU1IUFc4UjlTVmxZdUNLRkM2R2ZqUzBTY1VVQ0hM?=
 =?utf-8?B?d3BRL2xYNWVUVjVKQ2ZtamZjdklFMEpkaENaSWdtNnFtVlNmR2h1MzJSVUtY?=
 =?utf-8?B?dTk4R3VmL3gyNjdMRFN5VFIrU2JZNkRyZVBwbUxDcjVDTzFHMEVNZ2RKNDlj?=
 =?utf-8?B?QzJkWXBrQnU0RXA3SC9sRm41UkpVNlQydHFtZFowZ2FEYWQ3Z3IyMTRpdVZT?=
 =?utf-8?B?RGpSSjRPTmVJVG1MeE92QVF5Z2kxODBzZlBWRFpDVUsrbk1ZWmxOZG96d2RY?=
 =?utf-8?B?Z0hFU2F0YXNKa1hRWlBhQjZ2UXZaMGhHc1M3d0hUTm9ka2FvNXdBRCtmNUIz?=
 =?utf-8?B?WmpCMk4xU3pkaDZ2bVNjNzJVTWx6K21FdFZta1dLbG5NNXdDdDRkeFlRZkNl?=
 =?utf-8?B?TkpHcHpES1pKVlZwUjNZbHZuUDljcUMrQnZZRkdySDRpTUxUdUkvV0NoWDlX?=
 =?utf-8?B?NmVCZWlzYlhLWDZmMi8xTWQ1bFJRUC9UTWZFdlNUL0NGWEd6WVY0ZWgyUisy?=
 =?utf-8?B?TTNWZ0tVWE44Mk45cEdVSEpWWmFkN084SkdDM1JHaXVFR01qKzRJNEs4SkFk?=
 =?utf-8?B?MHZNK2xkN2lYTjQvZVBFSWw4b2RvdEYvc3JTNUk3ZTMwckxPVHdZMGxxTVhv?=
 =?utf-8?B?ckFPdUdpSzBJNGRnOERFTTNOQlNxSUpSdXM2L2xHWlJtRmRLSEVMWVN0bWlC?=
 =?utf-8?B?NStiNFJ1VThjemIyb1BqcDhuWWNjSUIvQitvcGloaFZhLzZLRzJpRm5SS1Jo?=
 =?utf-8?B?ditBdE1ZekxqSU5pSUFldWIzZ0xqbnVWbGRwdWc1aFhzai9qTnE5OFBkWTlu?=
 =?utf-8?B?Z2lFVGVrT3FUYW1mUmZaQlBxN1B1MkxOd3hGN1VYSmM4VzNmNmliZ3hMWTVX?=
 =?utf-8?B?Nnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd9ee912-63ea-4712-01fd-08dbfdf41737
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2023 05:01:40.7903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lJiUEqNvUh8HIo/z0HwHT6lkOA2NhZ4Wqd4bM9SweB33O/ZWDnYvLY5yeI6l9A70W1CoHrfdwYb74TayG8qxSxUK7egf7Cg55sas3xOmoIk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6147
X-OriginatorOrg: intel.com

Hi James,

On 12/15/2023 9:43 AM, James Morse wrote:
> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be
> used for different control groups.
> 
> This means once a CLOSID is allocated, all its monitoring ids may still be
> dirty, and held in limbo.
> 
> Instead of allocating the first free CLOSID, on architectures where
> CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is enabled, search
> closid_num_dirty_rmid[] to find the cleanest CLOSID.
> 
> The CLOSID found is returned to closid_alloc() for the free list
> to be updated.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---
> Changes since v4:
>  * Dropped stale section from comment
> 
> Changes since v5:
>  * Renamed some variables.
> 
> Changes since v7:
>  * Made comments over closid_num_dirty_rmid() not a kdoc comment.

(This is an example of me not relying on you dropping my reviewed-by tag
to take a look at new changes.)

This change is unexpected and does not have anything to do with this patch.
Instead it just seems to undo a change that sneaked into patch #8
of this series.

Reinette