Received-SPF: pass (google.com: domain of linux-kernel+bounces-2086-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 15 Dec 2023 23:11:22 -0600
From: Bjorn Andersson <andersson@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: enable GPU clock controller for
 SM8[45]50
Message-ID: <5kkk7j6425wshf2bmmhrh26jwc3rstcrm6kgxyyzowq2qqrfw2@u2mgm6qefxvk>
References: <20231204-topic-sm8x50-upstream-gpucc-defconfig-v1-1-e615df0c4af9@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231204-topic-sm8x50-upstream-gpucc-defconfig-v1-1-e615df0c4af9@linaro.org>

On Mon, Dec 04, 2023 at 02:01:47PM +0100, Neil Armstrong wrote:
> Enable GPU Clock Controller for SM8450 and SM8550 to allow using
> Adreno GPU on these SoCs.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 5ad2b841aafc..56aebbdcdd40 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1266,6 +1266,8 @@ CONFIG_SM_TCSRCC_8550=y
>  CONFIG_SM_GPUCC_6115=m
>  CONFIG_SM_GPUCC_8150=y
>  CONFIG_SM_GPUCC_8250=y
> +CONFIG_SM_GPUCC_8450=y
> +CONFIG_SM_GPUCC_8550=y

I don't think these needs to be builtin, and if they do I'd like to see
the reason captured in the commit message.

Regards,
Bjorn

>  CONFIG_SM_VIDEOCC_8250=y
>  CONFIG_QCOM_HFPLL=y
>  CONFIG_CLK_GFM_LPASS_SM8250=m
> 
> ---
> base-commit: 9046d05c6ad632a271fc4173624e26f396975a80
> change-id: 20231204-topic-sm8x50-upstream-gpucc-defconfig-3e3dc264be08
> 
> Best regards,
> -- 
> Neil Armstrong <neil.armstrong@linaro.org>
>